@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix issue with ref/fixes in commit messages
Summary: Fixes T4600. If there's also a revision, the variable "$message" gets overwritten. groan~
Test Plan: Pushed a commit with "Fixes T123" and a revision, saw it parse on the first try.
Reviewers: btrahan
Reviewed By: btrahan
Subscribers: chrisbolt, aran, epriestley
Maniphest Tasks: T4600
Differential Revision: https://secure.phabricator.com/D8519
+3
-3
+3
-3
src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php
+3
-3
src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php
···
128
128
$actor);
129
129
130
130
if ($committer_name && ($committer_name != $author_name)) {
131
-
$message = pht(
131
+
$revision_update_comment = pht(
132
132
'Closed by commit %s (authored by %s, committed by %s).',
133
133
$commit_name,
134
134
$author_name,
135
135
$committer_name);
136
136
} else {
137
-
$message = pht(
137
+
$revision_update_comment = pht(
138
138
'Closed by commit %s (authored by %s).',
139
139
$commit_name,
140
140
$author_name);
···
170
170
->setIgnoreOnNoEffect(true)
171
171
->attachComment(
172
172
id(new DifferentialTransactionComment())
173
-
->setContent($message));
173
+
->setContent($revision_update_comment));
174
174
175
175
$content_source = PhabricatorContentSource::newForSource(
176
176
PhabricatorContentSource::SOURCE_DAEMON,