recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Restrict marking task duplicate to "merge duplicates" workflow

Summary: Fixes T4819, remove status "duplicate" from dropdown in edit task unless task is already in duplicate status

Test Plan: Edit task, not in duplicate status, verify dropdown does not have "duplicate" option. Edit task already in "duplicate" status, verify that dropdown shows "duplicate" status option.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: epriestley, Korvin

Maniphest Tasks: T4819

Differential Revision: https://secure.phabricator.com/D8902

authored by

lkassianik and committed by
epriestley 1d5731b1 f32971cf

+9 -1
+9 -1
src/applications/maniphest/controller/ManiphestTaskEditController.php
··· 569 569 ->setValue($task->getTitle())); 570 570 571 571 if ($can_edit_status) { 572 + // See T4819. 573 + $status_map = ManiphestTaskStatus::getTaskStatusMap(); 574 + $dup_status = ManiphestTaskStatus::getDuplicateStatus(); 575 + 576 + if ($task->getStatus() != $dup_status) { 577 + unset($status_map[$dup_status]); 578 + } 579 + 572 580 $form 573 581 ->appendChild( 574 582 id(new AphrontFormSelectControl()) 575 583 ->setLabel(pht('Status')) 576 584 ->setName('status') 577 585 ->setValue($task->getStatus()) 578 - ->setOptions(ManiphestTaskStatus::getTaskStatusMap())); 586 + ->setOptions($status_map)); 579 587 } 580 588 581 589 $policies = id(new PhabricatorPolicyQuery())