@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Correct logic in PHUIActionPanelView
Summary: We should only be adding space then a status is set, not a state.
Test Plan: Test on UIExamples, still renders as expected.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Differential Revision: https://secure.phabricator.com/D11844
+11
-6
+2
-2
resources/celerity/map.php
+2
-2
resources/celerity/map.php
···
122
122
'rsrc/css/phui/calendar/phui-calendar.css' => '8675968e',
123
123
'rsrc/css/phui/phui-action-header-view.css' => '89c497e7',
124
124
'rsrc/css/phui/phui-action-list.css' => '9ee9910a',
125
-
'rsrc/css/phui/phui-action-panel.css' => 'd2e088bd',
125
+
'rsrc/css/phui/phui-action-panel.css' => '3ee9afd5',
126
126
'rsrc/css/phui/phui-box.css' => '7b3a2eed',
127
127
'rsrc/css/phui/phui-button.css' => 'ffe12633',
128
128
'rsrc/css/phui/phui-crumbs-view.css' => '594d719e',
···
771
771
'phrequent-css' => 'ffc185ad',
772
772
'phriction-document-css' => '7d7f0071',
773
773
'phui-action-header-view-css' => '89c497e7',
774
-
'phui-action-panel-css' => 'd2e088bd',
774
+
'phui-action-panel-css' => '3ee9afd5',
775
775
'phui-box-css' => '7b3a2eed',
776
776
'phui-button-css' => 'ffe12633',
777
777
'phui-calendar-css' => '8675968e',
+4
-3
src/view/phui/PHUIActionPanelView.php
+4
-3
src/view/phui/PHUIActionPanelView.php
···
82
82
83
83
$classes = array();
84
84
$classes[] = 'phui-action-panel';
85
-
if ($this->state) {
86
-
$classes[] = 'phui-action-panel-has-state';
85
+
if ($this->status) {
86
+
$classes[] = 'phui-action-panel-has-status';
87
87
$classes[] = $this->state;
88
88
89
89
}
···
158
158
if ($this->status && $this->state) {
159
159
$state_icon = $this->getStateIcon();
160
160
$status = phutil_tag(
161
-
'div',
161
+
($this->href) ? 'a' : 'div',
162
162
array(
163
163
'class' => 'phui-action-panel-status',
164
+
'href' => ($this->href) ? $this->href : null,
164
165
),
165
166
array($state_icon, $this->status));
166
167
}
+5
-1
webroot/rsrc/css/phui/phui-action-panel.css
+5
-1
webroot/rsrc/css/phui/phui-action-panel.css
···
6
6
position: relative;
7
7
}
8
8
9
-
.phui-action-panel-has-state.phui-action-panel {
9
+
.phui-action-panel-has-status.phui-action-panel {
10
10
padding-bottom: 44px;
11
11
}
12
12
···
64
64
bottom: 0;
65
65
left: 0;
66
66
right: 0;
67
+
}
68
+
69
+
.phui-action-panel-status:hover {
70
+
text-decoration: none;
67
71
}
68
72
69
73
.phui-action-panel-none .phui-action-panel-status {