recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix overzealous subscribing in EditEngine

Summary:
See T9905#148799. The CommentEditField generated empty comment transactions; these are dropped later, but before they are dropped they would trigger implicit CCs.

The implicit CC rule should probably be narrower, but we shouldn't be generating these transactions in the first place.

Test Plan: No longer implicitly CC'd on a task when doing something minor like changing projects.

Reviewers: chad

Reviewed By: chad

Subscribers: avivey

Differential Revision: https://secure.phabricator.com/D14795

epriestley 1d72c97f 4b3dcd55

+4
+4
src/applications/transactions/editfield/PhabricatorCommentEditField.php
··· 11 11 return new PhabricatorCommentEditType(); 12 12 } 13 13 14 + public function shouldGenerateTransactionsFromSubmit() { 15 + return false; 16 + } 17 + 14 18 public function shouldGenerateTransactionsFromComment() { 15 19 return true; 16 20 }