@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Replace custom yellow color for table row highlighting by variable

Summary:
Replace hardcolor yellow color `#fdf9e4` for a static highlighted table row with the variable `{$sh-yellowbackground}`. This does not directly improve dark mode but it will later allow to adjust all uses of `{$sh-yellowbackground}` to be suitable for dark mode.

The current yellow highlighting color is static as it is passed by the id URI parameter. It is unrelated to hover behavior.

Note that this is a color change. Previously, the exact yellow color depended on whether the table line is an alternative row or not (every other row is "alternative" for better reading). This patch ignores that for the sake of simplicity. (There is no such differentiation either when hovering over an alt line or non-alt line, the hover color remains `#3c4b5e`.)

Refs T15056

Test Plan:
* Go to http://phorge.localhost/settings/panel/display/ and set `Accessibility` to `Dark Mode (Experimental)`
* Go to http://phorge.localhost/settings/panel/multifactor/ and set up two MFA auth factors for an account
* After adding an auth factor, note the `id` parameter in the URI, highlighting the item in the table; explicitly set these two id parameters when testing

Reviewers: O1 Blessed Committers, mainframe98

Reviewed By: O1 Blessed Committers, mainframe98

Subscribers: mainframe98, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15056

Differential Revision: https://we.phorge.it/D26156

+4 -4
+3 -3
resources/celerity/map.php
··· 9 9 'names' => array( 10 10 'conpherence.pkg.css' => '384ce2d9', 11 11 'conpherence.pkg.js' => '020aebcf', 12 - 'core.pkg.css' => 'ee0f01e1', 12 + 'core.pkg.css' => '58f1a8df', 13 13 'core.pkg.js' => '83580d78', 14 14 'dark-console.pkg.js' => '187792c2', 15 15 'differential.pkg.css' => '4c951b31', ··· 30 30 'rsrc/css/aphront/list-filter-view.css' => 'feb64255', 31 31 'rsrc/css/aphront/multi-column.css' => 'fbc00ba3', 32 32 'rsrc/css/aphront/notification.css' => '30240bd2', 33 - 'rsrc/css/aphront/table-view.css' => '7a1c897a', 33 + 'rsrc/css/aphront/table-view.css' => '29486d14', 34 34 'rsrc/css/aphront/tokenizer.css' => '194e8160', 35 35 'rsrc/css/aphront/tooltip.css' => 'b6d94bea', 36 36 'rsrc/css/aphront/typeahead-browse.css' => 'b7ed02d2', ··· 519 519 'aphront-dialog-view-css' => '6f4ea703', 520 520 'aphront-list-filter-view-css' => 'feb64255', 521 521 'aphront-multi-column-view-css' => 'fbc00ba3', 522 - 'aphront-table-view-css' => '7a1c897a', 522 + 'aphront-table-view-css' => '29486d14', 523 523 'aphront-tokenizer-control-css' => '194e8160', 524 524 'aphront-tooltip-css' => 'b6d94bea', 525 525 'aphront-typeahead-control-css' => '5da109c8',
+1 -1
webroot/rsrc/css/aphront/table-view.css
··· 263 263 } 264 264 265 265 .aphront-table-view tr.highlighted { 266 - background: #fdf9e4; 266 + background: {$sh-yellowbackground}; 267 267 } 268 268 269 269 .aphront-table-view tr.alt-highlighted {