recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix PHP 8.5 null array key in "Add Dashboard to Favorites Menu" dialog without workflowKey set

Summary:
Setting null as an array key is deprecated since PHP 8.5 per https://www.php.net/releases/8.5/en.php: "Using null as an array offset or when calling array_key_exists() is now deprecated. Use an empty string instead."

```
ERROR 8192: Using null as an array offset is deprecated, use an empty string instead at [/var/www/html/phorge/phorge/src/applications/dashboard/controller/dashboard/PhabricatorDashboardInstallController.php:35]
```

Closes T16432

Test Plan:
* PHP 8.5
* Go to http://phorge.localhost/dashboard/view/1/
* Select "Add Dashboard to Menu"
* Select "Add to Favorites Menu"
* Get the "Add Dashboard to Favorites Menu" overlay menu

Reviewers: O1 Blessed Committers, mainframe98

Reviewed By: O1 Blessed Committers, mainframe98

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T16432

Differential Revision: https://we.phorge.it/D26652

Andre Klapper 1d9c6adf af706f99

+1 -1
+1 -1
src/applications/dashboard/controller/dashboard/PhabricatorDashboardInstallController.php
··· 32 32 $workflow_key = $request->getURIData('workflowKey'); 33 33 34 34 $workflows = PhabricatorDashboardInstallWorkflow::getAllWorkflows(); 35 - if (!isset($workflows[$workflow_key])) { 35 + if ($workflow_key === null || !isset($workflows[$workflow_key])) { 36 36 return $this->newWorkflowDialog($dashboard, $workflows); 37 37 } 38 38