recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix more "msort()" vs "msortv()" callsites

Summary:
See <https://discourse.phabricator-community.org/t/unhandled-exception-when-logging-in-with-mfa/2828>. The recent changes to turn `msort()` on a vector an error have smoked out a few more of these mistakes.

These cases do not meaningfully rely on sort stability so there's no real bug being fixed, but we'd still prefer `msortv()`.

Test Plan: Viewed MFA and External Account settings panels. Did a `git grep 'msort(' | grep -i vector` for any more obvious callsites, but none turned up.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D20587

epriestley 1dd62f79 731b45d8

+3 -3
+1 -1
src/applications/auth/engine/PhabricatorAuthSessionEngine.php
··· 485 485 // change the order of prompts for users, but the alternative is that the 486 486 // Settings panel order disagrees with the prompt order, which seems more 487 487 // disruptive. 488 - $factors = msort($factors, 'newSortVector'); 488 + $factors = msortv($factors, 'newSortVector'); 489 489 490 490 // If the account has no associated multi-factor auth, just issue a token 491 491 // without putting the session into high security mode. This is generally
+1 -1
src/applications/settings/panel/PhabricatorExternalAccountsSettingsPanel.php
··· 94 94 ->setViewer($viewer) 95 95 ->withIsEnabled(true) 96 96 ->execute(); 97 - $configs = msort($configs, 'getSortVector'); 97 + $configs = msortv($configs, 'getSortVector'); 98 98 99 99 $account_map = mgroup($accounts, 'getProviderConfigPHID'); 100 100
+1 -1
src/applications/settings/panel/PhabricatorMultiFactorSettingsPanel.php
··· 54 54 ->setViewer($viewer) 55 55 ->withUserPHIDs(array($user->getPHID())) 56 56 ->execute(); 57 - $factors = msort($factors, 'newSortVector'); 57 + $factors = msortv($factors, 'newSortVector'); 58 58 59 59 $rows = array(); 60 60 $rowc = array();