@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Implement option 1 from T3210
Summary: Fixes T3210
Test Plan: Run the conduit call via the UI and ensure it no longer breaks. Check I get an error returned if no params are set
Reviewers: epriestley
Reviewed By: epriestley
CC: aran, Korvin
Maniphest Tasks: T3210
Differential Revision: https://secure.phabricator.com/D5950
authored by
Gareth Evans
and committed by
epriestley
1dd91bde
27a02653
+11
-1
+11
-1
src/applications/maniphest/conduit/ConduitAPI_maniphest_update_Method.php
+11
-1
src/applications/maniphest/conduit/ConduitAPI_maniphest_update_Method.php
···
13
13
public function defineErrorTypes() {
14
14
return array(
15
15
'ERR-BAD-TASK' => 'No such maniphest task exists.',
16
-
'ERR-INVALID-PARAMETER' => 'Missing or malformed parameter.'
16
+
'ERR-INVALID-PARAMETER' => 'Missing or malformed parameter.',
17
+
'ERR-NO-EFFECT' => 'Update has no effect.',
17
18
);
18
19
}
19
20
···
39
40
$task = id(new ManiphestTask())->loadOneWhere(
40
41
'phid = %s',
41
42
$phid);
43
+
}
44
+
45
+
$params = $request->getAllParameters();
46
+
unset($params['id']);
47
+
unset($params['phid']);
48
+
$params = call_user_func_array('coalesce', $params);
49
+
50
+
if (!$params) {
51
+
throw new ConduitException('ERR-NO-EFFECT');
42
52
}
43
53
44
54
if (!$task) {