@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Restored title for object handles
Summary: I shouldn't delete code because it has no call-sites :P
Test Plan: Set my status to away, verified I got a hover title (no card).
Reviewers: vrana, epriestley
Reviewed By: epriestley
CC: aran, Korvin
Differential Revision: https://secure.phabricator.com/D5662
authored by
Anh Nhan Nguyen
and committed by
epriestley
1e1c99c9
5ea08732
+15
-1
+13
-1
src/applications/phid/PhabricatorObjectHandle.php
+13
-1
src/applications/phid/PhabricatorObjectHandle.php
···
7
7
private $type;
8
8
private $name;
9
9
private $fullName;
10
+
private $title;
10
11
private $imageURI;
11
12
private $timestamp;
12
13
private $status = PhabricatorObjectHandleStatus::STATUS_OPEN;
···
59
60
return $this->fullName;
60
61
}
61
62
return $this->getName();
63
+
}
64
+
65
+
public function setTitle($title) {
66
+
$this->title = $title;
67
+
return $this;
68
+
}
69
+
70
+
public function getTitle() {
71
+
return $this->title;
62
72
}
63
73
64
74
public function setType($type) {
···
171
181
$name = $this->getLinkName();
172
182
}
173
183
$class = null;
174
-
$title = null;
184
+
$title = $this->title;
175
185
176
186
if ($this->status != PhabricatorObjectHandleStatus::STATUS_OPEN) {
177
187
$class .= ' handle-status-'.$this->status;
188
+
$title = $title ? $title : $this->status;
178
189
}
179
190
180
191
if ($this->disabled) {
···
187
198
array(
188
199
'href' => $this->getURI(),
189
200
'class' => $class,
201
+
'title' => $title,
190
202
),
191
203
$name);
192
204
}
+2
src/applications/phid/handle/PhabricatorObjectHandleData.php
+2
src/applications/phid/handle/PhabricatorObjectHandleData.php