@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Use setDrag UI for reordering workboard columns
Summary: This UI can use the setDrag call to reduce clutter on the reodering dialog.
Test Plan:
Reorder some columns, save.
{F4959906}
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Differential Revision: https://secure.phabricator.com/D17898
+16
-12
+6
-6
resources/celerity/map.php
+6
-6
resources/celerity/map.php
···
9
9
'names' => array(
10
10
'conpherence.pkg.css' => 'ff161f2d',
11
11
'conpherence.pkg.js' => 'b5b51108',
12
-
'core.pkg.css' => 'd1bf3405',
12
+
'core.pkg.css' => 'ee5f28cd',
13
13
'core.pkg.js' => '2ff7879f',
14
14
'darkconsole.pkg.js' => '1f9a31bc',
15
15
'differential.pkg.css' => '58712637',
···
129
129
'rsrc/css/phui/calendar/phui-calendar.css' => '477acfaa',
130
130
'rsrc/css/phui/object-item/phui-oi-big-ui.css' => '19f9369b',
131
131
'rsrc/css/phui/object-item/phui-oi-color.css' => 'cd2b9b77',
132
-
'rsrc/css/phui/object-item/phui-oi-drag-ui.css' => 'f12cbc9f',
132
+
'rsrc/css/phui/object-item/phui-oi-drag-ui.css' => '08f4ccc3',
133
133
'rsrc/css/phui/object-item/phui-oi-flush-ui.css' => '9d9685d6',
134
134
'rsrc/css/phui/object-item/phui-oi-list-view.css' => '7c8ec27a',
135
135
'rsrc/css/phui/object-item/phui-oi-simple-ui.css' => 'a8beebea',
···
873
873
'phui-object-box-css' => '9cff003c',
874
874
'phui-oi-big-ui-css' => '19f9369b',
875
875
'phui-oi-color-css' => 'cd2b9b77',
876
-
'phui-oi-drag-ui-css' => 'f12cbc9f',
876
+
'phui-oi-drag-ui-css' => '08f4ccc3',
877
877
'phui-oi-flush-ui-css' => '9d9685d6',
878
878
'phui-oi-list-view-css' => '7c8ec27a',
879
879
'phui-oi-simple-ui-css' => 'a8beebea',
···
976
976
'javelin-dom',
977
977
'javelin-stratcom',
978
978
'javelin-vector',
979
+
),
980
+
'08f4ccc3' => array(
981
+
'phui-oi-list-view-css',
979
982
),
980
983
'0a0b10e9' => array(
981
984
'javelin-behavior',
···
2169
2172
),
2170
2173
'f10fd7a3' => array(
2171
2174
'javelin-install',
2172
-
),
2173
-
'f12cbc9f' => array(
2174
-
'phui-oi-list-view-css',
2175
2175
),
2176
2176
'f50152ad' => array(
2177
2177
'phui-timeline-view-css',
+2
-6
src/applications/project/controller/PhabricatorProjectBoardReorderController.php
+2
-6
src/applications/project/controller/PhabricatorProjectBoardReorderController.php
···
94
94
$list = id(new PHUIObjectItemListView())
95
95
->setUser($viewer)
96
96
->setID($list_id)
97
-
->setFlush(true);
97
+
->setFlush(true)
98
+
->setDrag(true);
98
99
99
100
foreach ($columns as $column) {
100
101
// Don't allow milestone columns to be reordered.
···
134
135
'reorderURI' => $reorder_uri,
135
136
));
136
137
137
-
$note = id(new PHUIInfoView())
138
-
->appendChild(pht('Drag and drop columns to reorder them.'))
139
-
->setSeverity(PHUIInfoView::SEVERITY_NOTICE);
140
-
141
138
return $this->newDialog()
142
139
->setTitle(pht('Reorder Columns'))
143
140
->setWidth(AphrontDialogView::WIDTH_FORM)
144
-
->appendChild($note)
145
141
->appendChild($list)
146
142
->addSubmitButton(pht('Done'));
147
143
}
+8
webroot/rsrc/css/phui/object-item/phui-oi-drag-ui.css
+8
webroot/rsrc/css/phui/object-item/phui-oi-drag-ui.css
···
23
23
margin-top: 4px;
24
24
}
25
25
26
+
.phui-oi-drag .phui-oi-name {
27
+
padding-left: 0;
28
+
}
29
+
26
30
.phui-oi-drag.phui-oi-with-image-icon .phui-oi-frame,
27
31
.phui-oi-drag.phui-oi-with-image .phui-oi-frame,
28
32
.phui-oi-drag .phui-oi-frame {
···
57
61
.phui-oi-list-drag .drag-ghost {
58
62
margin-top: 4px;
59
63
}
64
+
65
+
.phui-oi-list-drag .phui-object-icon-pane {
66
+
padding-right: 8px;
67
+
}