@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Change spacing, layout of ObjectItem states
Summary:
A few tweaks:
- Height in box is consistent now at 50px an Object
- Divider/rule extends full width of box
- Icon centers inside rule, box area.
Test Plan:
Test UIExamples, check spacing with 4px grid in Photoshop. Test mobile/desktop layout of Harbormaster.
{F149599}
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: epriestley, Korvin
Differential Revision: https://secure.phabricator.com/D8929
+19
-6
+3
-3
resources/celerity/map.php
+3
-3
resources/celerity/map.php
···
7
7
return array(
8
8
'names' =>
9
9
array(
10
-
'core.pkg.css' => 'cc50ddf5',
10
+
'core.pkg.css' => 'cd6367eb',
11
11
'core.pkg.js' => '417722ff',
12
12
'darkconsole.pkg.js' => 'ca8671ce',
13
13
'differential.pkg.css' => '8a064eb7',
···
137
137
'rsrc/css/phui/phui-info-panel.css' => '27ea50a1',
138
138
'rsrc/css/phui/phui-list.css' => 'ef8035b6',
139
139
'rsrc/css/phui/phui-object-box.css' => 'ce92d8ec',
140
-
'rsrc/css/phui/phui-object-item-list-view.css' => 'c11ec980',
140
+
'rsrc/css/phui/phui-object-item-list-view.css' => '574faec3',
141
141
'rsrc/css/phui/phui-pinboard-view.css' => '4b346c2a',
142
142
'rsrc/css/phui/phui-property-list-view.css' => 'c4d44192',
143
143
'rsrc/css/phui/phui-remarkup-preview.css' => '19ad512b',
···
761
761
'phui-info-panel-css' => '27ea50a1',
762
762
'phui-list-view-css' => 'ef8035b6',
763
763
'phui-object-box-css' => 'ce92d8ec',
764
-
'phui-object-item-list-view-css' => 'c11ec980',
764
+
'phui-object-item-list-view-css' => '574faec3',
765
765
'phui-pinboard-view-css' => '4b346c2a',
766
766
'phui-property-list-view-css' => 'c4d44192',
767
767
'phui-remarkup-preview-css' => '19ad512b',
+8
src/applications/uiexample/examples/PHUIObjectItemListExample.php
+8
src/applications/uiexample/examples/PHUIObjectItemListExample.php
···
398
398
->setHref('#')
399
399
->setState(PHUIObjectItemView::STATE_NOTE));
400
400
401
+
$list->addItem(
402
+
id(new PHUIObjectItemView())
403
+
->setObjectName('X1203')
404
+
->setHeader(pht('Action In Progress'))
405
+
->addAttribute(pht('Outlook fuzzy, try again later'))
406
+
->setHref('#')
407
+
->setState(PHUIObjectItemView::STATE_BUILD));
408
+
401
409
$box = id(new PHUIObjectBoxView())
402
410
->setHeaderText('Test Things')
403
411
->appendChild($list);
+8
-3
webroot/rsrc/css/phui/phui-object-item-list-view.css
+8
-3
webroot/rsrc/css/phui/phui-object-item-list-view.css
···
608
608
.phui-object-item-ficon {
609
609
width: 26px;
610
610
height: 26px;
611
-
margin: 7px 9px 7px 0;
611
+
margin: 11px 9px 7px 12px;
612
612
position: absolute;
613
+
}
614
+
615
+
.device-desktop .phui-object-list-states .phui-object-item {
616
+
margin: 0;
613
617
}
614
618
615
619
.phui-object-item-with-ficon .phui-object-item-content-box {
616
-
margin-left: 24px;
620
+
margin-left: 38px;
617
621
}
618
622
619
623
.phui-object-box .phui-object-list-states {
620
-
padding: 8px 12px 0 12px;
624
+
padding: 0;
621
625
}
622
626
623
627
.phui-object-box .phui-object-list-states li:last-child .phui-object-item-frame {
624
628
border: none;
629
+
padding-bottom: 0;
625
630
}
626
631
627
632
.phui-object-list-states .phui-object-item-frame {