@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Keep setIcon() working for now on PHUIObjectItemView
Summary:
Ref T11501. This method was removed in D16418, but still has some callsites. I know of four:
- Config
- Settings
- Drydock main page
- Almanac main page
Since I might be missing some and it's close to the release cut, just put the method back for now until we can clean it up more properly.
Test Plan: Viewed Settings, Config, Drydock, Almanac. No more fatal on this method being missing.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T11501
Differential Revision: https://secure.phabricator.com/D16420
+5
+5
src/view/phui/PHUIObjectItemView.php
+5
src/view/phui/PHUIObjectItemView.php
···
167
167
return $this;
168
168
}
169
169
170
+
public function setIcon($icon) {
171
+
// TODO: Remove this in favor of setStatusIcon()?
172
+
return $this->setStatusIcon($icon);
173
+
}
174
+
170
175
public function setStatusIcon($icon, $label = null) {
171
176
$this->statusIcon = array(
172
177
'icon' => $icon,