recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

a11y: Improve HTML table in PHUIFormationView

Summary:
Ideally this would not be a "layout table" at all but for now, improve accessibility by
* marking the table in `PHUIFormationView` as a non-data table via `role="presentation"` so most screenreader software will not output the table skeleton parts; see https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Reference/Roles/presentation_role
* explicitly setting `aria-hidden="true"` on the `PHUIFormationResizerView` visual slider to completely hide it from screenreader software.

Closes T16195

Test Plan: Go to http://phorge.localhost/D1, inspect the HTML table parameters. Or try some screenreader software on it and realize a small improvement.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T16195

Differential Revision: https://we.phorge.it/D26221

Andre Klapper 1f70ea9b 42731493

+2
+1
src/view/formation/PHUIFormationResizerView.php
··· 29 29 'div', 30 30 array( 31 31 'id' => $this->getID(), 32 + 'aria-hidden' => 'true', 32 33 'class' => 'phui-formation-resizer', 33 34 'style' => $style, 34 35 ));
+1
src/view/formation/PHUIFormationView.php
··· 80 80 array( 81 81 'id' => $this->getID(), 82 82 'class' => 'phui-formation-view', 83 + 'role' => 'presentation', 83 84 'sigil' => 'phuix-formation-view', 84 85 'meta' => array( 85 86 'items' => $phuix_items,