recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix repository URI generation for SVN commit identifiers represented with integer types

Summary:
Ref T13588. See PHI2198. Some pathways represent SVN commit identifiers (which are numeric) with integers; these raise an exception in `phutil_nonempty_string()`, which is strict.

(Ideally, commit identifiers wouldn't have mixed types, but that's a dramatically less practical change.)

Test Plan: Will deploy.

Maniphest Tasks: T13588

Differential Revision: https://secure.phabricator.com/D21852

epriestley 1fc04e23 944b257d

+1 -1
+1 -1
src/applications/repository/storage/PhabricatorRepository.php
··· 752 752 } 753 753 754 754 $raw_commit = $commit; 755 - if (phutil_nonempty_string($commit)) { 755 + if (phutil_nonempty_scalar($commit)) { 756 756 $commit = str_replace('$', '$$', $commit); 757 757 $commit = ';'.phutil_escape_uri($commit); 758 758 }