recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix invalid redirect when issuing actions on buildables

Summary: Caught this with the new redirect validation logic. The `$return_uri` was being set as just `B123` which is not valid. Prefixing it with `/` (like is done in `HarbormasterBuildActionController` already) gives the correct result of reloading the buildable's page.

Test Plan: Restarted all builds on a buildable, saw the page reload correctly.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D10320

James Rhodes 1ffa16aa b7ad48aa

+1 -1
+1 -1
src/applications/harbormaster/controller/HarbormasterBuildableActionController.php
··· 54 54 } 55 55 } 56 56 57 - $return_uri = $buildable->getMonogram(); 57 + $return_uri = '/'.$buildable->getMonogram(); 58 58 if ($request->isDialogFormPost() && $issuable) { 59 59 $editor = id(new HarbormasterBuildableTransactionEditor()) 60 60 ->setActor($viewer)