recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Render Remarkup in emails

Summary: Ref T992. I noticed that `ManiphestTask` mail doesn't render Remarkup properly (instead, it renders Remarkup literally). I //think// this is because the code calls `addTextSection()` rather than `addRemarkupSection()`.

Test Plan: Created a new Maniphest Task and saw Remarkup in the generated self-email (inspect the email contents with `./bin/mail show-outbound`). I didn't test the other affected applications.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin

Maniphest Tasks: T992

Differential Revision: https://secure.phabricator.com/D14511

Joshua Spence 2047483c df7f21b4

+11 -11
+1 -1
src/applications/audit/editor/PhabricatorAuditEditor.php
··· 660 660 } 661 661 662 662 if ($inlines) { 663 - $body->addTextSection( 663 + $body->addRemarkupSection( 664 664 pht('INLINE COMMENTS'), 665 665 $this->renderInlineCommentsForMail($object, $inlines)); 666 666 }
+1 -1
src/applications/badges/editor/PhabricatorBadgesEditor.php
··· 194 194 $body = parent::buildMailBody($object, $xactions); 195 195 196 196 if (strlen($description)) { 197 - $body->addTextSection( 197 + $body->addRemarkupSeciton( 198 198 pht('BADGE DESCRIPTION'), 199 199 $object->getDescription()); 200 200 }
+1 -1
src/applications/countdown/editor/PhabricatorCountdownEditor.php
··· 173 173 $description = $object->getDescription(); 174 174 175 175 if (strlen($description)) { 176 - $body->addTextSection( 176 + $body->addRemarkupSection( 177 177 pht('COUNTDOWN DESCRIPTION'), 178 178 $object->getDescription()); 179 179 }
+1 -1
src/applications/differential/customfield/DifferentialSummaryField.php
··· 165 165 return; 166 166 } 167 167 168 - $body->addTextSection(pht('REVISION SUMMARY'), $summary); 168 + $body->addRemarkupSection(pht('REVISION SUMMARY'), $summary); 169 169 } 170 170 171 171 }
+1 -1
src/applications/differential/customfield/DifferentialTestPlanField.php
··· 195 195 return; 196 196 } 197 197 198 - $body->addTextSection(pht('TEST PLAN'), $test_plan); 198 + $body->addRemarkupSection(pht('TEST PLAN'), $test_plan); 199 199 } 200 200 201 201
+1 -1
src/applications/differential/editor/DifferentialTransactionEditor.php
··· 1212 1212 } 1213 1213 1214 1214 if ($inlines) { 1215 - $body->addTextSection( 1215 + $body->addRemarkupSection( 1216 1216 pht('INLINE COMMENTS'), 1217 1217 $this->renderInlineCommentsForMail($object, $inlines)); 1218 1218 }
+1 -1
src/applications/maniphest/editor/ManiphestTransactionEditor.php
··· 442 442 $body = parent::buildMailBody($object, $xactions); 443 443 444 444 if ($this->getIsNewObject()) { 445 - $body->addTextSection( 445 + $body->addRemarkupSection( 446 446 pht('TASK DESCRIPTION'), 447 447 $object->getDescription()); 448 448 }
+1 -1
src/applications/phriction/editor/PhrictionTransactionEditor.php
··· 419 419 $body = parent::buildMailBody($object, $xactions); 420 420 421 421 if ($this->getIsNewObject()) { 422 - $body->addTextSection( 422 + $body->addRemarkupSection( 423 423 pht('DOCUMENT CONTENT'), 424 424 $object->getContent()->getContent()); 425 425 } else if ($this->contentDiffURI) {
+1 -1
src/applications/phurl/editor/PhabricatorPhurlURLEditor.php
··· 236 236 $body = parent::buildMailBody($object, $xactions); 237 237 238 238 if (strlen($description)) { 239 - $body->addTextSection( 239 + $body->addRemarkupSection( 240 240 pht('URL DESCRIPTION'), 241 241 $object->getDescription()); 242 242 }
+1 -1
src/applications/releeph/editor/ReleephRequestTransactionalEditor.php
··· 249 249 if ($has_pick_failure) { 250 250 $instructions = $releeph_project->getDetail('pick_failure_instructions'); 251 251 if ($instructions) { 252 - $body->addTextSection( 252 + $body->addRemarkupSection( 253 253 pht('PICK FAILURE INSTRUCTIONS'), 254 254 $instructions); 255 255 }
+1 -1
src/applications/slowvote/editor/PhabricatorSlowvoteEditor.php
··· 145 145 $description = $object->getDescription(); 146 146 147 147 if (strlen($description)) { 148 - $body->addTextSection( 148 + $body->addRemarkupSection( 149 149 pht('SLOWVOTE DESCRIPTION'), 150 150 $object->getDescription()); 151 151 }