recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix PhabricatorBot ignore messages from senders

Summary:
PhabricatorBotMessage->getSender returns a PhabricatorBotUser object (which potentially can be null)
So check null and then use getName to get actual name of the sender

Test Plan: Run phabot and add myself to ignore list

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D5036

authored by

John Watson and committed by
epriestley 204d6481 28bdeb6d

+5 -2
+5 -2
src/infrastructure/daemon/bot/PhabricatorBot.php
··· 107 107 108 108 private function routeMessage(PhabricatorBotMessage $message) { 109 109 $ignore = $this->getConfig('ignore'); 110 - if ($ignore && in_array($message->getSender(), $ignore)) { 111 - return; 110 + if ($ignore) { 111 + $sender = $message->getSender(); 112 + if ($sender && in_array($sender->getName(), $ignore)) { 113 + return; 114 + } 112 115 } 113 116 114 117 foreach ($this->handlers as $handler) {