@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Settings - upgrade monospace font regexp to support '.'
Summary: this data is a little weird since its user-entered and we need to put it in a web page un-escaped for the font to load correctly. Ergo, we use a regex to make the input safe / sane, and said regex needs to support a '.'. Fixes T5810.
Test Plan: added Fixedsys Excelsior 3.01 to my system and was able to set my preference and get the new font
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: dereckson, epriestley, Korvin
Maniphest Tasks: T5810
Differential Revision: https://secure.phabricator.com/D10163
+1
-1
+1
-1
src/applications/settings/panel/PhabricatorSettingsPanelDisplayPreferences.php
+1
-1
src/applications/settings/panel/PhabricatorSettingsPanelDisplayPreferences.php
···
32
32
$monospaced = $request->getStr($pref_monospaced);
33
33
34
34
// Prevent the user from doing stupid things.
35
-
$monospaced = preg_replace('/[^a-z0-9 ,"]+/i', '', $monospaced);
35
+
$monospaced = preg_replace('/[^a-z0-9 ,".]+/i', '', $monospaced);
36
36
37
37
$preferences->setPreference($pref_titles, $request->getStr($pref_titles));
38
38
$preferences->setPreference($pref_editor, $request->getStr($pref_editor));