@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Mark external -> external redirects in Phame to canonicalize URIs as "external"
Summary: Ref T9897. If you visit `/post/123/spoderman/` it will try to redirect you to `/post/123/spiderman/`, but currently only internal views work because these redirects aren't marked as safe/external.
Test Plan: Visited a misspelled/out-of-date URI on an external blog view, got a good redirect.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T9897
Differential Revision: https://secure.phabricator.com/D14741
+8
-1
+8
-1
src/applications/phame/controller/PhameLiveController.php
+8
-1
src/applications/phame/controller/PhameLiveController.php
···
129
129
$uri = $post->getViewURI();
130
130
}
131
131
132
-
return id(new AphrontRedirectResponse())->setURI($uri);
132
+
$response = id(new AphrontRedirectResponse())
133
+
->setURI($uri);
134
+
135
+
if ($is_external) {
136
+
$response->setIsExternal(true);
137
+
}
138
+
139
+
return $response;
133
140
}
134
141
}
135
142