@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Move setup issue callout to under the header
Summary: Fixes T7830. Moves the callout to sit under the main header, which resolved Differential issues and Durable Column issues, but still some extra CSS shenanigans.
Test Plan:
Test lots of pages, Home, Dashboards, Conpherence, Durable Column, Inline Diff Replies, Mobile, Workboards, etc.
{F375821}
{F375822}
{F375823}
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Maniphest Tasks: T7830
Differential Revision: https://secure.phabricator.com/D12466
+40
-22
+13
-13
resources/celerity/map.php
+13
-13
resources/celerity/map.php
···
7
7
*/
8
8
return array(
9
9
'names' => array(
10
-
'core.pkg.css' => 'd3651813',
10
+
'core.pkg.css' => 'bf29d341',
11
11
'core.pkg.js' => '347cd64a',
12
12
'darkconsole.pkg.js' => '8ab24e01',
13
13
'differential.pkg.css' => '3500921f',
···
37
37
'rsrc/css/application/base/main-menu-view.css' => 'c648b2f5',
38
38
'rsrc/css/application/base/notification-menu.css' => '3c9d8aa1',
39
39
'rsrc/css/application/base/phabricator-application-launch-view.css' => '16ca323f',
40
-
'rsrc/css/application/base/standard-page-view.css' => 'd2a6518d',
40
+
'rsrc/css/application/base/standard-page-view.css' => 'd3e1abe9',
41
41
'rsrc/css/application/chatlog/chatlog.css' => '852140ff',
42
42
'rsrc/css/application/config/config-options.css' => '7fedf08b',
43
43
'rsrc/css/application/config/config-template.css' => '8e6c6fcd',
44
44
'rsrc/css/application/config/config-welcome.css' => '6abd79be',
45
45
'rsrc/css/application/config/setup-issue.css' => '22270af2',
46
46
'rsrc/css/application/config/unhandled-exception.css' => '37d4f9a2',
47
-
'rsrc/css/application/conpherence/durable-column.css' => '51c1e074',
47
+
'rsrc/css/application/conpherence/durable-column.css' => '5faebda3',
48
48
'rsrc/css/application/conpherence/menu.css' => 'f389e048',
49
-
'rsrc/css/application/conpherence/message-pane.css' => '18ac5e85',
49
+
'rsrc/css/application/conpherence/message-pane.css' => 'e7c09fda',
50
50
'rsrc/css/application/conpherence/notification.css' => 'd208f806',
51
51
'rsrc/css/application/conpherence/transaction.css' => '25138b7f',
52
52
'rsrc/css/application/conpherence/update.css' => '1099a660',
53
-
'rsrc/css/application/conpherence/widget-pane.css' => 'a9082fd0',
53
+
'rsrc/css/application/conpherence/widget-pane.css' => '2af42ebe',
54
54
'rsrc/css/application/contentsource/content-source-view.css' => '4b8b05d4',
55
55
'rsrc/css/application/countdown/timer.css' => '86b7b0a0',
56
56
'rsrc/css/application/dashboard/dashboard.css' => '17937d22',
···
110
110
'rsrc/css/core/core.css' => '76e8ee93',
111
111
'rsrc/css/core/remarkup.css' => 'e10512ff',
112
112
'rsrc/css/core/syntax.css' => '56c1ba38',
113
-
'rsrc/css/core/z-index.css' => 'd1a30710',
113
+
'rsrc/css/core/z-index.css' => '72110fd4',
114
114
'rsrc/css/diviner/diviner-shared.css' => '38813222',
115
115
'rsrc/css/font/font-awesome.css' => 'ae9a7b4d',
116
116
'rsrc/css/font/font-source-sans-pro.css' => '4a2430d7',
···
150
150
'rsrc/css/phui/phui-tag-view.css' => 'ea469f3a',
151
151
'rsrc/css/phui/phui-text.css' => 'cf019f54',
152
152
'rsrc/css/phui/phui-timeline-view.css' => 'b0fbc4d7',
153
-
'rsrc/css/phui/phui-workboard-view.css' => '8896938c',
153
+
'rsrc/css/phui/phui-workboard-view.css' => '3279cbbf',
154
154
'rsrc/css/phui/phui-workpanel-view.css' => 'e495a5cc',
155
155
'rsrc/css/sprite-gradient.css' => '4bdb98a7',
156
156
'rsrc/css/sprite-login.css' => 'a355d921',
···
518
518
'changeset-view-manager' => '58562350',
519
519
'config-options-css' => '7fedf08b',
520
520
'config-welcome-css' => '6abd79be',
521
-
'conpherence-durable-column-view' => '51c1e074',
521
+
'conpherence-durable-column-view' => '5faebda3',
522
522
'conpherence-menu-css' => 'f389e048',
523
-
'conpherence-message-pane-css' => '18ac5e85',
523
+
'conpherence-message-pane-css' => 'e7c09fda',
524
524
'conpherence-notification-css' => 'd208f806',
525
525
'conpherence-thread-manager' => '0a5192c4',
526
526
'conpherence-transaction-css' => '25138b7f',
527
527
'conpherence-update-css' => '1099a660',
528
-
'conpherence-widget-pane-css' => 'a9082fd0',
528
+
'conpherence-widget-pane-css' => '2af42ebe',
529
529
'differential-changeset-view-css' => 'e19cfd6e',
530
530
'differential-core-view-css' => '7ac3cabc',
531
531
'differential-inline-comment-editor' => '2529c82d',
···
752
752
'phabricator-side-menu-view-css' => '7e8c6341',
753
753
'phabricator-slowvote-css' => '266df6a1',
754
754
'phabricator-source-code-view-css' => '2ceee894',
755
-
'phabricator-standard-page-view' => 'd2a6518d',
755
+
'phabricator-standard-page-view' => 'd3e1abe9',
756
756
'phabricator-textareautils' => '5c93c52c',
757
757
'phabricator-title' => 'df5e11d2',
758
758
'phabricator-tooltip' => '1d298e3a',
···
767
767
'phabricator-uiexample-reactor-select' => 'a155550f',
768
768
'phabricator-uiexample-reactor-sendclass' => '1def2711',
769
769
'phabricator-uiexample-reactor-sendproperties' => 'b1f0ccee',
770
-
'phabricator-zindex-css' => 'd1a30710',
770
+
'phabricator-zindex-css' => '72110fd4',
771
771
'phame-css' => '88bd4705',
772
772
'pholio-css' => '95174bdd',
773
773
'pholio-edit-css' => '3ad9d1ee',
···
809
809
'phui-tag-view-css' => 'ea469f3a',
810
810
'phui-text-css' => 'cf019f54',
811
811
'phui-timeline-view-css' => 'b0fbc4d7',
812
-
'phui-workboard-view-css' => '8896938c',
812
+
'phui-workboard-view-css' => '3279cbbf',
813
813
'phui-workpanel-view-css' => 'e495a5cc',
814
814
'phuix-action-list-view' => 'b5c256b8',
815
815
'phuix-action-view' => '6e8cefa4',
+2
-2
src/view/page/PhabricatorStandardPageView.php
+2
-2
src/view/page/PhabricatorStandardPageView.php
···
392
392
'class' => 'phabricator-standard-page',
393
393
),
394
394
array(
395
+
$developer_warning,
395
396
$header_chrome,
397
+
$setup_warning,
396
398
phutil_tag(
397
399
'div',
398
400
array(
···
422
424
'class' => implode(' ', $classes),
423
425
),
424
426
array(
425
-
$developer_warning,
426
-
$setup_warning,
427
427
$main_page,
428
428
$durable_column,
429
429
));
+7
-2
webroot/rsrc/css/application/base/standard-page-view.css
+7
-2
webroot/rsrc/css/application/base/standard-page-view.css
···
111
111
}
112
112
113
113
.setup-warning-callout {
114
+
padding: 8px 16px;
115
+
background: {$lightred};
116
+
border-bottom: 1px solid {$sh-redborder};
114
117
position: relative;
115
-
padding: 8px 16px;
116
-
background: {$lightyellow};
118
+
}
119
+
120
+
.setup-warning-callout a {
121
+
color: {$red};
117
122
}
118
123
119
124
.phui-handle .phui-icon-view {
-4
webroot/rsrc/css/application/conpherence/durable-column.css
-4
webroot/rsrc/css/application/conpherence/durable-column.css
+4
webroot/rsrc/css/application/conpherence/message-pane.css
+4
webroot/rsrc/css/application/conpherence/message-pane.css
+9
webroot/rsrc/css/application/conpherence/widget-pane.css
+9
webroot/rsrc/css/application/conpherence/widget-pane.css
···
16
16
-webkit-overflow-scrolling: touch;
17
17
}
18
18
19
+
.page-has-warning .conpherence-widget-pane,
20
+
.page-had-warning .loading .widgets-loading-mask {
21
+
top: 110px;
22
+
}
23
+
19
24
.device .conpherence-widget-pane,
20
25
.device .loading .widgets-loading-mask {
21
26
top: 44px;
···
80
85
.device-desktop .conpherence-widget-pane .widgets-body {
81
86
top: 108px;
82
87
width: 240px;
88
+
}
89
+
90
+
.device-desktop .page-has-warning .conpherence-widget-pane .widgets-body {
91
+
top: 142px;
83
92
}
84
93
85
94
/* files widget */
+1
-1
webroot/rsrc/css/core/z-index.css
+1
-1
webroot/rsrc/css/core/z-index.css