@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Don't require project edit permission to create a project with members other than yourself
Summary: See PHI193. Previously, see similar D18763. Skip this legacy-style policy check when creating a project, since we know you can add members, even if the policy doesn't actually resolve in your favor.
Test Plan:
- Created a project with edit policy "Members of project" and myself, plus any other user (so the code goes down this path, not the "join/leave" path) as members.
Differential Revision: https://secure.phabricator.com/D19169
+8
-5
+8
-5
src/applications/project/editor/PhabricatorProjectTransactionEditor.php
+8
-5
src/applications/project/editor/PhabricatorProjectTransactionEditor.php
···
156
156
PhabricatorPolicyCapability::CAN_EDIT);
157
157
}
158
158
} else {
159
-
// You need CAN_EDIT to change members other than yourself.
160
-
PhabricatorPolicyFilter::requireCapability(
161
-
$this->requireActor(),
162
-
$object,
163
-
PhabricatorPolicyCapability::CAN_EDIT);
159
+
if (!$this->getIsNewObject()) {
160
+
// You need CAN_EDIT to change members other than yourself.
161
+
// (PHI193) Just skip this check if we're creating a project.
162
+
PhabricatorPolicyFilter::requireCapability(
163
+
$this->requireActor(),
164
+
$object,
165
+
PhabricatorPolicyCapability::CAN_EDIT);
166
+
}
164
167
}
165
168
return;
166
169
}