recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Replace some manual class name strings with ::class keyword

Summary:
Replace classname strings in `getBaseTransactionClass()` return value with the corresponding `::class` keyword.
This will enable static code analysis to throw "Class not found" if such a class did not exist.

`::class` is available since PHP 5.5: https://www.php.net/manual/en/language.oop5.basic.php#language.oop5.basic.class.class
`::class` returns the fully qualified classname including namespace, however we do not use PHP namespaces except in imported external libraries.

See similar previous patches.

Refs T15158

Test Plan: Browse random Phorge pages?

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15158

Differential Revision: https://we.phorge.it/D26380

Andre Klapper 21262d1c 74b8a2b8

+57 -57
+1 -1
src/applications/almanac/storage/AlmanacBindingTransaction.php
··· 8 8 } 9 9 10 10 public function getBaseTransactionClass() { 11 - return 'AlmanacBindingTransactionType'; 11 + return AlmanacBindingTransactionType::class; 12 12 } 13 13 14 14 }
+1 -1
src/applications/almanac/storage/AlmanacDeviceTransaction.php
··· 8 8 } 9 9 10 10 public function getBaseTransactionClass() { 11 - return 'AlmanacDeviceTransactionType'; 11 + return AlmanacDeviceTransactionType::class; 12 12 } 13 13 14 14 }
+1 -1
src/applications/almanac/storage/AlmanacInterfaceTransaction.php
··· 8 8 } 9 9 10 10 public function getBaseTransactionClass() { 11 - return 'AlmanacInterfaceTransactionType'; 11 + return AlmanacInterfaceTransactionType::class; 12 12 } 13 13 14 14 }
+1 -1
src/applications/almanac/storage/AlmanacNamespaceTransaction.php
··· 8 8 } 9 9 10 10 public function getBaseTransactionClass() { 11 - return 'AlmanacNamespaceTransactionType'; 11 + return AlmanacNamespaceTransactionType::class; 12 12 } 13 13 14 14 }
+1 -1
src/applications/almanac/storage/AlmanacNetworkTransaction.php
··· 8 8 } 9 9 10 10 public function getBaseTransactionClass() { 11 - return 'AlmanacNetworkTransactionType'; 11 + return AlmanacNetworkTransactionType::class; 12 12 } 13 13 14 14 }
+1 -1
src/applications/almanac/storage/AlmanacServiceTransaction.php
··· 8 8 } 9 9 10 10 public function getBaseTransactionClass() { 11 - return 'AlmanacServiceTransactionType'; 11 + return AlmanacServiceTransactionType::class; 12 12 } 13 13 14 14 }
+1 -1
src/applications/audit/storage/PhabricatorAuditTransaction.php
··· 21 21 } 22 22 23 23 public function getBaseTransactionClass() { 24 - return 'DiffusionCommitTransactionType'; 24 + return DiffusionCommitTransactionType::class; 25 25 } 26 26 27 27 public function getApplicationTransactionType() {
+1 -1
src/applications/auth/storage/PhabricatorAuthContactNumberTransaction.php
··· 12 12 } 13 13 14 14 public function getBaseTransactionClass() { 15 - return 'PhabricatorAuthContactNumberTransactionType'; 15 + return PhabricatorAuthContactNumberTransactionType::class; 16 16 } 17 17 18 18 }
+1 -1
src/applications/auth/storage/PhabricatorAuthFactorProviderTransaction.php
··· 12 12 } 13 13 14 14 public function getBaseTransactionClass() { 15 - return 'PhabricatorAuthFactorProviderTransactionType'; 15 + return PhabricatorAuthFactorProviderTransactionType::class; 16 16 } 17 17 18 18 }
+1 -1
src/applications/auth/storage/PhabricatorAuthMessageTransaction.php
··· 12 12 } 13 13 14 14 public function getBaseTransactionClass() { 15 - return 'PhabricatorAuthMessageTransactionType'; 15 + return PhabricatorAuthMessageTransactionType::class; 16 16 } 17 17 18 18 }
+1 -1
src/applications/auth/storage/PhabricatorAuthPasswordTransaction.php
··· 12 12 } 13 13 14 14 public function getBaseTransactionClass() { 15 - return 'PhabricatorAuthPasswordTransactionType'; 15 + return PhabricatorAuthPasswordTransactionType::class; 16 16 } 17 17 }
+1 -1
src/applications/badges/storage/PhabricatorBadgesTransaction.php
··· 20 20 } 21 21 22 22 public function getBaseTransactionClass() { 23 - return 'PhabricatorBadgesBadgeTransactionType'; 23 + return PhabricatorBadgesBadgeTransactionType::class; 24 24 } 25 25 26 26 public function getMailTags() {
+1 -1
src/applications/calendar/storage/PhabricatorCalendarEventTransaction.php
··· 20 20 } 21 21 22 22 public function getBaseTransactionClass() { 23 - return 'PhabricatorCalendarEventTransactionType'; 23 + return PhabricatorCalendarEventTransactionType::class; 24 24 } 25 25 26 26 public function getMailTags() {
+1 -1
src/applications/calendar/storage/PhabricatorCalendarExportTransaction.php
··· 12 12 } 13 13 14 14 public function getBaseTransactionClass() { 15 - return 'PhabricatorCalendarExportTransactionType'; 15 + return PhabricatorCalendarExportTransactionType::class; 16 16 } 17 17 18 18 }
+1 -1
src/applications/calendar/storage/PhabricatorCalendarImportTransaction.php
··· 12 12 } 13 13 14 14 public function getBaseTransactionClass() { 15 - return 'PhabricatorCalendarImportTransactionType'; 15 + return PhabricatorCalendarImportTransactionType::class; 16 16 } 17 17 18 18 }
+1 -1
src/applications/conpherence/storage/ConpherenceTransaction.php
··· 16 16 } 17 17 18 18 public function getBaseTransactionClass() { 19 - return 'ConpherenceThreadTransactionType'; 19 + return ConpherenceThreadTransactionType::class; 20 20 } 21 21 22 22 }
+1 -1
src/applications/countdown/storage/PhabricatorCountdownTransaction.php
··· 20 20 } 21 21 22 22 public function getBaseTransactionClass() { 23 - return 'PhabricatorCountdownTransactionType'; 23 + return PhabricatorCountdownTransactionType::class; 24 24 } 25 25 26 26 public function getMailTags() {
+1 -1
src/applications/dashboard/storage/PhabricatorDashboardPanelTransaction.php
··· 12 12 } 13 13 14 14 public function getBaseTransactionClass() { 15 - return 'PhabricatorDashboardPanelTransactionType'; 15 + return PhabricatorDashboardPanelTransactionType::class; 16 16 } 17 17 18 18 }
+1 -1
src/applications/dashboard/storage/PhabricatorDashboardPortalTransaction.php
··· 12 12 } 13 13 14 14 public function getBaseTransactionClass() { 15 - return 'PhabricatorDashboardPortalTransactionType'; 15 + return PhabricatorDashboardPortalTransactionType::class; 16 16 } 17 17 18 18 }
+1 -1
src/applications/dashboard/storage/PhabricatorDashboardTransaction.php
··· 12 12 } 13 13 14 14 public function getBaseTransactionClass() { 15 - return 'PhabricatorDashboardTransactionType'; 15 + return PhabricatorDashboardTransactionType::class; 16 16 } 17 17 18 18 }
+1 -1
src/applications/differential/storage/DifferentialTransaction.php
··· 17 17 const MAILTAG_OTHER = 'differential-other'; 18 18 19 19 public function getBaseTransactionClass() { 20 - return 'DifferentialRevisionTransactionType'; 20 + return DifferentialRevisionTransactionType::class; 21 21 } 22 22 23 23 protected function newFallbackModularTransactionType() {
+1 -1
src/applications/drydock/storage/DrydockBlueprintTransaction.php
··· 15 15 } 16 16 17 17 public function getBaseTransactionClass() { 18 - return 'DrydockBlueprintTransactionType'; 18 + return DrydockBlueprintTransactionType::class; 19 19 } 20 20 21 21 }
+1 -1
src/applications/files/storage/PhabricatorFileTransaction.php
··· 16 16 } 17 17 18 18 public function getBaseTransactionClass() { 19 - return 'PhabricatorFileTransactionType'; 19 + return PhabricatorFileTransactionType::class; 20 20 } 21 21 22 22 }
+1 -1
src/applications/harbormaster/storage/HarbormasterBuildTransaction.php
··· 12 12 } 13 13 14 14 public function getBaseTransactionClass() { 15 - return 'HarbormasterBuildTransactionType'; 15 + return HarbormasterBuildTransactionType::class; 16 16 } 17 17 18 18 }
+1 -1
src/applications/harbormaster/storage/HarbormasterBuildableTransaction.php
··· 12 12 } 13 13 14 14 public function getBaseTransactionClass() { 15 - return 'HarbormasterBuildableTransactionType'; 15 + return HarbormasterBuildableTransactionType::class; 16 16 } 17 17 18 18 }
+1 -1
src/applications/harbormaster/storage/configuration/HarbormasterBuildPlanTransaction.php
··· 12 12 } 13 13 14 14 public function getBaseTransactionClass() { 15 - return 'HarbormasterBuildPlanTransactionType'; 15 + return HarbormasterBuildPlanTransactionType::class; 16 16 } 17 17 18 18 }
+1 -1
src/applications/herald/storage/HeraldRuleTransaction.php
··· 14 14 } 15 15 16 16 public function getBaseTransactionClass() { 17 - return 'HeraldRuleTransactionType'; 17 + return HeraldRuleTransactionType::class; 18 18 } 19 19 20 20 }
+1 -1
src/applications/herald/storage/HeraldWebhookTransaction.php
··· 12 12 } 13 13 14 14 public function getBaseTransactionClass() { 15 - return 'HeraldWebhookTransactionType'; 15 + return HeraldWebhookTransactionType::class; 16 16 } 17 17 18 18 }
+1 -1
src/applications/legalpad/storage/LegalpadTransaction.php
··· 15 15 } 16 16 17 17 public function getBaseTransactionClass() { 18 - return 'LegalpadDocumentTransactionType'; 18 + return LegalpadDocumentTransactionType::class; 19 19 } 20 20 21 21 }
+1 -1
src/applications/macro/storage/PhabricatorMacroTransaction.php
··· 20 20 } 21 21 22 22 public function getBaseTransactionClass() { 23 - return 'PhabricatorMacroTransactionType'; 23 + return PhabricatorMacroTransactionType::class; 24 24 } 25 25 26 26
+1 -1
src/applications/maniphest/storage/ManiphestTransaction.php
··· 27 27 } 28 28 29 29 public function getBaseTransactionClass() { 30 - return 'ManiphestTaskTransactionType'; 30 + return ManiphestTaskTransactionType::class; 31 31 } 32 32 33 33 public function shouldGenerateOldValue() {
+1 -1
src/applications/meta/storage/PhabricatorApplicationApplicationTransaction.php
··· 12 12 } 13 13 14 14 public function getBaseTransactionClass() { 15 - return 'PhabricatorApplicationTransactionType'; 15 + return PhabricatorApplicationTransactionType::class; 16 16 } 17 17 18 18 }
+1 -1
src/applications/nuance/storage/NuanceItemTransaction.php
··· 14 14 } 15 15 16 16 public function getBaseTransactionClass() { 17 - return 'NuanceItemTransactionType'; 17 + return NuanceItemTransactionType::class; 18 18 } 19 19 20 20 }
+1 -1
src/applications/nuance/storage/NuanceQueueTransaction.php
··· 11 11 } 12 12 13 13 public function getBaseTransactionClass() { 14 - return 'NuanceQueueTransactionType'; 14 + return NuanceQueueTransactionType::class; 15 15 } 16 16 17 17 }
+1 -1
src/applications/nuance/storage/NuanceSourceTransaction.php
··· 12 12 } 13 13 14 14 public function getBaseTransactionClass() { 15 - return 'NuanceSourceTransactionType'; 15 + return NuanceSourceTransactionType::class; 16 16 } 17 17 18 18 }
+1 -1
src/applications/owners/storage/PhabricatorOwnersPackageTransaction.php
··· 12 12 } 13 13 14 14 public function getBaseTransactionClass() { 15 - return 'PhabricatorOwnersPackageTransactionType'; 15 + return PhabricatorOwnersPackageTransactionType::class; 16 16 } 17 17 18 18 }
+1 -1
src/applications/packages/storage/PhabricatorPackagesPackageTransaction.php
··· 12 12 } 13 13 14 14 public function getBaseTransactionClass() { 15 - return 'PhabricatorPackagesPackageTransactionType'; 15 + return PhabricatorPackagesPackageTransactionType::class; 16 16 } 17 17 18 18 }
+1 -1
src/applications/packages/storage/PhabricatorPackagesPublisherTransaction.php
··· 12 12 } 13 13 14 14 public function getBaseTransactionClass() { 15 - return 'PhabricatorPackagesPublisherTransactionType'; 15 + return PhabricatorPackagesPublisherTransactionType::class; 16 16 } 17 17 18 18 }
+1 -1
src/applications/packages/storage/PhabricatorPackagesVersionTransaction.php
··· 12 12 } 13 13 14 14 public function getBaseTransactionClass() { 15 - return 'PhabricatorPackagesVersionTransactionType'; 15 + return PhabricatorPackagesVersionTransactionType::class; 16 16 } 17 17 18 18 }
+1 -1
src/applications/passphrase/storage/PassphraseCredentialTransaction.php
··· 12 12 } 13 13 14 14 public function getBaseTransactionClass() { 15 - return 'PassphraseCredentialTransactionType'; 15 + return PassphraseCredentialTransactionType::class; 16 16 } 17 17 18 18 }
+1 -1
src/applications/paste/storage/PhabricatorPasteTransaction.php
··· 20 20 } 21 21 22 22 public function getBaseTransactionClass() { 23 - return 'PhabricatorPasteTransactionType'; 23 + return PhabricatorPasteTransactionType::class; 24 24 } 25 25 26 26 public function getMailTags() {
+1 -1
src/applications/people/storage/PhabricatorUserTransaction.php
··· 12 12 } 13 13 14 14 public function getBaseTransactionClass() { 15 - return 'PhabricatorUserTransactionType'; 15 + return PhabricatorUserTransactionType::class; 16 16 } 17 17 18 18 }
+1 -1
src/applications/phame/storage/PhameBlogTransaction.php
··· 16 16 } 17 17 18 18 public function getBaseTransactionClass() { 19 - return 'PhameBlogTransactionType'; 19 + return PhameBlogTransactionType::class; 20 20 } 21 21 22 22 public function getMailTags() {
+1 -1
src/applications/phame/storage/PhamePostTransaction.php
··· 17 17 } 18 18 19 19 public function getBaseTransactionClass() { 20 - return 'PhamePostTransactionType'; 20 + return PhamePostTransactionType::class; 21 21 } 22 22 23 23 public function getApplicationTransactionCommentObject() {
+1 -1
src/applications/pholio/storage/PholioTransaction.php
··· 12 12 } 13 13 14 14 public function getBaseTransactionClass() { 15 - return 'PholioTransactionType'; 15 + return PholioTransactionType::class; 16 16 } 17 17 18 18 public function getApplicationTransactionType() {
+1 -1
src/applications/phriction/storage/PhrictionTransaction.php
··· 22 22 } 23 23 24 24 public function getBaseTransactionClass() { 25 - return 'PhrictionDocumentTransactionType'; 25 + return PhrictionDocumentTransactionType::class; 26 26 } 27 27 28 28 public function getRequiredHandlePHIDs() {
+1 -1
src/applications/phurl/storage/PhabricatorPhurlURLTransaction.php
··· 18 18 } 19 19 20 20 public function getBaseTransactionClass() { 21 - return 'PhabricatorPhurlURLTransactionType'; 21 + return PhabricatorPhurlURLTransactionType::class; 22 22 } 23 23 24 24 public function getRequiredHandlePHIDs() {
+1 -1
src/applications/ponder/storage/PonderAnswerTransaction.php
··· 20 20 } 21 21 22 22 public function getBaseTransactionClass() { 23 - return 'PonderAnswerTransactionType'; 23 + return PonderAnswerTransactionType::class; 24 24 } 25 25 26 26 public function getMailTags() {
+1 -1
src/applications/ponder/storage/PonderQuestionTransaction.php
··· 25 25 } 26 26 27 27 public function getBaseTransactionClass() { 28 - return 'PonderQuestionTransactionType'; 28 + return PonderQuestionTransactionType::class; 29 29 } 30 30 31 31 public function getMailTags() {
+1 -1
src/applications/project/storage/PhabricatorProjectColumnTransaction.php
··· 12 12 } 13 13 14 14 public function getBaseTransactionClass() { 15 - return 'PhabricatorProjectColumnTransactionType'; 15 + return PhabricatorProjectColumnTransactionType::class; 16 16 } 17 17 18 18 }
+1 -1
src/applications/project/storage/PhabricatorProjectTransaction.php
··· 20 20 } 21 21 22 22 public function getBaseTransactionClass() { 23 - return 'PhabricatorProjectTransactionType'; 23 + return PhabricatorProjectTransactionType::class; 24 24 } 25 25 26 26 public function getRequiredHandlePHIDs() {
+1 -1
src/applications/project/storage/PhabricatorProjectTriggerTransaction.php
··· 12 12 } 13 13 14 14 public function getBaseTransactionClass() { 15 - return 'PhabricatorProjectTriggerTransactionType'; 15 + return PhabricatorProjectTriggerTransactionType::class; 16 16 } 17 17 18 18 }
+1 -1
src/applications/repository/storage/PhabricatorRepositoryIdentityTransaction.php
··· 8 8 } 9 9 10 10 public function getBaseTransactionClass() { 11 - return 'PhabricatorRepositoryIdentityTransactionType'; 11 + return PhabricatorRepositoryIdentityTransactionType::class; 12 12 } 13 13 14 14 public function getApplicationName() {
+1 -1
src/applications/repository/storage/PhabricatorRepositoryTransaction.php
··· 12 12 } 13 13 14 14 public function getBaseTransactionClass() { 15 - return 'PhabricatorRepositoryTransactionType'; 15 + return PhabricatorRepositoryTransactionType::class; 16 16 } 17 17 18 18 }
+1 -1
src/applications/slowvote/storage/PhabricatorSlowvoteTransaction.php
··· 20 20 } 21 21 22 22 public function getBaseTransactionClass() { 23 - return 'PhabricatorSlowvoteTransactionType'; 23 + return PhabricatorSlowvoteTransactionType::class; 24 24 } 25 25 26 26 public function getMailTags() {
+1 -1
src/applications/spaces/storage/PhabricatorSpacesNamespaceTransaction.php
··· 12 12 } 13 13 14 14 public function getBaseTransactionClass() { 15 - return 'PhabricatorSpacesNamespaceTransactionType'; 15 + return PhabricatorSpacesNamespaceTransactionType::class; 16 16 } 17 17 18 18 }
+1 -1
src/applications/transactions/storage/PhabricatorEditEngineConfigurationTransaction.php
··· 12 12 } 13 13 14 14 public function getBaseTransactionClass() { 15 - return 'PhabricatorEditEngineTransactionType'; 15 + return PhabricatorEditEngineTransactionType::class; 16 16 } 17 17 18 18 }