recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Transactions - fix bug adding people to projects

Summary: Fixes T8264. Broken in D12929. Sweep all the applyBuiltin implementations and always break; rather than return

Test Plan: added myself to a project successfully (showed up as a member)

Reviewers: epriestley, chad

Subscribers: Korvin, epriestley

Maniphest Tasks: T6403, T8264

Differential Revision: https://secure.phabricator.com/D12940

Bob Trahan 2154f17b c896aeb6

+3 -7
+1 -1
src/applications/audit/editor/PhabricatorAuditEditor.php
··· 200 200 $state, 201 201 $phid); 202 202 } 203 - return; 203 + break; 204 204 } 205 205 206 206 return parent::applyBuiltinExternalTransaction($object, $xaction);
+1 -1
src/applications/differential/editor/DifferentialTransactionEditor.php
··· 609 609 $state, 610 610 $phid); 611 611 } 612 - return; 612 + break; 613 613 } 614 614 615 615 return parent::applyBuiltinExternalTransaction($object, $xaction);
+1 -5
src/applications/project/editor/PhabricatorProjectTransactionEditor.php
··· 163 163 PhabricatorLiskDAO $object, 164 164 PhabricatorApplicationTransaction $xaction) { 165 165 166 - $old = $xaction->getOldValue(); 167 - $new = $xaction->getNewValue(); 168 - 169 166 switch ($xaction->getTransactionType()) { 170 - 171 167 case PhabricatorTransactions::TYPE_EDGE: 172 168 $edge_type = $xaction->getMetadataValue('edge:type'); 173 169 switch ($edge_type) { ··· 220 216 } 221 217 break; 222 218 } 223 - return; 219 + break; 224 220 } 225 221 226 222 return parent::applyBuiltinExternalTransaction($object, $xaction);