@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix Project Hovercard rendering @mention
Summary:
Fix T15762. There's a complex interaction with project's AutoCapability requiring the membership info
to be already loaded, and the Mention rule assuming any project is fully loaded before trying to check
permissions.
As far as I can tell, the "contextObject" is currently used only to make the mention handle gray if
the mentioned user can't see it.
Test Plan: Load a Project's hovercard that @mentions a user that can't see the project - no crash.
Reviewers: aklapper, O1 Blessed Committers
Reviewed By: aklapper, O1 Blessed Committers
Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Maniphest Tasks: T15762
Differential Revision: https://we.phorge.it/D25562
+1
-2
+1
-2
src/applications/project/view/PhabricatorProjectCardView.php
+1
-2
src/applications/project/view/PhabricatorProjectCardView.php
···
80
80
$description = $description_field->getFieldValue();
81
81
if (phutil_nonempty_string($description)) {
82
82
$description = PhabricatorMarkupEngine::summarizeSentence($description);
83
-
$description = id(new PHUIRemarkupView($viewer, $description))
84
-
->setContextObject($project);
83
+
$description = id(new PHUIRemarkupView($viewer, $description));
85
84
86
85
$description = phutil_tag(
87
86
'div',