@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Complain if a Conduit Client doesn't send a host key.
Summary: There is a TODO here that is a few years old... the Conduit Protocol is now at version 7.
Test Plan: One less TODO in the codebase.
Reviewers: epriestley, #blessed_reviewers
Reviewed By: epriestley, #blessed_reviewers
Subscribers: epriestley, Korvin
Differential Revision: https://secure.phabricator.com/D9694
-10
-10
src/applications/conduit/method/ConduitAPIMethod.php
-10
src/applications/conduit/method/ConduitAPIMethod.php
···
137
137
}
138
138
139
139
protected function validateHost($host) {
140
-
if (!$host) {
141
-
// If the client doesn't send a host key, don't complain. We should in
142
-
// the future, but this change isn't severe enough to bump the protocol
143
-
// version.
144
-
145
-
// TODO: Remove this once the protocol version gets bumped past 2 (i.e.,
146
-
// require the host key be present and valid).
147
-
return;
148
-
}
149
-
150
140
// NOTE: Compare domains only so we aren't sensitive to port specification
151
141
// or omission.
152
142