@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix cancel button on inline comment view
Summary: Switch over to PHUIButtonView
Test Plan: Cancel, Edit, Submit new inline diff comment.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Differential Revision: https://secure.phabricator.com/D18120
+7
-8
+7
-8
src/infrastructure/diff/view/PHUIDiffInlineCommentEditView.php
+7
-8
src/infrastructure/diff/view/PHUIDiffInlineCommentEditView.php
···
121
121
private function renderBody() {
122
122
$buttons = array();
123
123
124
-
$buttons[] = phutil_tag('button', array(), pht('Save Draft'));
125
-
$buttons[] = javelin_tag(
126
-
'button',
127
-
array(
128
-
'sigil' => 'inline-edit-cancel',
129
-
'class' => 'grey',
130
-
),
131
-
pht('Cancel'));
124
+
$buttons[] = id(new PHUIButtonView())
125
+
->setText(pht('Save Draft'));
126
+
127
+
$buttons[] = id(new PHUIButtonView())
128
+
->setText(pht('Cancel'))
129
+
->setColor(PHUIButtonView::GREY)
130
+
->addSigil('inline-edit-cancel');
132
131
133
132
$title = phutil_tag(
134
133
'div',