@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix spaces UI in PHUIHeaderView
Summary: This should consistenly apply the styling regardless of font or size of the Header. Fixes T10485
Test Plan: Visit a Task and a Countdown in a different Space.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Maniphest Tasks: T10485
Differential Revision: https://secure.phabricator.com/D15374
+16
-6
+3
-3
resources/celerity/map.php
+3
-3
resources/celerity/map.php
···
7
7
*/
8
8
return array(
9
9
'names' => array(
10
-
'core.pkg.css' => 'e50c063a',
10
+
'core.pkg.css' => '3b2e293c',
11
11
'core.pkg.js' => '7d8faf57',
12
12
'darkconsole.pkg.js' => 'e7393ebb',
13
13
'differential.pkg.css' => '2de124c9',
···
135
135
'rsrc/css/phui/phui-form-view.css' => '4a1a0f5e',
136
136
'rsrc/css/phui/phui-form.css' => 'aac1d51d',
137
137
'rsrc/css/phui/phui-head-thing.css' => '11731da0',
138
-
'rsrc/css/phui/phui-header-view.css' => 'b541cc78',
138
+
'rsrc/css/phui/phui-header-view.css' => '6152c91b',
139
139
'rsrc/css/phui/phui-hovercard.css' => 'de1a2119',
140
140
'rsrc/css/phui/phui-icon-set-selector.css' => '1ab67aad',
141
141
'rsrc/css/phui/phui-icon.css' => '3f33ab57',
···
820
820
'phui-form-css' => 'aac1d51d',
821
821
'phui-form-view-css' => '4a1a0f5e',
822
822
'phui-head-thing-view-css' => '11731da0',
823
-
'phui-header-view-css' => 'b541cc78',
823
+
'phui-header-view-css' => '6152c91b',
824
824
'phui-hovercard' => '1bd28176',
825
825
'phui-hovercard-view-css' => 'de1a2119',
826
826
'phui-icon-set-selector-css' => '1ab67aad',
+6
-2
src/view/phui/PHUIHeaderView.php
+6
-2
src/view/phui/PHUIHeaderView.php
···
253
253
$left = array();
254
254
$right = array();
255
255
256
+
$space_header = null;
256
257
if ($viewer) {
257
-
$left[] = id(new PHUISpacesNamespaceContextView())
258
+
$space_header = id(new PHUISpacesNamespaceContextView())
258
259
->setUser($viewer)
259
260
->setObject($this->policyObject);
260
261
}
···
335
336
array(
336
337
'class' => 'phui-header-header',
337
338
),
338
-
$header_content);
339
+
array(
340
+
$space_header,
341
+
$header_content,
342
+
));
339
343
340
344
if ($this->subheader || $this->badges) {
341
345
$badges = null;
+7
-1
webroot/rsrc/css/phui/phui-header-view.css
+7
-1
webroot/rsrc/css/phui/phui-header-view.css
···
272
272
font-size: 18px;
273
273
}
274
274
275
-
.spaces-name .phui-handle {
275
+
.spaces-name .phui-handle,
276
+
.spaces-name a.phui-handle {
276
277
color: {$sh-redtext};
278
+
}
279
+
280
+
.device-desktop .spaces-name a.phui-handle:hover {
281
+
color: {$sh-redtext};
282
+
text-decoration: underline;
277
283
}
278
284
279
285
.phui-header-subheader .phui-badge-flex-view {