recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix PHP 8.1 "strlen(null)" exception on Diffusion repo URIs page after repo creation

Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

```
ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/repository/storage/PhabricatorRepository.php:348]
```

Closes T15658

Test Plan: Create an empty new Git repository, go to its URIs management page.

Reviewers: O1 Blessed Committers, speck

Reviewed By: O1 Blessed Committers, speck

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15658

Differential Revision: https://we.phorge.it/D25454

Andre Klapper 222a6fea d4b110af

+2 -2
+2 -2
src/applications/repository/storage/PhabricatorRepository.php
··· 345 345 346 346 // Make some reasonable effort to produce reasonable default directory 347 347 // names from repository names. 348 - if (!strlen($name)) { 348 + if (!phutil_nonempty_string($name)) { 349 349 $name = $this->getName(); 350 350 $name = phutil_utf8_strtolower($name); 351 351 $name = preg_replace('@[ -/:->]+@', '-', $name); 352 352 $name = trim($name, '-'); 353 - if (!strlen($name)) { 353 + if (!phutil_nonempty_string($name)) { 354 354 $name = $this->getCallsign(); 355 355 } 356 356 }