recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Curtain: add Hovercard support

Summary:
Before this change, the right navigation panel (Curtain) had info without Hovercard support.

After this change, all fields, like Subscribers, Tags, Referenced Files etc. have Hovercards.

If you meet an UX problem with a specific field with Hovercard, you can disable that specific
Hovercard, calling PHUICurtainObjectRefView::setHovercarded(false).

This is an example, now with Hovercard support:

{F342785}

Closes T15577

Test Plan:
No nuclear implosions when, on desktop and with a mouse:

Browse Maniphest Task and mouse hover Authored By, Assigned To, Subscribers, Referenced Files, ...

Browse Phriction document and mouse Tags, Referenced Files, Subscribers, ...

Browse single commit and mouse hover Referenced Files, Subscribers, ...

Browse Ponder question and mouse hover Tags, Referenced Files, Subscribers, ...

Browse Differential revision and mouse hover Tags, Referenced Files, Subscribers, ...

Reviewers: O1 Blessed Committers, avivey

Reviewed By: O1 Blessed Committers, avivey

Subscribers: tobiaswiese, Matthew, Cigaryno

Maniphest Tasks: T15577

Differential Revision: https://we.phorge.it/D25424

authored by

Valerio Bozzolan and committed by
Valerio Bozzolan 2295bcda 2ba2cbaf

+11 -1
+11 -1
src/view/phui/PHUICurtainObjectRefView.php
··· 7 7 private $epoch; 8 8 private $highlighted; 9 9 private $exiled; 10 + private $hovercarded = true; 10 11 private $exileNote = false; 11 12 12 13 public function setHandle(PhabricatorObjectHandle $handle) { ··· 27 28 public function setExiled($is_exiled, $note = false) { 28 29 $this->exiled = $is_exiled; 29 30 $this->exileNote = $note; 31 + return $this; 32 + } 33 + 34 + public function setHovercarded($hovercarded) { 35 + $this->hovercarded = $hovercarded; 30 36 return $this; 31 37 } 32 38 ··· 155 161 $handle = $this->handle; 156 162 157 163 if ($handle) { 158 - $title_view = $handle->renderLink(); 164 + if ($this->hovercarded) { 165 + $title_view = $handle->renderHovercardLink(); 166 + } else { 167 + $title_view = $handle->renderLink(); 168 + } 159 169 } 160 170 161 171 return $title_view;