recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Replace some manual class name strings with ::class keyword

Summary:
Replace classname strings in misc places with the corresponding `::class` keyword.
This will enable static code analysis to throw "Class not found" if such a class did not exist.

`::class` is available since PHP 5.5: https://www.php.net/manual/en/language.oop5.basic.php#language.oop5.basic.class.class
`::class` returns the fully qualified classname including namespace, however we do not use PHP namespaces except in imported external libraries.

Refs T15158

Test Plan: Browse random Phorge pages?

Reviewers: O1 Blessed Committers, mainframe98

Reviewed By: O1 Blessed Committers, mainframe98

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15158

Differential Revision: https://we.phorge.it/D26351

Andre Klapper 22b97a4b 3dfe367c

+117 -96
+1 -1
scripts/daemon/exec/exec_daemon.php
··· 99 99 pht( 100 100 'No class "%s" exists in any known library.', 101 101 $daemon)); 102 - } else if (!is_subclass_of($daemon, 'PhutilDaemon')) { 102 + } else if (!is_subclass_of($daemon, PhutilDaemon::class)) { 103 103 throw new PhutilArgumentUsageException( 104 104 pht( 105 105 'Class "%s" is not a subclass of "%s".',
+1 -1
src/aphront/handler/PhabricatorPolicyRequestExceptionHandler.php
··· 37 37 // 38 38 // Possibly we should add a header here like "you need to login to see 39 39 // the thing you are trying to look at". 40 - $auth_app_class = 'PhabricatorAuthApplication'; 40 + $auth_app_class = PhabricatorAuthApplication::class; 41 41 $auth_app = PhabricatorApplication::getByClass($auth_app_class); 42 42 43 43 return id(new PhabricatorAuthStartController())
+2 -1
src/aphront/site/PhabricatorShortSite.php
··· 32 32 } 33 33 34 34 public function getRoutingMaps() { 35 - $app = PhabricatorApplication::getByClass('PhabricatorPhurlApplication'); 35 + $app = PhabricatorApplication::getByClass( 36 + PhabricatorPhurlApplication::class); 36 37 37 38 $maps = array(); 38 39 $maps[] = $this->newRoutingMap()
+2 -2
src/applications/aphlict/query/AphlictDropdownDataQuery.php
··· 42 42 public function execute() { 43 43 $viewer = $this->getViewer(); 44 44 45 - $conpherence_app = 'PhabricatorConpherenceApplication'; 45 + $conpherence_app = PhabricatorConpherenceApplication::class; 46 46 $is_c_installed = PhabricatorApplication::isClassInstalledForViewer( 47 47 $conpherence_app, 48 48 $viewer); ··· 63 63 ); 64 64 $this->setConpherenceData($conpherence_data); 65 65 66 - $notification_app = 'PhabricatorNotificationsApplication'; 66 + $notification_app = PhabricatorNotificationsApplication::class; 67 67 $is_n_installed = PhabricatorApplication::isClassInstalledForViewer( 68 68 $notification_app, 69 69 $viewer);
+1 -1
src/applications/audit/application/PhabricatorAuditApplication.php
··· 24 24 25 25 public function isPinnedByDefault(PhabricatorUser $viewer) { 26 26 return parent::isClassInstalledForViewer( 27 - 'PhabricatorDiffusionApplication', 27 + PhabricatorDiffusionApplication::class, 28 28 $viewer); 29 29 } 30 30
+1 -1
src/applications/audit/conduit/AuditConduitAPIMethod.php
··· 4 4 5 5 final public function getApplication() { 6 6 return PhabricatorApplication::getByClass( 7 - 'PhabricatorAuditApplication'); 7 + PhabricatorAuditApplication::class); 8 8 } 9 9 10 10 }
+2 -1
src/applications/auth/conduit/PhabricatorAuthConduitAPIMethod.php
··· 3 3 abstract class PhabricatorAuthConduitAPIMethod extends ConduitAPIMethod { 4 4 5 5 final public function getApplication() { 6 - return PhabricatorApplication::getByClass('PhabricatorAuthApplication'); 6 + return PhabricatorApplication::getByClass( 7 + PhabricatorAuthApplication::class); 7 8 } 8 9 9 10 public function getMethodStatus() {
+4 -2
src/applications/auth/provider/PhabricatorAuthProvider.php
··· 335 335 } 336 336 337 337 public function getLoginURI() { 338 - $app = PhabricatorApplication::getByClass('PhabricatorAuthApplication'); 338 + $app = PhabricatorApplication::getByClass( 339 + PhabricatorAuthApplication::class); 339 340 return $app->getApplicationURI('/login/'.$this->getProviderKey().'/'); 340 341 } 341 342 ··· 344 345 } 345 346 346 347 public function getStartURI() { 347 - $app = PhabricatorApplication::getByClass('PhabricatorAuthApplication'); 348 + $app = PhabricatorApplication::getByClass( 349 + PhabricatorAuthApplication::class); 348 350 $uri = $app->getApplicationURI('/start/'); 349 351 return $uri; 350 352 }
+1 -1
src/applications/base/controller/PhabricatorController.php
··· 590 590 $must_sign_docs = array(); 591 591 $sign_docs = array(); 592 592 593 - $legalpad_class = 'PhabricatorLegalpadApplication'; 593 + $legalpad_class = PhabricatorLegalpadApplication::class; 594 594 $legalpad_installed = PhabricatorApplication::isClassInstalledForViewer( 595 595 $legalpad_class, 596 596 $viewer);
+2 -1
src/applications/base/controller/__tests__/PhabricatorAccessControlTestCase.php
··· 200 200 $env->overrideEnvConfig('policy.allow-public', false); 201 201 202 202 203 - $app = PhabricatorApplication::getByClass('PhabricatorTestApplication'); 203 + $app = PhabricatorApplication::getByClass( 204 + PhabricatorTestApplication::class); 204 205 $app->reset(); 205 206 $app->setPolicy( 206 207 PhabricatorPolicyCapability::CAN_VIEW,
+1 -1
src/applications/conduit/method/ConduitGetCapabilitiesConduitAPIMethod.php
··· 36 36 'sessionless', 37 37 ); 38 38 39 - $oauth_app = 'PhabricatorOAuthServerApplication'; 39 + $oauth_app = PhabricatorOAuthServerApplication::class; 40 40 if (PhabricatorApplication::isClassInstalled($oauth_app)) { 41 41 $authentication[] = 'oauth'; 42 42 }
+1 -1
src/applications/conpherence/conduit/ConpherenceConduitAPIMethod.php
··· 4 4 5 5 final public function getApplication() { 6 6 return PhabricatorApplication::getByClass( 7 - 'PhabricatorConpherenceApplication'); 7 + PhabricatorConpherenceApplication::class); 8 8 } 9 9 10 10 final protected function getConpherenceURI(ConpherenceThread $conpherence) {
+1 -1
src/applications/differential/conduit/DifferentialConduitAPIMethod.php
··· 4 4 5 5 final public function getApplication() { 6 6 return PhabricatorApplication::getByClass( 7 - 'PhabricatorDifferentialApplication'); 7 + PhabricatorDifferentialApplication::class); 8 8 } 9 9 10 10 protected function buildDiffInfoDictionary(DifferentialDiff $diff) {
+1 -1
src/applications/differential/controller/DifferentialController.php
··· 42 42 $viewer = $this->getViewer(); 43 43 44 44 $have_owners = PhabricatorApplication::isClassInstalledForViewer( 45 - 'PhabricatorOwnersApplication', 45 + PhabricatorOwnersApplication::class, 46 46 $viewer); 47 47 if (!$have_owners) { 48 48 return;
+1 -1
src/applications/differential/relationships/DifferentialRevisionRelationship.php
··· 7 7 $viewer = $this->getViewer(); 8 8 9 9 $has_app = PhabricatorApplication::isClassInstalledForViewer( 10 - 'PhabricatorDifferentialApplication', 10 + PhabricatorDifferentialApplication::class, 11 11 $viewer); 12 12 if (!$has_app) { 13 13 return false;
+1 -1
src/applications/diffusion/conduit/DiffusionConduitAPIMethod.php
··· 4 4 5 5 final public function getApplication() { 6 6 return PhabricatorApplication::getByClass( 7 - 'PhabricatorDiffusionApplication'); 7 + PhabricatorDiffusionApplication::class); 8 8 } 9 9 10 10 }
+1 -1
src/applications/diffusion/controller/DiffusionBrowseController.php
··· 503 503 $viewer = $this->getViewer(); 504 504 505 505 $have_owners = PhabricatorApplication::isClassInstalledForViewer( 506 - 'PhabricatorOwnersApplication', 506 + PhabricatorOwnersApplication::class, 507 507 $viewer); 508 508 if (!$have_owners) { 509 509 return null;
+1 -1
src/applications/diffusion/controller/DiffusionCommitController.php
··· 980 980 ->setDiffusionRequest($drequest); 981 981 982 982 $have_owners = PhabricatorApplication::isClassInstalledForViewer( 983 - 'PhabricatorOwnersApplication', 983 + PhabricatorOwnersApplication::class, 984 984 $viewer); 985 985 986 986 if (!$changesets) {
+1 -1
src/applications/diffusion/relationships/DiffusionCommitRelationship.php
··· 7 7 $viewer = $this->getViewer(); 8 8 9 9 $has_app = PhabricatorApplication::isClassInstalledForViewer( 10 - 'PhabricatorDiffusionApplication', 10 + PhabricatorDiffusionApplication::class, 11 11 $viewer); 12 12 if (!$has_app) { 13 13 return false;
+1 -1
src/applications/diffusion/ssh/DiffusionSSHWorkflow.php
··· 166 166 167 167 $viewer = $this->getSSHUser(); 168 168 $have_diffusion = PhabricatorApplication::isClassInstalledForViewer( 169 - 'PhabricatorDiffusionApplication', 169 + PhabricatorDiffusionApplication::class, 170 170 $viewer); 171 171 if (!$have_diffusion) { 172 172 throw new Exception(
+2 -2
src/applications/diffusion/view/DiffusionCommitGraphView.php
··· 337 337 $viewer = $this->getViewer(); 338 338 339 339 $show_builds = PhabricatorApplication::isClassInstalledForViewer( 340 - 'PhabricatorHarbormasterApplication', 340 + PhabricatorHarbormasterApplication::class, 341 341 $this->getUser()); 342 342 343 343 return $show_builds; ··· 347 347 $viewer = $this->getViewer(); 348 348 349 349 $show_revisions = PhabricatorApplication::isClassInstalledForViewer( 350 - 'PhabricatorDifferentialApplication', 350 + PhabricatorDifferentialApplication::class, 351 351 $viewer); 352 352 353 353 return $show_revisions;
+1 -1
src/applications/diffusion/view/DiffusionView.php
··· 233 233 234 234 $viewer = $this->getUser(); 235 235 236 - $harbormaster_app = 'PhabricatorHarbormasterApplication'; 236 + $harbormaster_app = PhabricatorHarbormasterApplication::class; 237 237 $have_harbormaster = PhabricatorApplication::isClassInstalledForViewer( 238 238 $harbormaster_app, 239 239 $viewer);
+1 -1
src/applications/drydock/blueprint/DrydockAlmanacServiceHostBlueprintImplementation.php
··· 7 7 private $freeBindings; 8 8 9 9 public function isEnabled() { 10 - $almanac_app = 'PhabricatorAlmanacApplication'; 10 + $almanac_app = PhabricatorAlmanacApplication::class; 11 11 return PhabricatorApplication::isClassInstalled($almanac_app); 12 12 } 13 13
+1 -1
src/applications/favorites/engineextension/PhabricatorFavoritesMainMenuBarExtension.php
··· 7 7 8 8 public function isExtensionEnabledForViewer(PhabricatorUser $viewer) { 9 9 return PhabricatorApplication::isClassInstalledForViewer( 10 - 'PhabricatorFavoritesApplication', 10 + PhabricatorFavoritesApplication::class, 11 11 $viewer); 12 12 } 13 13
+1 -1
src/applications/feed/PhabricatorFeedStoryPublisher.php
··· 99 99 $class)); 100 100 } 101 101 102 - if (!is_subclass_of($class, 'PhabricatorFeedStory')) { 102 + if (!is_subclass_of($class, PhabricatorFeedStory::class)) { 103 103 throw new Exception( 104 104 pht( 105 105 "Story type must be a valid class name and must subclass %s. ".
+2 -1
src/applications/feed/conduit/FeedConduitAPIMethod.php
··· 3 3 abstract class FeedConduitAPIMethod extends ConduitAPIMethod { 4 4 5 5 final public function getApplication() { 6 - return PhabricatorApplication::getByClass('PhabricatorFeedApplication'); 6 + return PhabricatorApplication::getByClass( 7 + PhabricatorFeedApplication::class); 7 8 } 8 9 9 10 }
+2 -1
src/applications/files/conduit/FileConduitAPIMethod.php
··· 3 3 abstract class FileConduitAPIMethod extends ConduitAPIMethod { 4 4 5 5 final public function getApplication() { 6 - return PhabricatorApplication::getByClass('PhabricatorFilesApplication'); 6 + return PhabricatorApplication::getByClass( 7 + PhabricatorFilesApplication::class); 7 8 } 8 9 9 10 protected function loadFileByPHID(PhabricatorUser $viewer, $file_phid) {
+2 -1
src/applications/flag/conduit/FlagConduitAPIMethod.php
··· 3 3 abstract class FlagConduitAPIMethod extends ConduitAPIMethod { 4 4 5 5 final public function getApplication() { 6 - return PhabricatorApplication::getByClass('PhabricatorFlagsApplication'); 6 + return PhabricatorApplication::getByClass( 7 + PhabricatorFlagsApplication::class); 7 8 } 8 9 9 10 protected function attachHandleToFlag($flag, PhabricatorUser $user) {
+1 -1
src/applications/harbormaster/conduit/HarbormasterConduitAPIMethod.php
··· 4 4 5 5 final public function getApplication() { 6 6 return PhabricatorApplication::getByClass( 7 - 'PhabricatorHarbormasterApplication'); 7 + PhabricatorHarbormasterApplication::class); 8 8 } 9 9 10 10 protected function returnArtifactList(array $artifacts) {
+1 -1
src/applications/harbormaster/storage/HarbormasterBuildable.php
··· 80 80 // Skip all of this logic if the Harbormaster application 81 81 // isn't currently installed. 82 82 83 - $harbormaster_app = 'PhabricatorHarbormasterApplication'; 83 + $harbormaster_app = PhabricatorHarbormasterApplication::class; 84 84 if (!PhabricatorApplication::isClassInstalled($harbormaster_app)) { 85 85 return; 86 86 }
+3 -3
src/applications/home/view/PHUIHomeView.php
··· 16 16 $viewer = $this->getViewer(); 17 17 18 18 $has_maniphest = PhabricatorApplication::isClassInstalledForViewer( 19 - 'PhabricatorManiphestApplication', 19 + PhabricatorManiphestApplication::class, 20 20 $viewer); 21 21 22 22 $has_diffusion = PhabricatorApplication::isClassInstalledForViewer( 23 - 'PhabricatorDiffusionApplication', 23 + PhabricatorDiffusionApplication::class, 24 24 $viewer); 25 25 26 26 $has_differential = PhabricatorApplication::isClassInstalledForViewer( 27 - 'PhabricatorDifferentialApplication', 27 + PhabricatorDifferentialApplication::class, 28 28 $viewer); 29 29 30 30 $revision_panel = null;
+2 -1
src/applications/macro/conduit/MacroConduitAPIMethod.php
··· 3 3 abstract class MacroConduitAPIMethod extends ConduitAPIMethod { 4 4 5 5 final public function getApplication() { 6 - return PhabricatorApplication::getByClass('PhabricatorMacroApplication'); 6 + return PhabricatorApplication::getByClass( 7 + PhabricatorMacroApplication::class); 7 8 } 8 9 9 10 }
+1 -1
src/applications/macro/storage/PhabricatorFileImageMacro.php
··· 137 137 return PhabricatorPolicies::getMostOpenPolicy(); 138 138 case PhabricatorPolicyCapability::CAN_EDIT: 139 139 $app = PhabricatorApplication::getByClass( 140 - 'PhabricatorMacroApplication'); 140 + PhabricatorMacroApplication::class); 141 141 return $app->getPolicy(PhabricatorMacroManageCapability::CAPABILITY); 142 142 } 143 143 }
+1 -1
src/applications/maniphest/conduit/ManiphestConduitAPIMethod.php
··· 4 4 5 5 final public function getApplication() { 6 6 return PhabricatorApplication::getByClass( 7 - 'PhabricatorManiphestApplication'); 7 + PhabricatorManiphestApplication::class); 8 8 } 9 9 10 10 protected function defineErrorTypes() {
+1 -1
src/applications/maniphest/controller/ManiphestReportController.php
··· 36 36 $nav->addFilter('user', pht('By User')); 37 37 $nav->addFilter('project', pht('By Project')); 38 38 39 - $class = 'PhabricatorFactApplication'; 39 + $class = PhabricatorFactApplication::class; 40 40 if (PhabricatorApplication::isClassInstalledForViewer($class, $viewer)) { 41 41 $nav->addLabel(pht('Burnup')); 42 42 $nav->addFilter('burn', pht('Burnup Rate'));
+1 -1
src/applications/maniphest/relationship/ManiphestTaskRelationship.php
··· 7 7 $viewer = $this->getViewer(); 8 8 9 9 $has_app = PhabricatorApplication::isClassInstalledForViewer( 10 - 'PhabricatorManiphestApplication', 10 + PhabricatorManiphestApplication::class, 11 11 $viewer); 12 12 if (!$has_app) { 13 13 return false;
+2 -1
src/applications/nuance/conduit/NuanceConduitAPIMethod.php
··· 3 3 abstract class NuanceConduitAPIMethod extends ConduitAPIMethod { 4 4 5 5 final public function getApplication() { 6 - return PhabricatorApplication::getByClass('PhabricatorNuanceApplication'); 6 + return PhabricatorApplication::getByClass( 7 + PhabricatorNuanceApplication::class); 7 8 } 8 9 9 10 public function getMethodStatus() {
+1 -1
src/applications/oauthserver/panel/PhabricatorOAuthServerAuthorizationsSettingsPanel.php
··· 30 30 // TODO: It would be nice to simply disable this panel, but we can't do 31 31 // viewer-based checks for enabled panels right now. 32 32 33 - $app_class = 'PhabricatorOAuthServerApplication'; 33 + $app_class = PhabricatorOAuthServerApplication::class; 34 34 $installed = PhabricatorApplication::isClassInstalledForViewer( 35 35 $app_class, 36 36 $viewer);
+2 -1
src/applications/owners/conduit/OwnersConduitAPIMethod.php
··· 3 3 abstract class OwnersConduitAPIMethod extends ConduitAPIMethod { 4 4 5 5 final public function getApplication() { 6 - return PhabricatorApplication::getByClass('PhabricatorOwnersApplication'); 6 + return PhabricatorApplication::getByClass( 7 + PhabricatorOwnersApplication::class); 7 8 } 8 9 9 10 }
+1 -1
src/applications/passphrase/conduit/PassphraseConduitAPIMethod.php
··· 4 4 5 5 final public function getApplication() { 6 6 return PhabricatorApplication::getByClass( 7 - 'PhabricatorPassphraseApplication'); 7 + PhabricatorPassphraseApplication::class); 8 8 } 9 9 10 10 }
+2 -1
src/applications/paste/conduit/PasteConduitAPIMethod.php
··· 3 3 abstract class PasteConduitAPIMethod extends ConduitAPIMethod { 4 4 5 5 final public function getApplication() { 6 - return PhabricatorApplication::getByClass('PhabricatorPasteApplication'); 6 + return PhabricatorApplication::getByClass( 7 + PhabricatorPasteApplication::class); 7 8 } 8 9 9 10 protected function buildPasteInfoDictionary(PhabricatorPaste $paste) {
+2 -1
src/applications/people/conduit/UserConduitAPIMethod.php
··· 3 3 abstract class UserConduitAPIMethod extends ConduitAPIMethod { 4 4 5 5 final public function getApplication() { 6 - return PhabricatorApplication::getByClass('PhabricatorPeopleApplication'); 6 + return PhabricatorApplication::getByClass( 7 + PhabricatorPeopleApplication::class); 7 8 } 8 9 9 10 protected function buildUserInformationDictionary(
+1 -1
src/applications/people/controller/PhabricatorPeopleProfileBadgesController.php
··· 16 16 return new Aphront404Response(); 17 17 } 18 18 19 - $class = 'PhabricatorBadgesApplication'; 19 + $class = PhabricatorBadgesApplication::class; 20 20 if (!PhabricatorApplication::isClassInstalledForViewer($class, $viewer)) { 21 21 return new Aphront404Response(); 22 22 }
+1 -1
src/applications/people/controller/PhabricatorPeopleProfileCommitsController.php
··· 18 18 return new Aphront404Response(); 19 19 } 20 20 21 - $class = 'PhabricatorDiffusionApplication'; 21 + $class = PhabricatorDiffusionApplication::class; 22 22 if (!PhabricatorApplication::isClassInstalledForViewer($class, $viewer)) { 23 23 return new Aphront404Response(); 24 24 }
+1 -1
src/applications/people/controller/PhabricatorPeopleProfileRevisionsController.php
··· 18 18 return new Aphront404Response(); 19 19 } 20 20 21 - $class = 'PhabricatorDifferentialApplication'; 21 + $class = PhabricatorDifferentialApplication::class; 22 22 if (!PhabricatorApplication::isClassInstalledForViewer($class, $viewer)) { 23 23 return new Aphront404Response(); 24 24 }
+1 -1
src/applications/people/controller/PhabricatorPeopleProfileTasksAssignedController.php
··· 18 18 return new Aphront404Response(); 19 19 } 20 20 21 - $class = 'PhabricatorManiphestApplication'; 21 + $class = PhabricatorManiphestApplication::class; 22 22 if (!PhabricatorApplication::isClassInstalledForViewer($class, $viewer)) { 23 23 return new Aphront404Response(); 24 24 }
+1 -1
src/applications/people/controller/PhabricatorPeopleProfileTasksAuthoredController.php
··· 18 18 return new Aphront404Response(); 19 19 } 20 20 21 - $class = 'PhabricatorManiphestApplication'; 21 + $class = PhabricatorManiphestApplication::class; 22 22 if (!PhabricatorApplication::isClassInstalledForViewer($class, $viewer)) { 23 23 return new Aphront404Response(); 24 24 }
+1 -1
src/applications/people/controller/PhabricatorPeopleProfileViewController.php
··· 177 177 */ 178 178 private function buildCalendarDayView(PhabricatorUser $user) { 179 179 $viewer = $this->getViewer(); 180 - $class = 'PhabricatorCalendarApplication'; 180 + $class = PhabricatorCalendarApplication::class; 181 181 182 182 if (!PhabricatorApplication::isClassInstalledForViewer($class, $viewer)) { 183 183 return null;
+4 -4
src/applications/people/engine/PhabricatorPeopleProfileMenuEngine.php
··· 37 37 ->setMenuItemKey(PhabricatorPeopleDetailsProfileMenuItem::MENUITEMKEY); 38 38 39 39 $have_maniphest = PhabricatorApplication::isClassInstalledForViewer( 40 - 'PhabricatorManiphestApplication', 40 + PhabricatorManiphestApplication::class, 41 41 $viewer); 42 42 if ($have_maniphest) { 43 43 $items[] = $this->newItem() ··· 51 51 } 52 52 53 53 $have_differential = PhabricatorApplication::isClassInstalledForViewer( 54 - 'PhabricatorDifferentialApplication', 54 + PhabricatorDifferentialApplication::class, 55 55 $viewer); 56 56 if ($have_differential) { 57 57 $items[] = $this->newItem() ··· 61 61 } 62 62 63 63 $have_diffusion = PhabricatorApplication::isClassInstalledForViewer( 64 - 'PhabricatorDiffusionApplication', 64 + PhabricatorDiffusionApplication::class, 65 65 $viewer); 66 66 if ($have_diffusion) { 67 67 $items[] = $this->newItem() ··· 70 70 } 71 71 72 72 $have_badges = PhabricatorApplication::isClassInstalledForViewer( 73 - 'PhabricatorBadgesApplication', 73 + PhabricatorBadgesApplication::class, 74 74 $viewer); 75 75 if ($have_badges) { 76 76 $items[] = $this->newItem()
+1 -1
src/applications/people/view/PhabricatorUserCardView.php
··· 106 106 phabricator_date($user->getDateCreated(), $viewer)); 107 107 108 108 $has_calendar = PhabricatorApplication::isClassInstalledForViewer( 109 - 'PhabricatorCalendarApplication', 109 + PhabricatorCalendarApplication::class, 110 110 $viewer); 111 111 if ($has_calendar) { 112 112 if (!$user->getIsDisabled()) {
+2 -1
src/applications/phame/site/PhameBlogSite.php
··· 65 65 } 66 66 67 67 public function getRoutingMaps() { 68 - $app = PhabricatorApplication::getByClass('PhabricatorPhameApplication'); 68 + $app = PhabricatorApplication::getByClass( 69 + PhabricatorPhameApplication::class); 69 70 70 71 $maps = array(); 71 72 $maps[] = $this->newRoutingMap()
+1 -1
src/applications/pholio/relationships/PholioMockRelationship.php
··· 7 7 $viewer = $this->getViewer(); 8 8 9 9 $has_app = PhabricatorApplication::isClassInstalledForViewer( 10 - 'PhabricatorPholioApplication', 10 + PhabricatorPholioApplication::class, 11 11 $viewer); 12 12 if (!$has_app) { 13 13 return false;
+2 -1
src/applications/phortune/provider/PhortunePaymentProvider.php
··· 270 270 $local = false) { 271 271 272 272 $id = $this->getProviderConfig()->getID(); 273 - $app = PhabricatorApplication::getByClass('PhabricatorPhortuneApplication'); 273 + $app = PhabricatorApplication::getByClass( 274 + PhabricatorPhortuneApplication::class); 274 275 $path = $app->getBaseURI().'provider/'.$id.'/'.$action.'/'; 275 276 276 277 $uri = new PhutilURI($path, $params);
+1 -1
src/applications/phrequent/conduit/PhrequentConduitAPIMethod.php
··· 4 4 5 5 final public function getApplication() { 6 6 return PhabricatorApplication::getByClass( 7 - 'PhabricatorPhrequentApplication'); 7 + PhabricatorPhrequentApplication::class); 8 8 } 9 9 10 10 }
+1 -1
src/applications/phriction/conduit/PhrictionConduitAPIMethod.php
··· 4 4 5 5 final public function getApplication() { 6 6 return PhabricatorApplication::getByClass( 7 - 'PhabricatorPhrictionApplication'); 7 + PhabricatorPhrictionApplication::class); 8 8 } 9 9 10 10 final protected function buildDocumentInfoDictionary(PhrictionDocument $doc) {
+1 -1
src/applications/ponder/storage/PonderAnswer.php
··· 165 165 return $this->getQuestion()->getPolicy($capability); 166 166 case PhabricatorPolicyCapability::CAN_EDIT: 167 167 $app = PhabricatorApplication::getByClass( 168 - 'PhabricatorPonderApplication'); 168 + PhabricatorPonderApplication::class); 169 169 return $app->getPolicy(PonderModerateCapability::CAPABILITY); 170 170 } 171 171 }
+1 -1
src/applications/ponder/storage/PonderQuestion.php
··· 216 216 return $this->getViewPolicy(); 217 217 case PhabricatorPolicyCapability::CAN_EDIT: 218 218 $app = PhabricatorApplication::getByClass( 219 - 'PhabricatorPonderApplication'); 219 + PhabricatorPonderApplication::class); 220 220 return $app->getPolicy(PonderModerateCapability::CAPABILITY); 221 221 } 222 222 }
+2 -1
src/applications/project/conduit/ProjectConduitAPIMethod.php
··· 3 3 abstract class ProjectConduitAPIMethod extends ConduitAPIMethod { 4 4 5 5 final public function getApplication() { 6 - return PhabricatorApplication::getByClass('PhabricatorProjectApplication'); 6 + return PhabricatorApplication::getByClass( 7 + PhabricatorProjectApplication::class); 7 8 } 8 9 9 10 protected function buildProjectInfoDictionary(PhabricatorProject $project) {
+2 -1
src/applications/project/controller/PhabricatorProjectBoardViewController.php
··· 756 756 757 757 $can_bulk_edit = PhabricatorPolicyFilter::hasCapability( 758 758 $viewer, 759 - PhabricatorApplication::getByClass('PhabricatorManiphestApplication'), 759 + PhabricatorApplication::getByClass( 760 + PhabricatorManiphestApplication::class), 760 761 ManiphestBulkEditCapability::CAPABILITY); 761 762 762 763 $column_move_uri = urisprintf('bulkmove/%d/column/', $column->getID());
+2 -1
src/applications/project/controller/PhabricatorProjectColumnBulkMoveController.php
··· 42 42 43 43 $can_bulk_edit = PhabricatorPolicyFilter::hasCapability( 44 44 $viewer, 45 - PhabricatorApplication::getByClass('PhabricatorManiphestApplication'), 45 + PhabricatorApplication::getByClass( 46 + PhabricatorManiphestApplication::class), 46 47 ManiphestBulkEditCapability::CAPABILITY); 47 48 48 49 if (!$can_bulk_edit) {
+1 -1
src/applications/project/menuitem/PhabricatorProjectPointsProfileMenuItem.php
··· 27 27 } 28 28 29 29 // Points are only available if Maniphest is installed. 30 - $class = 'PhabricatorManiphestApplication'; 30 + $class = PhabricatorManiphestApplication::class; 31 31 if (!PhabricatorApplication::isClassInstalledForViewer($class, $viewer)) { 32 32 return false; 33 33 }
+2 -2
src/applications/project/menuitem/PhabricatorProjectReportsProfileMenuItem.php
··· 29 29 return false; 30 30 } 31 31 32 - $class = 'PhabricatorManiphestApplication'; 32 + $class = PhabricatorManiphestApplication::class; 33 33 if (!PhabricatorApplication::isClassInstalledForViewer($class, $viewer)) { 34 34 return false; 35 35 } 36 36 37 - $class = 'PhabricatorFactApplication'; 37 + $class = PhabricatorFactApplication::class; 38 38 if (!PhabricatorApplication::isClassInstalledForViewer($class, $viewer)) { 39 39 return false; 40 40 }
+1 -1
src/applications/project/menuitem/PhabricatorProjectWorkboardProfileMenuItem.php
··· 26 26 $viewer = $this->getViewer(); 27 27 28 28 // Workboards are only available if Maniphest is installed. 29 - $class = 'PhabricatorManiphestApplication'; 29 + $class = PhabricatorManiphestApplication::class; 30 30 if (!PhabricatorApplication::isClassInstalledForViewer($class, $viewer)) { 31 31 return false; 32 32 }
+1 -1
src/applications/repository/conduit/RepositoryConduitAPIMethod.php
··· 4 4 5 5 final public function getApplication() { 6 6 return PhabricatorApplication::getByClass( 7 - 'PhabricatorDiffusionApplication'); 7 + PhabricatorDiffusionApplication::class); 8 8 } 9 9 10 10 }
+1 -1
src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemonModule.php
··· 7 7 8 8 public function shouldWakePool(PhutilDaemonPool $pool) { 9 9 $class = $pool->getPoolDaemonClass(); 10 - if ($class != 'PhabricatorRepositoryPullLocalDaemon') { 10 + if ($class != PhabricatorRepositoryPullLocalDaemon::class) { 11 11 return false; 12 12 } 13 13
+1 -1
src/applications/repository/storage/PhabricatorRepositoryIdentity.php
··· 143 143 144 144 public function getPolicy($capability) { 145 145 $app = PhabricatorApplication::getByClass( 146 - 'PhabricatorDiffusionApplication'); 146 + PhabricatorDiffusionApplication::class); 147 147 return $app->getPolicy( 148 148 PhabricatorRepositoryIdentityEditViewCapability::CAPABILITY); 149 149 }
+1 -1
src/applications/search/controller/PhabricatorApplicationSearchController.php
··· 916 916 917 917 $can_use = $engine->canUseInPanelContext(); 918 918 $is_installed = PhabricatorApplication::isClassInstalledForViewer( 919 - 'PhabricatorDashboardApplication', 919 + PhabricatorDashboardApplication::class, 920 920 $viewer); 921 921 922 922 if ($can_use && $is_installed) {
+1 -1
src/applications/search/relationship/DifferentialRevisionRelationshipSource.php
··· 7 7 $viewer = $this->getViewer(); 8 8 9 9 return PhabricatorApplication::isClassInstalledForViewer( 10 - 'PhabricatorDifferentialApplication', 10 + PhabricatorDifferentialApplication::class, 11 11 $viewer); 12 12 } 13 13
+1 -1
src/applications/search/relationship/DiffusionCommitRelationshipSource.php
··· 7 7 $viewer = $this->getViewer(); 8 8 9 9 return PhabricatorApplication::isClassInstalledForViewer( 10 - 'PhabricatorDiffusionApplication', 10 + PhabricatorDiffusionApplication::class, 11 11 $viewer); 12 12 } 13 13
+1 -1
src/applications/search/relationship/ManiphestTaskRelationshipSource.php
··· 7 7 $viewer = $this->getViewer(); 8 8 9 9 return PhabricatorApplication::isClassInstalledForViewer( 10 - 'PhabricatorManiphestApplication', 10 + PhabricatorManiphestApplication::class, 11 11 $viewer); 12 12 } 13 13
+1 -1
src/applications/search/relationship/PholioMockRelationshipSource.php
··· 7 7 $viewer = $this->getViewer(); 8 8 9 9 return PhabricatorApplication::isClassInstalledForViewer( 10 - 'PhabricatorPholioApplication', 10 + PhabricatorPholioApplication::class, 11 11 $viewer); 12 12 } 13 13
+1 -1
src/applications/settings/setting/PhabricatorConpherenceNotificationsSetting.php
··· 23 23 24 24 protected function isEnabledForViewer(PhabricatorUser $viewer) { 25 25 return PhabricatorApplication::isClassInstalledForViewer( 26 - 'PhabricatorConpherenceApplication', 26 + PhabricatorConpherenceApplication::class, 27 27 $viewer); 28 28 } 29 29
+1 -1
src/applications/settings/setting/PhabricatorConpherenceSoundSetting.php
··· 24 24 25 25 protected function isEnabledForViewer(PhabricatorUser $viewer) { 26 26 return PhabricatorApplication::isClassInstalledForViewer( 27 - 'PhabricatorConpherenceApplication', 27 + PhabricatorConpherenceApplication::class, 28 28 $viewer); 29 29 } 30 30
+1 -1
src/applications/slowvote/conduit/SlowvoteConduitAPIMethod.php
··· 4 4 5 5 final public function getApplication() { 6 6 return PhabricatorApplication::getByClass( 7 - 'PhabricatorSlowvoteApplication'); 7 + PhabricatorSlowvoteApplication::class); 8 8 } 9 9 10 10 }
+2 -1
src/applications/tokens/conduit/TokenConduitAPIMethod.php
··· 3 3 abstract class TokenConduitAPIMethod extends ConduitAPIMethod { 4 4 5 5 final public function getApplication() { 6 - return PhabricatorApplication::getByClass('PhabricatorTokensApplication'); 6 + return PhabricatorApplication::getByClass( 7 + PhabricatorTokensApplication::class); 7 8 } 8 9 9 10 public function getMethodStatus() {
+1 -1
src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php
··· 630 630 private function renderBadgeView() { 631 631 $user = $this->getUser(); 632 632 $can_use_badges = PhabricatorApplication::isClassInstalledForViewer( 633 - 'PhabricatorBadgesApplication', 633 + PhabricatorBadgesApplication::class, 634 634 $user); 635 635 if (!$can_use_badges) { 636 636 return null;
+1 -1
src/infrastructure/daemon/workers/PhabricatorTaskmasterDaemonModule.php
··· 6 6 public function shouldWakePool(PhutilDaemonPool $pool) { 7 7 $class = $pool->getPoolDaemonClass(); 8 8 9 - if ($class != 'PhabricatorTaskmasterDaemon') { 9 + if ($class != PhabricatorTaskmasterDaemon::class) { 10 10 return false; 11 11 } 12 12
+1 -1
src/infrastructure/daemon/workers/PhabricatorTriggerDaemon.php
··· 415 415 416 416 417 417 private function updateNuanceImportCursors() { 418 - $nuance_app = 'PhabricatorNuanceApplication'; 418 + $nuance_app = PhabricatorNuanceApplication::class; 419 419 if (!PhabricatorApplication::isClassInstalled($nuance_app)) { 420 420 return false; 421 421 }
+2 -2
src/infrastructure/daemon/workers/query/PhabricatorWorkerTriggerQuery.php
··· 109 109 110 110 foreach ($triggers as $key => $trigger) { 111 111 $clock_class = $trigger->getClockClass(); 112 - if (!is_subclass_of($clock_class, 'PhabricatorTriggerClock')) { 112 + if (!is_subclass_of($clock_class, PhabricatorTriggerClock::class)) { 113 113 unset($triggers[$key]); 114 114 continue; 115 115 } ··· 128 128 129 129 foreach ($triggers as $key => $trigger) { 130 130 $action_class = $trigger->getActionClass(); 131 - if (!is_subclass_of($action_class, 'PhabricatorTriggerAction')) { 131 + if (!is_subclass_of($action_class, PhabricatorTriggerAction::class)) { 132 132 unset($triggers[$key]); 133 133 continue; 134 134 }
+1 -1
src/infrastructure/daemon/workers/storage/PhabricatorWorkerTask.php
··· 76 76 $class)); 77 77 } 78 78 79 - if (!is_subclass_of($class, 'PhabricatorWorker')) { 79 + if (!is_subclass_of($class, PhabricatorWorker::class)) { 80 80 throw new PhabricatorWorkerPermanentFailureException( 81 81 pht( 82 82 "Task class '%s' does not extend %s.",
+3 -1
src/infrastructure/export/engine/PhabricatorExportEngineBulkJobType.php
··· 52 52 PhabricatorWorkerBulkTask $task) { 53 53 54 54 $engine_class = $job->getParameter('engineClass'); 55 - if (!is_subclass_of($engine_class, 'PhabricatorApplicationSearchEngine')) { 55 + if (!is_subclass_of( 56 + $engine_class, 57 + PhabricatorApplicationSearchEngine::class)) { 56 58 throw new Exception( 57 59 pht( 58 60 'Unknown search engine class "%s".',
+1 -1
src/view/form/control/PhabricatorRemarkupControl.php
··· 249 249 250 250 if ($can_use_macros) { 251 251 $can_use_macros = PhabricatorApplication::isClassInstalledForViewer( 252 - 'PhabricatorMacroApplication', 252 + PhabricatorMacroApplication::class, 253 253 $viewer); 254 254 } 255 255
+1 -1
src/view/page/PhabricatorStandardPageView.php
··· 93 93 } 94 94 95 95 $conpherence_installed = PhabricatorApplication::isClassInstalledForViewer( 96 - 'PhabricatorConpherenceApplication', 96 + PhabricatorConpherenceApplication::class, 97 97 $viewer); 98 98 if (!$conpherence_installed) { 99 99 return false;
+2 -2
src/view/page/menu/PhabricatorMainMenuView.php
··· 354 354 355 355 $message_tag = ''; 356 356 $message_notification_dropdown = ''; 357 - $conpherence_app = 'PhabricatorConpherenceApplication'; 357 + $conpherence_app = PhabricatorConpherenceApplication::class; 358 358 $conpherence_data = $dropdown_data[$conpherence_app]; 359 359 if ($conpherence_data['isInstalled']) { 360 360 $message_id = celerity_generate_unique_node_id(); ··· 436 436 437 437 $bubble_tag = ''; 438 438 $notification_dropdown = ''; 439 - $notification_app = 'PhabricatorNotificationsApplication'; 439 + $notification_app = PhabricatorNotificationsApplication::class; 440 440 $notification_data = $dropdown_data[$notification_app]; 441 441 if ($notification_data['isInstalled']) { 442 442 $count_id = celerity_generate_unique_node_id();
+1 -1
src/view/phui/PHUITimelineView.php
··· 241 241 242 242 $viewer = $this->getUser(); 243 243 $can_use_badges = PhabricatorApplication::isClassInstalledForViewer( 244 - 'PhabricatorBadgesApplication', 244 + PhabricatorBadgesApplication::class, 245 245 $viewer); 246 246 if (!$can_use_badges) { 247 247 return;