+1 -1

src/applications/audit/application/PhabricatorApplicationAudit.php

reviewed

··· 37 37 'view/(?P<filter>[^/]+)/(?:(?P<name>[^/]+)/)?' 38 38 => 'PhabricatorAuditListController', 39 39 'addcomment/' => 'PhabricatorAuditAddCommentController', 40 40 - 'preview/(?P<id>\d+)/' => 'PhabricatorAuditPreviewController', 40 40 + 'preview/(?P<id>[1-9]\d*)/' => 'PhabricatorAuditPreviewController', 41 41 ), 42 42 ); 43 43 }

+3 -3

src/applications/countdown/application/PhabricatorApplicationCountdown.php

reviewed

··· 47 47 '/countdown/' => array( 48 48 '' 49 49 => 'PhabricatorCountdownListController', 50 50 - '(?P<id>\d+)/' 50 50 + '(?P<id>[1-9]\d*)/' 51 51 => 'PhabricatorCountdownViewController', 52 52 - 'edit/(?:(?P<id>\d+)/)?' 52 52 + 'edit/(?:(?P<id>[1-9]\d*)/)?' 53 53 => 'PhabricatorCountdownEditController', 54 54 - 'delete/(?P<id>\d+)/' 54 54 + 'delete/(?P<id>[1-9]\d*)/' 55 55 => 'PhabricatorCountdownDeleteController' 56 56 ), 57 57 );

+5 -4

src/applications/daemon/application/PhabricatorApplicationDaemons.php

reviewed

··· 45 45 public function getRoutes() { 46 46 return array( 47 47 '/daemon/' => array( 48 48 - 'task/(?P<id>\d+)/' => 'PhabricatorWorkerTaskDetailController', 49 49 - 'task/(?P<id>\d+)/(?P<action>[^/]+)/' 48 48 + 'task/(?P<id>[1-9]\d*)/' => 'PhabricatorWorkerTaskDetailController', 49 49 + 'task/(?P<id>[1-9]\d*)/(?P<action>[^/]+)/' 50 50 => 'PhabricatorWorkerTaskUpdateController', 51 51 'log/' => array( 52 52 '(?P<running>running/)?' => 'PhabricatorDaemonLogListController', 53 53 'combined/' => 'PhabricatorDaemonCombinedLogController', 54 54 - '(?P<id>\d+)/' => 'PhabricatorDaemonLogViewController', 54 54 + '(?P<id>[1-9]\d*)/' => 'PhabricatorDaemonLogViewController', 55 55 ), 56 56 'timeline/' => 'PhabricatorDaemonTimelineConsoleController', 57 57 - 'timeline/(?P<id>\d+)/' => 'PhabricatorDaemonTimelineEventController', 57 57 + 'timeline/(?P<id>[1-9]\d*)/' 58 58 + => 'PhabricatorDaemonTimelineEventController', 58 59 '' => 'PhabricatorDaemonConsoleController', 59 60 ), 60 61 );

+9 -8

src/applications/differential/application/PhabricatorApplicationDifferential.php

reviewed

··· 38 38 39 39 public function getRoutes() { 40 40 return array( 41 41 - '/D(?P<id>\d+)' => 'DifferentialRevisionViewController', 41 41 + '/D(?P<id>[1-9]\d*)' => 'DifferentialRevisionViewController', 42 42 '/differential/' => array( 43 43 '' => 'DifferentialRevisionListController', 44 44 'filter/(?P<filter>\w+)/(?:(?P<username>[\w\.-_]+)/)?' => 45 45 'DifferentialRevisionListController', 46 46 'stats/(?P<filter>\w+)/' => 'DifferentialRevisionStatsController', 47 47 'diff/' => array( 48 48 - '(?P<id>\d+)/' => 'DifferentialDiffViewController', 48 48 + '(?P<id>[1-9]\d*)/' => 'DifferentialDiffViewController', 49 49 'create/' => 'DifferentialDiffCreateController', 50 50 ), 51 51 'changeset/' => 'DifferentialChangesetViewController', 52 52 - 'revision/edit/(?:(?P<id>\d+)/)?' 52 52 + 'revision/edit/(?:(?P<id>[1-9]\d*)/)?' 53 53 => 'DifferentialRevisionEditController', 54 54 'comment/' => array( 55 55 - 'preview/(?P<id>\d+)/' => 'DifferentialCommentPreviewController', 55 55 + 'preview/(?P<id>[1-9]\d*)/' => 'DifferentialCommentPreviewController', 56 56 'save/' => 'DifferentialCommentSaveController', 57 57 'inline/' => array( 58 58 - 'preview/(?P<id>\d+)/' => 59 59 - 'DifferentialInlineCommentPreviewController', 60 60 - 'edit/(?P<id>\d+)/' => 'DifferentialInlineCommentEditController', 58 58 + 'preview/(?P<id>[1-9]\d*)/' 59 59 + => 'DifferentialInlineCommentPreviewController', 60 60 + 'edit/(?P<id>[1-9]\d*)/' 61 61 + => 'DifferentialInlineCommentEditController', 61 62 ), 62 63 ), 63 63 - 'subscribe/(?P<action>add|rem)/(?P<id>\d+)/' 64 64 + 'subscribe/(?P<action>add|rem)/(?P<id>[1-9]\d*)/' 64 65 => 'DifferentialSubscribeController', 65 66 ), 66 67 );

+2 -2

src/applications/files/application/PhabricatorApplicationFiles.php

reviewed

··· 44 44 45 45 public function getRoutes() { 46 46 return array( 47 47 - '/F(?P<id>\d+)' => 'PhabricatorFileShortcutController', 47 47 + '/F(?P<id>[1-9]\d*)' => 'PhabricatorFileShortcutController', 48 48 '/file/' => array( 49 49 '' => 'PhabricatorFileListController', 50 50 'filter/(?P<filter>\w+)/' => 'PhabricatorFileListController', 51 51 'upload/' => 'PhabricatorFileUploadController', 52 52 'dropupload/' => 'PhabricatorFileDropUploadController', 53 53 - 'delete/(?P<id>\d+)/' => 'PhabricatorFileDeleteController', 53 53 + 'delete/(?P<id>[1-9]\d*)/' => 'PhabricatorFileDeleteController', 54 54 'info/(?P<phid>[^/]+)/' => 'PhabricatorFileInfoController', 55 55 'data/(?P<key>[^/]+)/(?P<phid>[^/]+)/.*' 56 56 => 'PhabricatorFileDataController',

+1 -1

src/applications/flag/application/PhabricatorApplicationFlags.php

reviewed

··· 65 65 '' => 'PhabricatorFlagListController', 66 66 'view/(?P<view>[^/]+)/' => 'PhabricatorFlagListController', 67 67 'edit/(?P<phid>[^/]+)/' => 'PhabricatorFlagEditController', 68 68 - 'delete/(?P<id>\d+)/' => 'PhabricatorFlagDeleteController', 68 68 + 'delete/(?P<id>[1-9]\d*)/' => 'PhabricatorFlagDeleteController', 69 69 ), 70 70 ); 71 71 }

+4 -4

src/applications/herald/application/PhabricatorApplicationHerald.php

reviewed

··· 54 54 => 'HeraldHomeController', 55 55 'new/(?:(?P<type>[^/]+)/(?:(?P<rule_type>[^/]+)/)?)?' 56 56 => 'HeraldNewController', 57 57 - 'rule/(?:(?P<id>\d+)/)?' => 'HeraldRuleController', 58 58 - 'history/(?:(?P<id>\d+)/)?' => 'HeraldRuleEditHistoryController', 59 59 - 'delete/(?P<id>\d+)/' => 'HeraldDeleteController', 57 57 + 'rule/(?:(?P<id>[1-9]\d*)/)?' => 'HeraldRuleController', 58 58 + 'history/(?:(?P<id>[1-9]\d*)/)?' => 'HeraldRuleEditHistoryController', 59 59 + 'delete/(?P<id>[1-9]\d*)/' => 'HeraldDeleteController', 60 60 'test/' => 'HeraldTestConsoleController', 61 61 'transcript/' => 'HeraldTranscriptListController', 62 62 - 'transcript/(?P<id>\d+)/(?:(?P<filter>\w+)/)?' 62 62 + 'transcript/(?P<id>[1-9]\d*)/(?:(?P<filter>\w+)/)?' 63 63 => 'HeraldTranscriptController', 64 64 ), 65 65 );

+2 -2

src/applications/macro/application/PhabricatorApplicationMacro.php

reviewed

··· 42 42 return array( 43 43 '/macro/' => array( 44 44 '' => 'PhabricatorMacroListController', 45 45 - 'edit/(?:(?P<id>\d+)/)?' => 'PhabricatorMacroEditController', 46 46 - 'delete/(?P<id>\d+)/' => 'PhabricatorMacroDeleteController', 45 45 + 'edit/(?:(?P<id>[1-9]\d*)/)?' => 'PhabricatorMacroEditController', 46 46 + 'delete/(?P<id>[1-9]\d*)/' => 'PhabricatorMacroDeleteController', 47 47 ), 48 48 ); 49 49 }

+2 -1

src/applications/mailinglists/application/PhabricatorApplicationMailingLists.php

reviewed

··· 42 42 return array( 43 43 '/mailinglists/' => array( 44 44 '' => 'PhabricatorMailingListsListController', 45 45 - 'edit/(?:(?P<id>\d+)/)?' => 'PhabricatorMailingListsEditController', 45 45 + 'edit/(?:(?P<id>[1-9]\d*)/)?' 46 46 + => 'PhabricatorMailingListsEditController', 46 47 ), 47 48 ); 48 49 }

+7 -6

src/applications/maniphest/application/PhabricatorApplicationManiphest.php

reviewed

··· 50 50 51 51 public function getRoutes() { 52 52 return array( 53 53 - '/T(?P<id>\d+)' => 'ManiphestTaskDetailController', 53 53 + '/T(?P<id>[1-9]\d*)' => 'ManiphestTaskDetailController', 54 54 '/maniphest/' => array( 55 55 '' => 'ManiphestTaskListController', 56 56 'view/(?P<view>\w+)/' => 'ManiphestTaskListController', ··· 58 58 'batch/' => 'ManiphestBatchEditController', 59 59 'task/' => array( 60 60 'create/' => 'ManiphestTaskEditController', 61 61 - 'edit/(?P<id>\d+)/' => 'ManiphestTaskEditController', 62 62 - 'descriptionchange/(?:(?P<id>\d+)/)?' => 61 61 + 'edit/(?P<id>[1-9]\d*)/' => 'ManiphestTaskEditController', 62 62 + 'descriptionchange/(?:(?P<id>[1-9]\d*)/)?' => 63 63 'ManiphestTaskDescriptionChangeController', 64 64 'descriptionpreview/' => 65 65 'ManiphestTaskDescriptionPreviewController', 66 66 ), 67 67 'transaction/' => array( 68 68 'save/' => 'ManiphestTransactionSaveController', 69 69 - 'preview/(?P<id>\d+)/' => 'ManiphestTransactionPreviewController', 69 69 + 'preview/(?P<id>[1-9]\d*)/' 70 70 + => 'ManiphestTransactionPreviewController', 70 71 ), 71 72 'export/(?P<key>[^/]+)/' => 'ManiphestExportController', 72 73 'subpriority/' => 'ManiphestSubpriorityController', 73 74 'custom/' => array( 74 75 '' => 'ManiphestSavedQueryListController', 75 75 - 'edit/(?:(?P<id>\d+)/)?' => 'ManiphestSavedQueryEditController', 76 76 - 'delete/(?P<id>\d+)/' => 'ManiphestSavedQueryDeleteController', 76 76 + 'edit/(?:(?P<id>[1-9]\d*)/)?' => 'ManiphestSavedQueryEditController', 77 77 + 'delete/(?P<id>[1-9]\d*)/' => 'ManiphestSavedQueryDeleteController', 77 78 ), 78 79 ), 79 80 );

+1 -1

src/applications/metamta/application/PhabricatorApplicationMetaMTA.php

reviewed

··· 43 43 $this->getBaseURI() => array( 44 44 '' => 'PhabricatorMetaMTAListController', 45 45 'send/' => 'PhabricatorMetaMTASendController', 46 46 - 'view/(?P<id>\d+)/' => 'PhabricatorMetaMTAViewController', 46 46 + 'view/(?P<id>[1-9]\d*)/' => 'PhabricatorMetaMTAViewController', 47 47 'receive/' => 'PhabricatorMetaMTAReceiveController', 48 48 'received/' => 'PhabricatorMetaMTAReceivedListController', 49 49 'sendgrid/' => 'PhabricatorMetaMTASendGridReceiveController',

+3 -3

src/applications/owners/application/PhabricatorApplicationOwners.php

reviewed

··· 51 51 '/owners/' => array( 52 52 '' => 'PhabricatorOwnersListController', 53 53 'view/(?P<view>[^/]+)/' => 'PhabricatorOwnersListController', 54 54 - 'edit/(?P<id>\d+)/' => 'PhabricatorOwnersEditController', 54 54 + 'edit/(?P<id>[1-9]\d*)/' => 'PhabricatorOwnersEditController', 55 55 'new/' => 'PhabricatorOwnersEditController', 56 56 - 'package/(?P<id>\d+)/' => 'PhabricatorOwnersDetailController', 57 57 - 'delete/(?P<id>\d+)/' => 'PhabricatorOwnersDeleteController', 56 56 + 'package/(?P<id>[1-9]\d*)/' => 'PhabricatorOwnersDetailController', 57 57 + 'delete/(?P<id>[1-9]\d*)/' => 'PhabricatorOwnersDeleteController', 58 58 ), 59 59 ); 60 60 }

+2 -2

src/applications/paste/application/PhabricatorApplicationPaste.php

reviewed

··· 36 36 37 37 public function getRoutes() { 38 38 return array( 39 39 - '/P(?P<id>\d+)' => 'PhabricatorPasteViewController', 39 39 + '/P(?P<id>[1-9]\d*)' => 'PhabricatorPasteViewController', 40 40 '/paste/' => array( 41 41 '' => 'PhabricatorPasteEditController', 42 42 - 'edit/(?P<id>\d+)/' => 'PhabricatorPasteEditController', 42 42 + 'edit/(?P<id>[1-9]\d*)/' => 'PhabricatorPasteEditController', 43 43 'filter/(?P<filter>\w+)/' => 'PhabricatorPasteListController', 44 44 ), 45 45 );

+1 -1

src/applications/people/application/PhabricatorApplicationPeople.php

reviewed

··· 47 47 '/people/' => array( 48 48 '' => 'PhabricatorPeopleListController', 49 49 'logs/' => 'PhabricatorPeopleLogsController', 50 50 - 'edit/(?:(?P<id>\d+)/(?:(?P<view>\w+)/)?)?' 50 50 + 'edit/(?:(?P<id>[1-9]\d*)/(?:(?P<view>\w+)/)?)?' 51 51 => 'PhabricatorPeopleEditController', 52 52 'ldap/' => 'PhabricatorPeopleLdapController', 53 53 ),

+3 -3

src/applications/phriction/application/PhabricatorApplicationPhriction.php

reviewed

··· 48 48 'history(?P<slug>/)' => 'PhrictionHistoryController', 49 49 'history/(?P<slug>.+/)' => 'PhrictionHistoryController', 50 50 51 51 - 'edit/(?:(?P<id>\d+)/)?' => 'PhrictionEditController', 52 52 - 'delete/(?P<id>\d+)/' => 'PhrictionDeleteController', 51 51 + 'edit/(?:(?P<id>[1-9]\d*)/)?' => 'PhrictionEditController', 52 52 + 'delete/(?P<id>[1-9]\d*)/' => 'PhrictionDeleteController', 53 53 54 54 'preview/' => 'PhrictionDocumentPreviewController', 55 55 - 'diff/(?P<id>\d+)/' => 'PhrictionDiffController', 55 55 + 'diff/(?P<id>[1-9]\d*)/' => 'PhrictionDiffController', 56 56 ), 57 57 ); 58 58 }

+1 -1

src/applications/ponder/application/PhabricatorApplicationPonder.php

reviewed

··· 49 49 50 50 public function getroutes() { 51 51 return array( 52 52 - '/Q(?P<id>\d+)' => 'PonderQuestionViewController', 52 52 + '/Q(?P<id>[1-9]\d*)' => 'PonderQuestionViewController', 53 53 '/ponder/' => array( 54 54 '(?P<page>feed/)?' => 'PonderFeedController', 55 55 '(?P<page>questions)/' => 'PonderFeedController',

+5 -4

src/applications/project/application/PhabricatorApplicationProject.php

reviewed

··· 47 47 '/project/' => array( 48 48 '' => 'PhabricatorProjectListController', 49 49 'filter/(?P<filter>[^/]+)/' => 'PhabricatorProjectListController', 50 50 - 'edit/(?P<id>\d+)/' => 'PhabricatorProjectProfileEditController', 51 51 - 'members/(?P<id>\d+)/' => 'PhabricatorProjectMembersEditController', 52 52 - 'view/(?P<id>\d+)/(?:(?P<page>\w+)/)?' 50 50 + 'edit/(?P<id>[1-9]\d*)/' => 'PhabricatorProjectProfileEditController', 51 51 + 'members/(?P<id>[1-9]\d*)/' 52 52 + => 'PhabricatorProjectMembersEditController', 53 53 + 'view/(?P<id>[1-9]\d*)/(?:(?P<page>\w+)/)?' 53 54 => 'PhabricatorProjectProfileController', 54 55 'create/' => 'PhabricatorProjectCreateController', 55 55 - 'update/(?P<id>\d+)/(?P<action>[^/]+)/' 56 56 + 'update/(?P<id>[1-9]\d*)/(?P<action>[^/]+)/' 56 57 => 'PhabricatorProjectUpdateController', 57 58 ), 58 59 );

+4 -4

src/applications/repository/application/PhabricatorApplicationRepositories.php

reviewed

··· 43 43 '/repository/' => array( 44 44 '' => 'PhabricatorRepositoryListController', 45 45 'create/' => 'PhabricatorRepositoryCreateController', 46 46 - 'edit/(?P<id>\d+)/(?:(?P<view>\w+)/)?' => 46 46 + 'edit/(?P<id>[1-9]\d*)/(?:(?P<view>\w+)/)?' => 47 47 'PhabricatorRepositoryEditController', 48 48 - 'delete/(?P<id>\d+)/' => 'PhabricatorRepositoryDeleteController', 49 49 - 'project/edit/(?P<id>\d+)/' => 48 48 + 'delete/(?P<id>[1-9]\d*)/' => 'PhabricatorRepositoryDeleteController', 49 49 + 'project/edit/(?P<id>[1-9]\d*)/' => 50 50 'PhabricatorRepositoryArcanistProjectEditController', 51 51 - 'project/delete/(?P<id>\d+)/' => 51 51 + 'project/delete/(?P<id>[1-9]\d*)/' => 52 52 'PhabricatorRepositoryArcanistProjectDeleteController', 53 53 ), 54 54 );

+1 -1

src/applications/slowvote/application/PhabricatorApplicationSlowvote.php

reviewed

··· 48 48 49 49 public function getRoutes() { 50 50 return array( 51 51 - '/V(?P<id>\d+)' => 'PhabricatorSlowvotePollController', 51 51 + '/V(?P<id>[1-9]\d*)' => 'PhabricatorSlowvotePollController', 52 52 '/vote/' => array( 53 53 '(?:view/(?P<view>\w+)/)?' => 'PhabricatorSlowvoteListController', 54 54 'create/' => 'PhabricatorSlowvoteCreateController',

+5 -5

src/applications/xhpastview/application/PhabricatorApplicationPHPAST.php

reviewed

··· 42 42 return array( 43 43 '/xhpast/' => array( 44 44 '' => 'PhabricatorXHPASTViewRunController', 45 45 - 'view/(?P<id>\d+)/' 45 45 + 'view/(?P<id>[1-9]\d*)/' 46 46 => 'PhabricatorXHPASTViewFrameController', 47 47 - 'frameset/(?P<id>\d+)/' 47 47 + 'frameset/(?P<id>[1-9]\d*)/' 48 48 => 'PhabricatorXHPASTViewFramesetController', 49 49 - 'input/(?P<id>\d+)/' 49 49 + 'input/(?P<id>[1-9]\d*)/' 50 50 => 'PhabricatorXHPASTViewInputController', 51 51 - 'tree/(?P<id>\d+)/' 51 51 + 'tree/(?P<id>[1-9]\d*)/' 52 52 => 'PhabricatorXHPASTViewTreeController', 53 53 - 'stream/(?P<id>\d+)/' 53 53 + 'stream/(?P<id>[1-9]\d*)/' 54 54 => 'PhabricatorXHPASTViewStreamController', 55 55 ), 56 56 );