@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix Ponder feed story transaction
Summary: These transactions were missed, add in all closed states.
Test Plan: Closed a Question, see title in Feed.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Differential Revision: https://secure.phabricator.com/D13831
+13
-3
+13
-3
src/applications/ponder/storage/PonderQuestionTransaction.php
+13
-3
src/applications/ponder/storage/PonderQuestionTransaction.php
···
237
237
switch ($new) {
238
238
case PonderQuestionStatus::STATUS_OPEN:
239
239
return pht(
240
-
'%s reopened %s',
240
+
'%s reopened %s.',
241
241
$this->renderHandleLink($author_phid),
242
242
$this->renderHandleLink($object_phid));
243
-
case PonderQuestionStatus::STATUS_CLOSED:
243
+
case PonderQuestionStatus::STATUS_CLOSED_RESOLVED:
244
244
return pht(
245
-
'%s closed %s',
245
+
'%s closed %s as resolved.',
246
+
$this->renderHandleLink($author_phid),
247
+
$this->renderHandleLink($object_phid));
248
+
case PonderQuestionStatus::STATUS_CLOSED_DUPLICATE:
249
+
return pht(
250
+
'%s closed %s as duplicate.',
251
+
$this->renderHandleLink($author_phid),
252
+
$this->renderHandleLink($object_phid));
253
+
case PonderQuestionStatus::STATUS_CLOSED_OBSOLETE:
254
+
return pht(
255
+
'%s closed %s as obsolete.',
246
256
$this->renderHandleLink($author_phid),
247
257
$this->renderHandleLink($object_phid));
248
258
}