recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

PHP 8.5: Fix null array key creating a Nuance Source

Summary:
Setting null as an array key is deprecated since PHP 8.5 per https://www.php.net/releases/8.5/en.php: "Using null as an array offset or when calling array_key_exists() is now deprecated. Use an empty string instead."

```
ERROR 8192: Using null as an array offset is deprecated, use an empty string instead at [/var/www/html/phorge/phorge/src/applications/nuance/controller/NuanceSourceEditController.php:18]
```

Closes T16531

Test Plan:
* PHP 8.5
* `./bin/config set phabricator.show-prototypes true`
* Go to http://phorge.localhost/nuance/source/edit/form/default/

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T16531

Differential Revision: https://we.phorge.it/D26806

Andre Klapper 2309ee42 3f99d9f5

+1 -1
+1 -1
src/applications/nuance/controller/NuanceSourceEditController.php
··· 15 15 $cancel_uri = $this->getApplicationURI('source/'); 16 16 $map = NuanceSourceDefinition::getAllDefinitions(); 17 17 $source_type = $request->getStr('sourceType'); 18 - if (!isset($map[$source_type])) { 18 + if (!$source_type || !isset($map[$source_type])) { 19 19 return $this->buildSourceTypeResponse($cancel_uri); 20 20 } 21 21