@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Respect linebreaks in full HTML tables in Remarkup
Summary:
Fixes T5427. See PHI1630. See also T13160 and D20568.
In the full HTML table syntax with "<table>", respect linebreaks as literals inside "<td>" cells.
Test Plan: Previewed some full-HTML tables with and without linebreaks, saw what seemed like sensible rendering behavior.
Maniphest Tasks: T5427
Differential Revision: https://secure.phabricator.com/D20971
+12
-1
+12
-1
src/infrastructure/markup/blockrule/PhutilRemarkupTableBlockRule.php
+12
-1
src/infrastructure/markup/blockrule/PhutilRemarkupTableBlockRule.php
···
121
121
return $table->newRawString();
122
122
}
123
123
124
+
// Respect newlines in table cells as literal linebreaks.
125
+
124
126
$content = $cell->newRawContentString();
125
-
$content = $this->applyRules($content);
127
+
$content = trim($content, "\r\n");
128
+
129
+
$lines = phutil_split_lines($content, $retain_endings = false);
130
+
foreach ($lines as $key => $line) {
131
+
$lines[$key] = $this->applyRules($line);
132
+
}
133
+
134
+
$content = phutil_implode_html(
135
+
phutil_tag('br'),
136
+
$lines);
126
137
127
138
$cell_specs[] = array(
128
139
'type' => $cell->getTagName(),