@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Update .arclint in Phabricator for phutil-library lint
Summary:
Also fix a few other minor issues:
- Use lint config.
- Fix a method signature from `arc unit --everything` (unrelated).
- Add a javelin doc.
Test Plan: Ran `arc lint`, `arc unit`, `arc linters`.
Reviewers: btrahan, joshuaspence
Reviewed By: joshuaspence
Subscribers: epriestley
Differential Revision: https://secure.phabricator.com/D9072
+34
-9
+1
-3
.arcconfig
+1
-3
.arcconfig
···
2
2
"project.name" : "phabricator",
3
3
"phabricator.uri" : "https://secure.phabricator.com/",
4
4
"unit.engine" : "PhutilUnitTestEngine",
5
-
"load" : ["src/"],
6
-
"lint.xhpast.naminghook" : "PhabricatorSymbolNameLinter",
7
-
"lint.jshint.config" : "support/jshint/jshintconfig"
5
+
"load" : ["src/"]
8
6
}
+21
-3
.arclint
+21
-3
.arclint
···
22
22
"exclude": [
23
23
"(^externals/JsShrink/)",
24
24
"(^webroot/rsrc/externals/raphael/)"
25
-
]
25
+
],
26
+
"flags": ["--config=support/jshint/jshintconfig"]
26
27
},
27
28
"generated": {
28
29
"type": "generated"
···
40
41
"phutil_escape_html": "The phutil_escape_html() function is deprecated. Raw strings passed to phutil_tag() or hsprintf() are escaped automatically."
41
42
}
42
43
},
44
+
"phutil-library": {
45
+
"type": "phutil-library",
46
+
"include": "(\\.php$)"
47
+
},
43
48
"text": {
44
-
"type": "text"
49
+
"type": "text",
50
+
"exclude": [
51
+
"(^\\.arclint)"
52
+
]
53
+
},
54
+
"text-without-length": {
55
+
"type": "text",
56
+
"severity": {
57
+
"3": "disabled"
58
+
},
59
+
"include": [
60
+
"(^\\.arclint)"
61
+
]
45
62
},
46
63
"spelling": {
47
64
"type": "spelling"
···
55
72
"31": "error",
56
73
"34": "error",
57
74
"35": "error"
58
-
}
75
+
},
76
+
"xhpast.naminghook": "PhabricatorSymbolNameLinter"
59
77
}
60
78
}
61
79
}
-2
src/__phutil_library_map__.php
-2
src/__phutil_library_map__.php
···
1648
1648
'PhabricatorKeyValueDatabaseCache' => 'applications/cache/PhabricatorKeyValueDatabaseCache.php',
1649
1649
'PhabricatorLegalpadConfigOptions' => 'applications/legalpad/config/PhabricatorLegalpadConfigOptions.php',
1650
1650
'PhabricatorLegalpadPHIDTypeDocument' => 'applications/legalpad/phid/PhabricatorLegalpadPHIDTypeDocument.php',
1651
-
'PhabricatorLintEngine' => 'infrastructure/lint/PhabricatorLintEngine.php',
1652
1651
'PhabricatorLipsumArtist' => 'applications/lipsum/image/PhabricatorLipsumArtist.php',
1653
1652
'PhabricatorLipsumGenerateWorkflow' => 'applications/lipsum/management/PhabricatorLipsumGenerateWorkflow.php',
1654
1653
'PhabricatorLipsumManagementWorkflow' => 'applications/lipsum/management/PhabricatorLipsumManagementWorkflow.php',
···
4441
4440
'PhabricatorKeyValueDatabaseCache' => 'PhutilKeyValueCache',
4442
4441
'PhabricatorLegalpadConfigOptions' => 'PhabricatorApplicationConfigOptions',
4443
4442
'PhabricatorLegalpadPHIDTypeDocument' => 'PhabricatorPHIDType',
4444
-
'PhabricatorLintEngine' => 'PhutilLintEngine',
4445
4443
'PhabricatorLipsumGenerateWorkflow' => 'PhabricatorLipsumManagementWorkflow',
4446
4444
'PhabricatorLipsumManagementWorkflow' => 'PhabricatorManagementWorkflow',
4447
4445
'PhabricatorLipsumMondrianArtist' => 'PhabricatorLipsumArtist',
+11
src/infrastructure/lint/linter/PhabricatorJavelinLinter.php
+11
src/infrastructure/lint/linter/PhabricatorJavelinLinter.php
···
13
13
const LINT_UNKNOWN_DEPENDENCY = 4;
14
14
const LINT_MISSING_BINARY = 5;
15
15
16
+
public function getInfoName() {
17
+
return 'Javelin Linter';
18
+
}
19
+
20
+
public function getInfoDescription() {
21
+
return pht(
22
+
'This linter is intended for use with the Javelin JS library and '.
23
+
'extensions. Use `javelinsymbols` to run Javelin rules on Javascript '.
24
+
'source files.');
25
+
}
26
+
16
27
private function getBinaryPath() {
17
28
if ($this->symbolsBinary === null) {
18
29
list($err, $stdout) = exec_manual('which javelinsymbols');
+1
-1
src/infrastructure/sms/worker/PhabricatorSMSSendWorker.php
+1
-1
src/infrastructure/sms/worker/PhabricatorSMSSendWorker.php