@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Conpherence - Fix missing method from D12336; bad branch management. =/
Summary: Ref T7795.
Test Plan: updating a conpherence works once more
Reviewers: epriestley
Subscribers: Korvin, epriestley
Maniphest Tasks: T7795
Differential Revision: https://secure.phabricator.com/D12345
+7
-1
+7
-1
src/applications/conpherence/query/ConpherenceThreadQuery.php
+7
-1
src/applications/conpherence/query/ConpherenceThreadQuery.php
···
9
9
private $ids;
10
10
private $participantPHIDs;
11
11
private $isRoom;
12
+
private $needParticipants;
12
13
private $needWidgetData;
13
14
private $needTransactions;
14
15
private $needParticipantCache;
···
24
25
25
26
public function needParticipantCache($participant_cache) {
26
27
$this->needParticipantCache = $participant_cache;
28
+
return $this;
29
+
}
30
+
31
+
public function needParticipants($need) {
32
+
$this->needParticipants = $need;
27
33
return $this;
28
34
}
29
35
···
98
104
if ($this->needParticipantCache) {
99
105
$this->loadCoreHandles($conpherences, 'getRecentParticipantPHIDs');
100
106
}
101
-
if ($this->needWidgetData) {
107
+
if ($this->needWidgetData || $this->needParticipants) {
102
108
$this->loadCoreHandles($conpherences, 'getParticipantPHIDs');
103
109
}
104
110
if ($this->needTransactions) {