recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Clean up final `setQueryParams()` callsites

Summary: Ref T13250. See D20149.

Test Plan: All trivial?

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13250

Differential Revision: https://secure.phabricator.com/D20153

epriestley 241f06c9 4c124201

+7 -4
+4 -1
src/aphront/AphrontRequest.php
··· 829 829 } 830 830 831 831 $uri->setPath($this->getPath()); 832 - $uri->setQueryParams(self::flattenData($_GET)); 832 + $uri->removeAllQueryParams(); 833 + foreach (self::flattenData($_GET) as $query_key => $query_value) { 834 + $uri->appendQueryParam($query_key, $query_value); 835 + } 833 836 834 837 $input = PhabricatorStartup::getRawInput(); 835 838
+1 -1
src/aphront/response/AphrontResponse.php
··· 218 218 $uri = id(new PhutilURI($uri)) 219 219 ->setPath(null) 220 220 ->setFragment(null) 221 - ->setQueryParams(array()); 221 + ->removeAllQueryParams(); 222 222 223 223 $uri = (string)$uri; 224 224 if (preg_match('/[ ;\']/', $uri)) {
+1 -1
src/applications/auth/provider/PhabricatorAuthProvider.php
··· 447 447 $uri = $attributes['uri']; 448 448 $uri = new PhutilURI($uri); 449 449 $params = $uri->getQueryParamsAsPairList(); 450 - $uri->setQueryParams(array()); 450 + $uri->removeAllQueryParams(); 451 451 452 452 $content = array($button); 453 453
+1 -1
src/applications/files/controller/PhabricatorFileDataController.php
··· 135 135 $request_uri = id(clone $request->getAbsoluteRequestURI()) 136 136 ->setPath(null) 137 137 ->setFragment(null) 138 - ->setQueryParams(array()); 138 + ->removeAllQueryParams(); 139 139 140 140 $response->addContentSecurityPolicyURI( 141 141 'object-src',