@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Burndown the Burnup Rate (and vice versa)

Summary:
Those two things are in the same one chart. Thus use consistent naming.

Closes T16176

Test Plan:
* Go to http://phorge.localhost/maniphest/report/burn/ and look at the sidebar and the title of the chart
* Enable the "Facts" application at http://phorge.localhost/applications/view/PhabricatorFactApplication/, go to http://phorge.localhost/project/reports/1/, and look at the title of the chart

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T16176

Differential Revision: https://we.phorge.it/D26202

+8 -7
+6 -6
src/applications/maniphest/controller/ManiphestReportController.php
··· 38 38 39 39 $class = PhabricatorFactApplication::class; 40 40 if (PhabricatorApplication::isClassInstalledForViewer($class, $viewer)) { 41 - $nav->addLabel(pht('Burnup')); 42 - $nav->addFilter('burn', pht('Burnup Rate')); 41 + $nav->addLabel(pht('Burnup / Burndown')); 42 + $nav->addFilter('burn', pht('Burnup / Burndown Rate')); 43 43 } 44 44 45 45 $this->view = $nav->selectFilter($this->view, 'user'); ··· 72 72 } 73 73 74 74 /** 75 - * Render the "Burnup Rate" on /maniphest/report/burn/. 75 + * Render the 'Burnup / Burndown Rate' on /maniphest/report/burn/. 76 76 * 77 - * Ironically this is not called for the "Burndown" on /project/reports/$id/ 78 - * as that's handled by PhabricatorProjectReportsController instead. 77 + * The same thing on /project/reports/$id/ is handled by 78 + * PhabricatorProjectReportsController instead. 79 79 * 80 80 * @return array<AphrontListFilterView, PHUIObjectBoxView> 81 81 */ ··· 113 113 ->setProjects($projects) 114 114 ->buildChartPanel(); 115 115 116 - $panel->setName(pht('Burnup Rate')); 116 + $panel->setName(pht('Burnup / Burndown Rate')); 117 117 118 118 $chart_view = id(new PhabricatorDashboardPanelRenderingEngine()) 119 119 ->setViewer($viewer)
+2 -1
src/applications/project/controller/PhabricatorProjectReportsController.php
··· 36 36 ->setProjects(array($project)) 37 37 ->buildChartPanel(); 38 38 39 - $chart_panel->setName(pht('%s: Burndown', $project->getName())); 39 + $chart_panel->setName(pht('%s: Burnup / Burndown Rate', 40 + $project->getName())); 40 41 41 42 $chart_view = id(new PhabricatorDashboardPanelRenderingEngine()) 42 43 ->setViewer($viewer)