@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Remove unused shouldUse* functions from PhabricatorRepository
Summary:
Calls to private functions `PhabricatorRepository::shouldUseSSH()` and `PhabricatorRepository::shouldUseHTTP()` were removed in https://we.phorge.it/rP29d1115037b84454c4fd186c47f33f162cc337b9.
Call to private function `PhabricatorRepository::shouldUseSVNProtocol()` was removed in https://we.phorge.it/rP575c01373ee77c12b06696b34cfdf43a2eb26c42.
Test Plan: Grep the code; run static code analysis.
Reviewers: O1 Blessed Committers, valerio.bozzolan
Reviewed By: O1 Blessed Committers, valerio.bozzolan
Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Differential Revision: https://we.phorge.it/D25786
-56
-56
src/applications/repository/storage/PhabricatorRepository.php
-56
src/applications/repository/storage/PhabricatorRepository.php
···
1229
1229
return $uri;
1230
1230
}
1231
1231
1232
-
1233
-
/**
1234
-
* Determine if we should connect to the remote using SSH flags and
1235
-
* credentials.
1236
-
*
1237
-
* @return bool True to use the SSH protocol.
1238
-
* @task uri
1239
-
*/
1240
-
private function shouldUseSSH() {
1241
-
if ($this->isHosted()) {
1242
-
return false;
1243
-
}
1244
-
1245
-
$protocol = $this->getRemoteProtocol();
1246
-
if ($this->isSSHProtocol($protocol)) {
1247
-
return true;
1248
-
}
1249
-
1250
-
return false;
1251
-
}
1252
-
1253
-
1254
-
/**
1255
-
* Determine if we should connect to the remote using HTTP flags and
1256
-
* credentials.
1257
-
*
1258
-
* @return bool True to use the HTTP protocol.
1259
-
* @task uri
1260
-
*/
1261
-
private function shouldUseHTTP() {
1262
-
if ($this->isHosted()) {
1263
-
return false;
1264
-
}
1265
-
1266
-
$protocol = $this->getRemoteProtocol();
1267
-
return ($protocol == 'http' || $protocol == 'https');
1268
-
}
1269
-
1270
-
1271
-
/**
1272
-
* Determine if we should connect to the remote using SVN flags and
1273
-
* credentials.
1274
-
*
1275
-
* @return bool True to use the SVN protocol.
1276
-
* @task uri
1277
-
*/
1278
-
private function shouldUseSVNProtocol() {
1279
-
if ($this->isHosted()) {
1280
-
return false;
1281
-
}
1282
-
1283
-
$protocol = $this->getRemoteProtocol();
1284
-
return ($protocol == 'svn');
1285
-
}
1286
-
1287
-
1288
1232
/**
1289
1233
* Determine if a protocol is SSH or SSH-like.
1290
1234
*