recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix tokenizer placeholder issue

Summary:
The placeholder property remains null despite it is set to a custom
value.

Test Plan:
Use a custom placeholder in `AphrontFormTokenizerControl`

```
id(new AphrontFormTokenizerControl())
->setPlaceholder('My custom placeholder...')
->setDatasource('/typeahead/common/projects/');
```

The placeholder should be set to "My custom placeholder..."

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D4297

authored by

Mailson Menezes and committed by
epriestley 250fe7fb dbae9452

+2 -3
+2 -3
src/view/form/control/AphrontFormTokenizerControl.php
··· 41 41 $id = celerity_generate_unique_node_id(); 42 42 } 43 43 44 - $placeholder = null; 45 44 if (!$this->placeholder) { 46 - $placeholder = $this->getDefaultPlaceholder(); 45 + $this->placeholder = $this->getDefaultPlaceholder(); 47 46 } 48 47 49 48 $template = new AphrontTokenizerTemplateView(); ··· 64 63 'limit' => $this->limit, 65 64 'ondemand' => PhabricatorEnv::getEnvConfig('tokenizer.ondemand'), 66 65 'username' => $username, 67 - 'placeholder' => $placeholder, 66 + 'placeholder' => $this->placeholder, 68 67 )); 69 68 } 70 69