@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Translate change type header

Summary: This is a tax for internationalization.

Test Plan: Displayed a revision with added and moved files.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D3166

vrana 251438b2 b4544ebe

+204 -44
+204 -44
src/applications/differential/parser/DifferentialChangesetParser.php
··· 1722 1722 } 1723 1723 1724 1724 protected function renderChangeTypeHeader($changeset, $force) { 1725 - 1726 - static $articles = array( 1727 - DifferentialChangeType::FILE_IMAGE => 'an', 1728 - ); 1729 - 1730 - static $files = array( 1731 - DifferentialChangeType::FILE_TEXT => 'file', 1732 - DifferentialChangeType::FILE_IMAGE => 'image', 1733 - DifferentialChangeType::FILE_DIRECTORY => 'directory', 1734 - DifferentialChangeType::FILE_BINARY => 'binary file', 1735 - DifferentialChangeType::FILE_SYMLINK => 'symlink', 1736 - DifferentialChangeType::FILE_SUBMODULE => 'submodule', 1737 - ); 1738 - 1739 - static $changes = array( 1740 - DifferentialChangeType::TYPE_ADD => 'added', 1741 - DifferentialChangeType::TYPE_CHANGE => 'changed', 1742 - DifferentialChangeType::TYPE_DELETE => 'deleted', 1743 - DifferentialChangeType::TYPE_MOVE_HERE => 'moved from', 1744 - DifferentialChangeType::TYPE_COPY_HERE => 'copied from', 1745 - DifferentialChangeType::TYPE_MOVE_AWAY => 'moved to', 1746 - DifferentialChangeType::TYPE_COPY_AWAY => 'copied to', 1747 - DifferentialChangeType::TYPE_MULTICOPY 1748 - => 'deleted after being copied to', 1749 - ); 1750 - 1751 1725 $change = $changeset->getChangeType(); 1752 1726 $file = $changeset->getFileType(); 1753 1727 ··· 1757 1731 if ($force) { 1758 1732 // We have to force something to render because there were no changes 1759 1733 // of other kinds. 1760 - $message = "This {$files[$file]} was not modified."; 1734 + $message = pht('This file was not modified.'); 1761 1735 } else { 1762 1736 // Default case of changes to a text file, no metadata. 1763 1737 return null; 1764 1738 } 1765 1739 } else { 1766 - $verb = idx($changes, $change, 'changed'); 1767 1740 switch ($change) { 1768 - default: 1769 - $message = "This {$files[$file]} was <strong>{$verb}</strong>."; 1741 + 1742 + case DifferentialChangeType::TYPE_ADD: 1743 + switch ($file) { 1744 + case DifferentialChangeType::FILE_TEXT: 1745 + $message = pht('This file was <strong>added</strong>.'); 1746 + break; 1747 + case DifferentialChangeType::FILE_IMAGE: 1748 + $message = pht('This image was <strong>added</strong>.'); 1749 + break; 1750 + case DifferentialChangeType::FILE_DIRECTORY: 1751 + $message = pht('This directory was <strong>added</strong>.'); 1752 + break; 1753 + case DifferentialChangeType::FILE_BINARY: 1754 + $message = pht('This binary file was <strong>added</strong>.'); 1755 + break; 1756 + case DifferentialChangeType::FILE_SYMLINK: 1757 + $message = pht('This symlink was <strong>added</strong>.'); 1758 + break; 1759 + case DifferentialChangeType::FILE_SUBMODULE: 1760 + $message = pht('This submodule was <strong>added</strong>.'); 1761 + break; 1762 + } 1770 1763 break; 1764 + 1765 + case DifferentialChangeType::TYPE_DELETE: 1766 + switch ($file) { 1767 + case DifferentialChangeType::FILE_TEXT: 1768 + $message = pht('This file was <strong>deleted</strong>.'); 1769 + break; 1770 + case DifferentialChangeType::FILE_IMAGE: 1771 + $message = pht('This image was <strong>deleted</strong>.'); 1772 + break; 1773 + case DifferentialChangeType::FILE_DIRECTORY: 1774 + $message = pht('This directory was <strong>deleted</strong>.'); 1775 + break; 1776 + case DifferentialChangeType::FILE_BINARY: 1777 + $message = pht('This binary file was <strong>deleted</strong>.'); 1778 + break; 1779 + case DifferentialChangeType::FILE_SYMLINK: 1780 + $message = pht('This symlink was <strong>deleted</strong>.'); 1781 + break; 1782 + case DifferentialChangeType::FILE_SUBMODULE: 1783 + $message = pht('This submodule was <strong>deleted</strong>.'); 1784 + break; 1785 + } 1786 + break; 1787 + 1771 1788 case DifferentialChangeType::TYPE_MOVE_HERE: 1789 + $from = 1790 + "<strong>". 1791 + phutil_escape_html($changeset->getOldFile()). 1792 + "</strong>"; 1793 + switch ($file) { 1794 + case DifferentialChangeType::FILE_TEXT: 1795 + $message = pht('This file was moved from %s.', $from); 1796 + break; 1797 + case DifferentialChangeType::FILE_IMAGE: 1798 + $message = pht('This image was moved from %s.', $from); 1799 + break; 1800 + case DifferentialChangeType::FILE_DIRECTORY: 1801 + $message = pht('This directory was moved from %s.', $from); 1802 + break; 1803 + case DifferentialChangeType::FILE_BINARY: 1804 + $message = pht('This binary file was moved from %s.', $from); 1805 + break; 1806 + case DifferentialChangeType::FILE_SYMLINK: 1807 + $message = pht('This symlink was moved from %s.', $from); 1808 + break; 1809 + case DifferentialChangeType::FILE_SUBMODULE: 1810 + $message = pht('This submodule was moved from %s.', $from); 1811 + break; 1812 + } 1813 + 1772 1814 case DifferentialChangeType::TYPE_COPY_HERE: 1773 - $message = 1774 - "This {$files[$file]} was {$verb} ". 1815 + $from = 1775 1816 "<strong>". 1776 1817 phutil_escape_html($changeset->getOldFile()). 1777 - "</strong>."; 1818 + "</strong>"; 1819 + switch ($file) { 1820 + case DifferentialChangeType::FILE_TEXT: 1821 + $message = pht('This file was copied from %s.', $from); 1822 + break; 1823 + case DifferentialChangeType::FILE_IMAGE: 1824 + $message = pht('This image was copied from %s.', $from); 1825 + break; 1826 + case DifferentialChangeType::FILE_DIRECTORY: 1827 + $message = pht('This directory was copied from %s.', $from); 1828 + break; 1829 + case DifferentialChangeType::FILE_BINARY: 1830 + $message = pht('This binary file was copied from %s.', $from); 1831 + break; 1832 + case DifferentialChangeType::FILE_SYMLINK: 1833 + $message = pht('This symlink was copied from %s.', $from); 1834 + break; 1835 + case DifferentialChangeType::FILE_SUBMODULE: 1836 + $message = pht('This submodule was copied from %s.', $from); 1837 + break; 1838 + } 1778 1839 break; 1840 + 1779 1841 case DifferentialChangeType::TYPE_MOVE_AWAY: 1842 + $paths = 1843 + "<strong>". 1844 + phutil_escape_html(implode(', ', $changeset->getAwayPaths())). 1845 + "</strong>"; 1846 + switch ($file) { 1847 + case DifferentialChangeType::FILE_TEXT: 1848 + $message = pht('This file was moved to %s.', $paths); 1849 + break; 1850 + case DifferentialChangeType::FILE_IMAGE: 1851 + $message = pht('This image was moved to %s.', $paths); 1852 + break; 1853 + case DifferentialChangeType::FILE_DIRECTORY: 1854 + $message = pht('This directory was moved to %s.', $paths); 1855 + break; 1856 + case DifferentialChangeType::FILE_BINARY: 1857 + $message = pht('This binary file was moved to %s.', $paths); 1858 + break; 1859 + case DifferentialChangeType::FILE_SYMLINK: 1860 + $message = pht('This symlink was moved to %s.', $paths); 1861 + break; 1862 + case DifferentialChangeType::FILE_SUBMODULE: 1863 + $message = pht('This submodule was moved to %s.', $paths); 1864 + break; 1865 + } 1866 + break; 1867 + 1780 1868 case DifferentialChangeType::TYPE_COPY_AWAY: 1869 + $paths = 1870 + "<strong>". 1871 + phutil_escape_html(implode(', ', $changeset->getAwayPaths())). 1872 + "</strong>"; 1873 + switch ($file) { 1874 + case DifferentialChangeType::FILE_TEXT: 1875 + $message = pht('This file was copied to %s.', $paths); 1876 + break; 1877 + case DifferentialChangeType::FILE_IMAGE: 1878 + $message = pht('This image was copied to %s.', $paths); 1879 + break; 1880 + case DifferentialChangeType::FILE_DIRECTORY: 1881 + $message = pht('This directory was copied to %s.', $paths); 1882 + break; 1883 + case DifferentialChangeType::FILE_BINARY: 1884 + $message = pht('This binary file was copied to %s.', $paths); 1885 + break; 1886 + case DifferentialChangeType::FILE_SYMLINK: 1887 + $message = pht('This symlink was copied to %s.', $paths); 1888 + break; 1889 + case DifferentialChangeType::FILE_SUBMODULE: 1890 + $message = pht('This submodule was copied to %s.', $paths); 1891 + break; 1892 + } 1893 + break; 1894 + 1781 1895 case DifferentialChangeType::TYPE_MULTICOPY: 1782 - $paths = $changeset->getAwayPaths(); 1783 - if (count($paths) > 1) { 1784 - $message = 1785 - "This {$files[$file]} was {$verb}: ". 1786 - "<strong>".phutil_escape_html(implode(', ', $paths))."</strong>."; 1787 - } else { 1788 - $message = 1789 - "This {$files[$file]} was {$verb} ". 1790 - "<strong>".phutil_escape_html(reset($paths))."</strong>."; 1896 + $paths = 1897 + "<strong>". 1898 + phutil_escape_html(implode(', ', $changeset->getAwayPaths())). 1899 + "</strong>"; 1900 + switch ($file) { 1901 + case DifferentialChangeType::FILE_TEXT: 1902 + $message = pht( 1903 + 'This file was deleted after being copied to %s.', 1904 + $paths); 1905 + break; 1906 + case DifferentialChangeType::FILE_IMAGE: 1907 + $message = pht( 1908 + 'This image was deleted after being copied to %s.', 1909 + $paths); 1910 + break; 1911 + case DifferentialChangeType::FILE_DIRECTORY: 1912 + $message = pht( 1913 + 'This directory was deleted after being copied to %s.', 1914 + $paths); 1915 + break; 1916 + case DifferentialChangeType::FILE_BINARY: 1917 + $message = pht( 1918 + 'This binary file was deleted after being copied to %s.', 1919 + $paths); 1920 + break; 1921 + case DifferentialChangeType::FILE_SYMLINK: 1922 + $message = pht( 1923 + 'This symlink was deleted after being copied to %s.', 1924 + $paths); 1925 + break; 1926 + case DifferentialChangeType::FILE_SUBMODULE: 1927 + $message = pht( 1928 + 'This submodule was deleted after being copied to %s.', 1929 + $paths); 1930 + break; 1791 1931 } 1792 1932 break; 1793 - case DifferentialChangeType::TYPE_CHANGE: 1794 - $message = "This is ".idx($articles, $file, 'a')." {$files[$file]}."; 1933 + 1934 + default: 1935 + switch ($file) { 1936 + case DifferentialChangeType::FILE_TEXT: 1937 + $message = pht('This is a file.'); 1938 + break; 1939 + case DifferentialChangeType::FILE_IMAGE: 1940 + $message = pht('This is an image.'); 1941 + break; 1942 + case DifferentialChangeType::FILE_DIRECTORY: 1943 + $message = pht('This is a directory.'); 1944 + break; 1945 + case DifferentialChangeType::FILE_BINARY: 1946 + $message = pht('This is a binary file.'); 1947 + break; 1948 + case DifferentialChangeType::FILE_SYMLINK: 1949 + $message = pht('This is a symlink.'); 1950 + break; 1951 + case DifferentialChangeType::FILE_SUBMODULE: 1952 + $message = pht('This is a submodule.'); 1953 + break; 1954 + } 1795 1955 break; 1796 1956 } 1797 1957 }