recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Leave fullscreen editor when displaying "Upload File" and "Meme" dialogs

Summary:
When being in fullscreen editor mode, the `Upload File` and `Meme` dialogs get opened behind the editor and thus are invisible.
Given the options listed in https://secure.phabricator.com/T8200, pop out of fullscreen when these buttons get clicked, as this is easiest to implement.

Closes T15901

Test Plan:
1. Go to any item which allows commenting, e.g. a task.
2. In the toolbar of the textarea, click the `Fullscreen Mode` button.
3. Click the `Upload File` or `Meme` button in the toolbar.
4. Check if the dialog is displayed.
6. Repeat the test in normal mode (not "Fullscreen mode") and see that it still works.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: avivey, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Tags: #remarkup

Maniphest Tasks: T15901

Differential Revision: https://we.phorge.it/D25764

Andre Klapper 2574b0d1 ebbe83c3

+22 -16
+16 -16
resources/celerity/map.php
··· 9 9 'names' => array( 10 10 'conpherence.pkg.css' => '2f25eb4f', 11 11 'conpherence.pkg.js' => '020aebcf', 12 - 'core.pkg.css' => '112931ab', 13 - 'core.pkg.js' => '8c86adab', 12 + 'core.pkg.css' => 'ac619266', 13 + 'core.pkg.js' => 'b3c5c317', 14 14 'dark-console.pkg.js' => '187792c2', 15 15 'differential.pkg.css' => '94bb10ca', 16 16 'differential.pkg.js' => '46fcb3af', ··· 490 490 'rsrc/js/core/behavior-more.js' => '506aa3f4', 491 491 'rsrc/js/core/behavior-object-selector.js' => '98ef467f', 492 492 'rsrc/js/core/behavior-oncopy.js' => 'da8f5259', 493 - 'rsrc/js/core/behavior-phabricator-remarkup-assist.js' => '6d347847', 493 + 'rsrc/js/core/behavior-phabricator-remarkup-assist.js' => 'daceb29a', 494 494 'rsrc/js/core/behavior-read-only-warning.js' => 'b9109f8f', 495 495 'rsrc/js/core/behavior-redirect.js' => '407ee861', 496 496 'rsrc/js/core/behavior-refresh-csrf.js' => '46116c01', ··· 654 654 'javelin-behavior-phabricator-notification-example' => '29819b75', 655 655 'javelin-behavior-phabricator-object-selector' => '98ef467f', 656 656 'javelin-behavior-phabricator-oncopy' => 'da8f5259', 657 - 'javelin-behavior-phabricator-remarkup-assist' => '6d347847', 657 + 'javelin-behavior-phabricator-remarkup-assist' => 'daceb29a', 658 658 'javelin-behavior-phabricator-reveal-content' => 'b105a3a6', 659 659 'javelin-behavior-phabricator-search-typeahead' => '1cb7d027', 660 660 'javelin-behavior-phabricator-show-older-transactions' => '8b5c7d65', ··· 1570 1570 'javelin-install', 1571 1571 'javelin-util', 1572 1572 ), 1573 - '6d347847' => array( 1574 - 'javelin-behavior', 1575 - 'javelin-stratcom', 1576 - 'javelin-dom', 1577 - 'phabricator-phtize', 1578 - 'phabricator-textareautils', 1579 - 'phabricator-remarkup-metadata', 1580 - 'javelin-workflow', 1581 - 'javelin-vector', 1582 - 'phuix-autocomplete', 1583 - 'javelin-mask', 1584 - ), 1585 1573 70245195 => array( 1586 1574 'javelin-behavior', 1587 1575 'javelin-stratcom', ··· 2114 2102 'da8f5259' => array( 2115 2103 'javelin-behavior', 2116 2104 'javelin-dom', 2105 + ), 2106 + 'daceb29a' => array( 2107 + 'javelin-behavior', 2108 + 'javelin-stratcom', 2109 + 'javelin-dom', 2110 + 'phabricator-phtize', 2111 + 'phabricator-textareautils', 2112 + 'phabricator-remarkup-metadata', 2113 + 'javelin-workflow', 2114 + 'javelin-vector', 2115 + 'phuix-autocomplete', 2116 + 'javelin-mask', 2117 2117 ), 2118 2118 'dae2d55b' => array( 2119 2119 'javelin-behavior',
+6
webroot/rsrc/js/core/behavior-phabricator-remarkup-assist.js
··· 233 233 update(area, table_prefix + '| ', sel || pht('data'), ' |'); 234 234 break; 235 235 case 'fa-meh-o': 236 + // Deactivate full-screen to avoid popup visibility problems. 237 + set_edit_mode(edit_root, 'normal'); 238 + 236 239 new JX.Workflow('/macro/meme/create/') 237 240 .setHandler(function(response) { 238 241 update( ··· 244 247 .start(); 245 248 break; 246 249 case 'fa-cloud-upload': 250 + // Deactivate full-screen to avoid popup visibility problems. 251 + set_edit_mode(edit_root, 'normal'); 252 + 247 253 new JX.Workflow('/file/uploaddialog/') 248 254 .setHandler(function(response) { 249 255 var files = response.files;