@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Correctly calculate "any_failed"
Summary: See T10746.
Test Plan: Fail one of several builds, run `./bin/harbormaster update`, see that Build Status is Failed.
Reviewers: #blessed_reviewers, epriestley
Reviewed By: #blessed_reviewers, epriestley
Subscribers: epriestley, O14 ATC Monitoring, yelirekim
Maniphest Tasks: T10746
Differential Revision: https://secure.phabricator.com/D16480
+5
-2
+5
-2
src/applications/harbormaster/engine/HarbormasterBuildEngine.php
+5
-2
src/applications/harbormaster/engine/HarbormasterBuildEngine.php
···
446
446
if ($build->getBuildStatus() != HarbormasterBuildStatus::STATUS_PASSED) {
447
447
$all_pass = false;
448
448
}
449
-
$any_fail = in_array($build->getBuildStatus(), array(
449
+
if (in_array($build->getBuildStatus(), array(
450
450
HarbormasterBuildStatus::STATUS_FAILED,
451
451
HarbormasterBuildStatus::STATUS_ERROR,
452
452
HarbormasterBuildStatus::STATUS_DEADLOCKED,
453
-
));
453
+
))) {
454
+
455
+
$any_fail = true;
456
+
}
454
457
}
455
458
456
459
if ($any_fail) {