recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix PHP 8.1 "strlen(null)" exception shown when sending SMS Test Message to Contact Number

Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15382

Test Plan:
Applied this change and after performing steps to send a test message again, `/mail/detail/107/` page got rendered correctly
and I can see the "Status Details" with stuff like "//None//" or "No mailers are configured."

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15382

Differential Revision: https://we.phorge.it/D25215

Andre Klapper 26aed493 8a1cfff1

+1 -1
+1 -1
src/applications/metamta/controller/PhabricatorMetaMTAMailViewController.php
··· 421 421 $properties->addProperty(pht('Message PHID'), $mail->getPHID()); 422 422 423 423 $details = $mail->getMessage(); 424 - if (!strlen($details)) { 424 + if (!phutil_nonempty_string($details)) { 425 425 $details = phutil_tag('em', array(), pht('None')); 426 426 } 427 427 $properties->addProperty(pht('Status Details'), $details);