@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Move existing "Console" interfaces away from "setFixed(...)" on "TwoColumnView"
Summary: Depends on D20931. Ref T13362. Move all "Console"-style interfaces to use a consistent layout based on a new "LauncherView" which just centers the content.
Test Plan: Viewed all affected interfaces.
Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam
Maniphest Tasks: T13362
Differential Revision: https://secure.phabricator.com/D20933
+55
-18
+3
-3
resources/celerity/map.php
+3
-3
resources/celerity/map.php
···
9
9
'names' => array(
10
10
'conpherence.pkg.css' => '3c8a0668',
11
11
'conpherence.pkg.js' => '020aebcf',
12
-
'core.pkg.css' => 'ad8fc332',
12
+
'core.pkg.css' => '6d9a0ba6',
13
13
'core.pkg.js' => '705aec2c',
14
14
'differential.pkg.css' => '607c84be',
15
15
'differential.pkg.js' => '1b97518d',
···
176
176
'rsrc/css/phui/phui-status.css' => 'e5ff8be0',
177
177
'rsrc/css/phui/phui-tag-view.css' => '8519160a',
178
178
'rsrc/css/phui/phui-timeline-view.css' => '1e348e4b',
179
-
'rsrc/css/phui/phui-two-column-view.css' => '0a876b9e',
179
+
'rsrc/css/phui/phui-two-column-view.css' => 'f96d319f',
180
180
'rsrc/css/phui/workboards/phui-workboard-color.css' => 'e86de308',
181
181
'rsrc/css/phui/workboards/phui-workboard.css' => '74fc9d98',
182
182
'rsrc/css/phui/workboards/phui-workcard.css' => '913441b6',
···
873
873
'phui-tag-view-css' => '8519160a',
874
874
'phui-theme-css' => '35883b37',
875
875
'phui-timeline-view-css' => '1e348e4b',
876
-
'phui-two-column-view-css' => '0a876b9e',
876
+
'phui-two-column-view-css' => 'f96d319f',
877
877
'phui-workboard-color-css' => 'e86de308',
878
878
'phui-workboard-view-css' => '74fc9d98',
879
879
'phui-workcard-view-css' => '913441b6',
+2
src/__phutil_library_map__.php
+2
src/__phutil_library_map__.php
···
2037
2037
'PHUIInfoView' => 'view/phui/PHUIInfoView.php',
2038
2038
'PHUIInvisibleCharacterTestCase' => 'view/phui/__tests__/PHUIInvisibleCharacterTestCase.php',
2039
2039
'PHUIInvisibleCharacterView' => 'view/phui/PHUIInvisibleCharacterView.php',
2040
+
'PHUILauncherView' => 'view/phui/PHUILauncherView.php',
2040
2041
'PHUILeftRightExample' => 'applications/uiexample/examples/PHUILeftRightExample.php',
2041
2042
'PHUILeftRightView' => 'view/phui/PHUILeftRightView.php',
2042
2043
'PHUIListExample' => 'applications/uiexample/examples/PHUIListExample.php',
···
8236
8237
'PHUIInfoView' => 'AphrontTagView',
8237
8238
'PHUIInvisibleCharacterTestCase' => 'PhabricatorTestCase',
8238
8239
'PHUIInvisibleCharacterView' => 'AphrontView',
8240
+
'PHUILauncherView' => 'AphrontTagView',
8239
8241
'PHUILeftRightExample' => 'PhabricatorUIExample',
8240
8242
'PHUILeftRightView' => 'AphrontTagView',
8241
8243
'PHUIListExample' => 'PhabricatorUIExample',
+12
-8
src/applications/almanac/controller/AlmanacConsoleController.php
+12
-8
src/applications/almanac/controller/AlmanacConsoleController.php
···
10
10
$viewer = $request->getViewer();
11
11
12
12
$menu = id(new PHUIObjectItemListView())
13
-
->setUser($viewer);
13
+
->setUser($viewer)
14
+
->setBig(true);
14
15
15
16
$menu->addItem(
16
17
id(new PHUIObjectItemView())
17
18
->setHeader(pht('Devices'))
18
19
->setHref($this->getApplicationURI('device/'))
19
20
->setImageIcon('fa-server')
21
+
->setClickable(true)
20
22
->addAttribute(
21
23
pht(
22
24
'Create an inventory of physical and virtual hosts and '.
···
27
29
->setHeader(pht('Services'))
28
30
->setHref($this->getApplicationURI('service/'))
29
31
->setImageIcon('fa-plug')
32
+
->setClickable(true)
30
33
->addAttribute(
31
34
pht(
32
35
'Create and update services, and map them to interfaces on '.
···
37
40
->setHeader(pht('Networks'))
38
41
->setHref($this->getApplicationURI('network/'))
39
42
->setImageIcon('fa-globe')
43
+
->setClickable(true)
40
44
->addAttribute(
41
45
pht(
42
46
'Manage public and private networks.')));
···
46
50
->setHeader(pht('Namespaces'))
47
51
->setHref($this->getApplicationURI('namespace/'))
48
52
->setImageIcon('fa-asterisk')
53
+
->setClickable(true)
49
54
->addAttribute(
50
55
pht('Control who can create new named services and devices.')));
51
56
···
57
62
->setHeader(pht('Documentation'))
58
63
->setHref($docs_uri)
59
64
->setImageIcon('fa-book')
65
+
->setClickable(true)
60
66
->addAttribute(pht('Browse documentation for Almanac.')));
61
67
62
68
$crumbs = $this->buildApplicationCrumbs();
···
64
70
$crumbs->setBorder(true);
65
71
66
72
$box = id(new PHUIObjectBoxView())
73
+
->setHeaderText(pht('Almanac Console'))
74
+
->setBackground(PHUIObjectBoxView::WHITE_CONFIG)
67
75
->setObjectList($menu);
68
76
69
-
$header = id(new PHUIHeaderView())
70
-
->setHeader(pht('Almanac Console'))
71
-
->setHeaderIcon('fa-server');
77
+
$launcher_view = id(new PHUILauncherView())
78
+
->appendChild($box);
72
79
73
80
$view = id(new PHUITwoColumnView())
74
-
->setHeader($header)
75
-
->setFooter(array(
76
-
$box,
77
-
));
81
+
->setFooter($launcher_view);
78
82
79
83
return $this->newPage()
80
84
->setTitle(pht('Almanac Console'))
+4
-2
src/applications/dashboard/controller/PhabricatorDashboardConsoleController.php
+4
-2
src/applications/dashboard/controller/PhabricatorDashboardConsoleController.php
···
59
59
->setBackground(PHUIObjectBoxView::WHITE_CONFIG)
60
60
->setObjectList($menu);
61
61
62
+
$launch_view = id(new PHUILauncherView())
63
+
->appendChild($box);
64
+
62
65
$view = id(new PHUITwoColumnView())
63
-
->setFixed(true)
64
-
->setFooter($box);
66
+
->setFooter($launch_view);
65
67
66
68
return $this->newPage()
67
69
->setTitle($title)
+5
-3
src/applications/diffusion/controller/DiffusionRepositoryEditController.php
+5
-3
src/applications/diffusion/controller/DiffusionRepositoryEditController.php
···
78
78
->addClass('diffusion-create-repo')
79
79
->appendChild($layout);
80
80
81
-
$view = id(new PHUITwoColumnView())
82
-
->setFixed(true)
83
-
->setFooter(
81
+
$launcher_view = id(new PHUILauncherView())
82
+
->appendChild(
84
83
array(
85
84
$layout,
86
85
$hints,
87
86
));
87
+
88
+
$view = id(new PHUITwoColumnView())
89
+
->setFooter($launcher_view);
88
90
89
91
return $this->newPage()
90
92
->setTitle($title)
+4
-2
src/applications/drydock/controller/DrydockConsoleController.php
+4
-2
src/applications/drydock/controller/DrydockConsoleController.php
···
76
76
->setBackground(PHUIObjectBoxView::WHITE_CONFIG)
77
77
->setObjectList($menu);
78
78
79
+
$launcher_view = id(new PHUILauncherView())
80
+
->appendChild($box);
81
+
79
82
$view = id(new PHUITwoColumnView())
80
-
->setFixed(true)
81
-
->setFooter($box);
83
+
->setFooter($launcher_view);
82
84
83
85
return $this->newPage()
84
86
->setTitle($title)
+20
src/view/phui/PHUILauncherView.php
+20
src/view/phui/PHUILauncherView.php
···
1
+
<?php
2
+
3
+
final class PHUILauncherView
4
+
extends AphrontTagView {
5
+
6
+
protected function getTagName() {
7
+
return 'div';
8
+
}
9
+
10
+
protected function getTagAttributes() {
11
+
$classes = array();
12
+
13
+
$classes[] = 'phui-launcher-view';
14
+
15
+
return array(
16
+
'class' => implode(' ', $classes),
17
+
);
18
+
}
19
+
20
+
}