@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
When reviewing, always show "Accept" checkboxes for packages/projects, even if there's only one checkbox
Summary: Fixes T12533.
Test Plan: {F4853371}
Reviewers: chad, lvital
Reviewed By: lvital
Maniphest Tasks: T12533
Differential Revision: https://secure.phabricator.com/D17652
+6
-2
+6
-2
src/applications/differential/xaction/DifferentialRevisionActionTransaction.php
+6
-2
src/applications/differential/xaction/DifferentialRevisionActionTransaction.php
···
124
124
list($options, $value) = $this->getActionOptions($viewer, $revision);
125
125
126
126
// Show the options if the user can select on behalf of two or more
127
-
// reviewers, or can force-accept on behalf of one or more reviewers.
127
+
// reviewers, or can force-accept on behalf of one or more reviewers,
128
+
// or can accept on behalf of a reviewer other than themselves (see
129
+
// T12533).
128
130
$can_multi = (count($options) > 1);
129
131
$can_force = (count($value) < count($options));
130
-
if ($can_multi || $can_force) {
132
+
$not_self = (head_key($options) != $viewer->getPHID());
133
+
134
+
if ($can_multi || $can_force || $not_self) {
131
135
$field->setOptions($options);
132
136
$field->setValue($value);
133
137
}