@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Clean up authentication list
Summary: Uses more standard boxes for display, and icons!
Test Plan:
Test with all enabled, all disabled, and a mix.
{F285945}
{F285946}
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Differential Revision: https://secure.phabricator.com/D11707
+30
-17
+3
-3
resources/celerity/map.php
+3
-3
resources/celerity/map.php
···
7
7
*/
8
8
return array(
9
9
'names' => array(
10
-
'core.pkg.css' => 'f1eab25d',
10
+
'core.pkg.css' => 'e09f7a8c',
11
11
'core.pkg.js' => '65e04767',
12
12
'darkconsole.pkg.js' => '8ab24e01',
13
13
'differential.pkg.css' => '8af45893',
···
137
137
'rsrc/css/phui/phui-info-panel.css' => '27ea50a1',
138
138
'rsrc/css/phui/phui-list.css' => '53deb25c',
139
139
'rsrc/css/phui/phui-object-box.css' => 'b8b7fd78',
140
-
'rsrc/css/phui/phui-object-item-list-view.css' => '2670a4a9',
140
+
'rsrc/css/phui/phui-object-item-list-view.css' => '97d117e1',
141
141
'rsrc/css/phui/phui-pinboard-view.css' => '3dd4a269',
142
142
'rsrc/css/phui/phui-property-list-view.css' => '51480060',
143
143
'rsrc/css/phui/phui-remarkup-preview.css' => '19ad512b',
···
785
785
'phui-info-panel-css' => '27ea50a1',
786
786
'phui-list-view-css' => '53deb25c',
787
787
'phui-object-box-css' => 'b8b7fd78',
788
-
'phui-object-item-list-view-css' => '2670a4a9',
788
+
'phui-object-item-list-view-css' => '97d117e1',
789
789
'phui-pinboard-view-css' => '3dd4a269',
790
790
'phui-property-list-view-css' => '51480060',
791
791
'phui-remarkup-preview-css' => '19ad512b',
+23
-8
src/applications/auth/controller/config/PhabricatorAuthListController.php
+23
-8
src/applications/auth/controller/config/PhabricatorAuthListController.php
···
12
12
->execute();
13
13
14
14
$list = new PHUIObjectItemListView();
15
+
15
16
foreach ($configs as $config) {
16
17
$item = new PHUIObjectItemView();
17
18
···
28
29
$name = $config->getProviderType().' ('.$config->getProviderClass().')';
29
30
}
30
31
31
-
$item
32
-
->setHeader($name);
32
+
$item->setHeader($name);
33
33
34
34
if ($provider) {
35
35
$item->setHref($edit_uri);
···
52
52
$can_manage = $this->hasApplicationCapability(
53
53
AuthManageProvidersCapability::CAPABILITY);
54
54
if ($config->getIsEnabled()) {
55
-
$item->setBarColor('green');
55
+
$item->setState(PHUIObjectItemView::STATE_SUCCESS);
56
56
$item->addAction(
57
57
id(new PHUIListItemView())
58
58
->setIcon('fa-times')
···
60
60
->setDisabled(!$can_manage)
61
61
->addSigil('workflow'));
62
62
} else {
63
-
$item->setBarColor('grey');
63
+
$item->setState(PHUIObjectItemView::STATE_FAIL);
64
64
$item->addIcon('fa-times grey', pht('Disabled'));
65
65
$item->addAction(
66
66
id(new PHUIListItemView())
···
90
90
pht('Add Authentication Provider'))));
91
91
92
92
$crumbs = $this->buildApplicationCrumbs();
93
-
$crumbs->setBorder(true);
94
93
$crumbs->addTextCrumb(pht('Auth Providers'));
95
94
96
95
$config_name = 'auth.email-domains';
···
108
107
$email_domains = PhabricatorEnv::getEnvConfig($config_name);
109
108
if ($email_domains) {
110
109
$warning->setSeverity(PHUIErrorView::SEVERITY_NOTICE);
111
-
$warning->setTitle(pht('Registration is Restricted'));
112
110
$warning->appendChild(
113
111
pht(
114
112
'Only users with a verified email address at one of the %s domains '.
···
117
115
phutil_tag('strong', array(), implode(', ', $email_domains))));
118
116
} else {
119
117
$warning->setSeverity(PHUIErrorView::SEVERITY_WARNING);
120
-
$warning->setTitle(pht('Anyone Can Register an Account'));
121
118
$warning->appendChild(
122
119
pht(
123
120
'Anyone who can browse to this Phabricator install will be able to '.
···
126
123
$config_link));
127
124
}
128
125
126
+
$image = id(new PHUIIconView())
127
+
->setIconFont('fa-plus');
128
+
$button = id(new PHUIButtonView())
129
+
->setTag('a')
130
+
->setColor(PHUIButtonView::SIMPLE)
131
+
->setHref($this->getApplicationURI('config/new/'))
132
+
->setIcon($image)
133
+
->setText(pht('Add Provider'));
134
+
135
+
$header = id(new PHUIHeaderView())
136
+
->setHeader(pht('Authentication Providers'))
137
+
->addActionLink($button);
138
+
139
+
$list->setFlush(true);
140
+
$list = id(new PHUIObjectBoxView())
141
+
->setHeader($header)
142
+
->setErrorView($warning)
143
+
->appendChild($list);
144
+
129
145
return $this->buildApplicationPage(
130
146
array(
131
147
$crumbs,
132
-
$warning,
133
148
$list,
134
149
),
135
150
array(
-6
src/applications/auth/controller/config/PhabricatorAuthProviderConfigController.php
-6
src/applications/auth/controller/config/PhabricatorAuthProviderConfigController.php
···
25
25
26
26
$can_create = $this->hasApplicationCapability(
27
27
AuthManageProvidersCapability::CAPABILITY);
28
-
$crumbs->addAction(
29
-
id(new PHUIListItemView())
30
-
->setName(pht('Add Authentication Provider'))
31
-
->setHref($this->getApplicationURI('/config/new/'))
32
-
->setDisabled(!$can_create)
33
-
->setIcon('fa-plus-square'));
34
28
35
29
return $crumbs;
36
30
}
+4
webroot/rsrc/css/phui/phui-object-item-list-view.css
+4
webroot/rsrc/css/phui/phui-object-item-list-view.css