@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Use single quotes in JavaScript files
Summary: Use single quotes to keep JSHint happy.
Test Plan: `arc lint`
Reviewers: #blessed_reviewers, epriestley
Reviewed By: #blessed_reviewers, epriestley
Subscribers: Korvin, epriestley
Differential Revision: https://secure.phabricator.com/D11431
+72
-72
+57
-57
resources/celerity/map.php
+57
-57
resources/celerity/map.php
···
8
8
return array(
9
9
'names' => array(
10
10
'core.pkg.css' => '8d1c0f87',
11
-
'core.pkg.js' => '7923c2e6',
11
+
'core.pkg.js' => 'd60876a7',
12
12
'darkconsole.pkg.js' => '8ab24e01',
13
13
'differential.pkg.css' => '8af45893',
14
-
'differential.pkg.js' => 'dad3622f',
14
+
'differential.pkg.js' => 'f437e70e',
15
15
'diffusion.pkg.css' => '591664fa',
16
16
'diffusion.pkg.js' => 'bfc0737b',
17
17
'maniphest.pkg.css' => 'e34dfbec',
···
166
166
'rsrc/externals/javelin/core/__tests__/install.js' => 'c432ee85',
167
167
'rsrc/externals/javelin/core/__tests__/stratcom.js' => '88bf7313',
168
168
'rsrc/externals/javelin/core/__tests__/util.js' => 'e251703d',
169
-
'rsrc/externals/javelin/core/init.js' => '76e1fd61',
170
-
'rsrc/externals/javelin/core/init_node.js' => '7212f324',
169
+
'rsrc/externals/javelin/core/init.js' => '8c4e8f8b',
170
+
'rsrc/externals/javelin/core/init_node.js' => '77350e4d',
171
171
'rsrc/externals/javelin/core/install.js' => '05270951',
172
-
'rsrc/externals/javelin/core/util.js' => 'bdcfee9e',
172
+
'rsrc/externals/javelin/core/util.js' => '93cc50d6',
173
173
'rsrc/externals/javelin/docs/Base.js' => '74676256',
174
174
'rsrc/externals/javelin/docs/onload.js' => 'e819c479',
175
175
'rsrc/externals/javelin/ext/fx/Color.js' => '7e41274a',
···
186
186
'rsrc/externals/javelin/ext/view/ViewRenderer.js' => '6c2b09a2',
187
187
'rsrc/externals/javelin/ext/view/ViewVisitor.js' => 'efe49472',
188
188
'rsrc/externals/javelin/ext/view/__tests__/HTMLView.js' => 'f92d7bcb',
189
-
'rsrc/externals/javelin/ext/view/__tests__/View.js' => 'bda69c40',
189
+
'rsrc/externals/javelin/ext/view/__tests__/View.js' => '6450b38b',
190
190
'rsrc/externals/javelin/ext/view/__tests__/ViewInterpreter.js' => '7a94d6a5',
191
191
'rsrc/externals/javelin/ext/view/__tests__/ViewRenderer.js' => '6ea96ac9',
192
192
'rsrc/externals/javelin/lib/Cookie.js' => '6b3dcf44',
193
-
'rsrc/externals/javelin/lib/DOM.js' => 'c4569c05',
193
+
'rsrc/externals/javelin/lib/DOM.js' => 'c8fd8db2',
194
194
'rsrc/externals/javelin/lib/History.js' => 'c60f4327',
195
195
'rsrc/externals/javelin/lib/JSON.js' => '69adf288',
196
196
'rsrc/externals/javelin/lib/Leader.js' => '9330f91b',
···
215
215
'rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadCompositeSource.js' => '503e17fd',
216
216
'rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadOnDemandSource.js' => '8b3fd187',
217
217
'rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadPreloadedSource.js' => '54f314a0',
218
-
'rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadSource.js' => 'e3b841c8',
218
+
'rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadSource.js' => '2818f5ce',
219
219
'rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadStaticSource.js' => '316b8fa1',
220
220
'rsrc/externals/raphael/g.raphael.js' => '40dde778',
221
221
'rsrc/externals/raphael/g.raphael.line.js' => '40da039e',
···
362
362
'rsrc/js/application/differential/behavior-comment-jump.js' => '4fdb476d',
363
363
'rsrc/js/application/differential/behavior-comment-preview.js' => '6932def3',
364
364
'rsrc/js/application/differential/behavior-diff-radios.js' => 'e1ff79b1',
365
-
'rsrc/js/application/differential/behavior-dropdown-menus.js' => '3bc14668',
365
+
'rsrc/js/application/differential/behavior-dropdown-menus.js' => 'e33d4bc5',
366
366
'rsrc/js/application/differential/behavior-edit-inline-comments.js' => '00861799',
367
367
'rsrc/js/application/differential/behavior-keyboard-nav.js' => '2c426492',
368
368
'rsrc/js/application/differential/behavior-populate.js' => 'bdb3e4d0',
···
410
410
'rsrc/js/application/projects/behavior-project-create.js' => '065227cc',
411
411
'rsrc/js/application/projects/behavior-reorder-columns.js' => 'e1d25dfb',
412
412
'rsrc/js/application/releeph/releeph-preview-branch.js' => 'b2b4fbaf',
413
-
'rsrc/js/application/releeph/releeph-request-state-change.js' => 'ab836011',
413
+
'rsrc/js/application/releeph/releeph-request-state-change.js' => '3a1a4060',
414
414
'rsrc/js/application/releeph/releeph-request-typeahead.js' => 'de2e896f',
415
415
'rsrc/js/application/repository/repository-crossreference.js' => 'f9539603',
416
416
'rsrc/js/application/search/behavior-reorder-queries.js' => 'e9581f08',
···
444
444
'rsrc/js/core/ShapedRequest.js' => '7cbe244b',
445
445
'rsrc/js/core/TextAreaUtils.js' => '5c93c52c',
446
446
'rsrc/js/core/Title.js' => '5c1c758c',
447
-
'rsrc/js/core/ToolTip.js' => '031d4411',
447
+
'rsrc/js/core/ToolTip.js' => '1d298e3a',
448
448
'rsrc/js/core/behavior-active-nav.js' => 'e379b58e',
449
449
'rsrc/js/core/behavior-audio-source.js' => '59b251eb',
450
450
'rsrc/js/core/behavior-autofocus.js' => '7319e029',
···
564
564
'javelin-behavior-differential-add-reviewers-and-ccs' => 'e10f8e18',
565
565
'javelin-behavior-differential-comment-jump' => '4fdb476d',
566
566
'javelin-behavior-differential-diff-radios' => 'e1ff79b1',
567
-
'javelin-behavior-differential-dropdown-menus' => '3bc14668',
567
+
'javelin-behavior-differential-dropdown-menus' => 'e33d4bc5',
568
568
'javelin-behavior-differential-edit-inline-comments' => '00861799',
569
569
'javelin-behavior-differential-feedback-preview' => '6932def3',
570
570
'javelin-behavior-differential-keyboard-navigation' => '2c426492',
···
635
635
'javelin-behavior-project-create' => '065227cc',
636
636
'javelin-behavior-refresh-csrf' => '7814b593',
637
637
'javelin-behavior-releeph-preview-branch' => 'b2b4fbaf',
638
-
'javelin-behavior-releeph-request-state-change' => 'ab836011',
638
+
'javelin-behavior-releeph-request-state-change' => '3a1a4060',
639
639
'javelin-behavior-releeph-request-typeahead' => 'de2e896f',
640
640
'javelin-behavior-remarkup-preview' => 'f7379f45',
641
641
'javelin-behavior-reorder-applications' => '76b9fc3e',
···
652
652
'javelin-color' => '7e41274a',
653
653
'javelin-cookie' => '6b3dcf44',
654
654
'javelin-diffusion-locate-file-source' => 'b42eddc7',
655
-
'javelin-dom' => 'c4569c05',
655
+
'javelin-dom' => 'c8fd8db2',
656
656
'javelin-dynval' => 'f6555212',
657
657
'javelin-event' => '85ea0626',
658
658
'javelin-fx' => '54b612ba',
···
660
660
'javelin-install' => '05270951',
661
661
'javelin-json' => '69adf288',
662
662
'javelin-leader' => '9330f91b',
663
-
'javelin-magical-init' => '76e1fd61',
663
+
'javelin-magical-init' => '8c4e8f8b',
664
664
'javelin-mask' => '8a41885b',
665
665
'javelin-reactor' => '2b8de964',
666
666
'javelin-reactor-dom' => 'c90a04fc',
···
677
677
'javelin-typeahead-normalizer' => '6f7a9da8',
678
678
'javelin-typeahead-ondemand-source' => '8b3fd187',
679
679
'javelin-typeahead-preloaded-source' => '54f314a0',
680
-
'javelin-typeahead-source' => 'e3b841c8',
680
+
'javelin-typeahead-source' => '2818f5ce',
681
681
'javelin-typeahead-static-source' => '316b8fa1',
682
682
'javelin-uri' => '6eff08aa',
683
-
'javelin-util' => 'bdcfee9e',
683
+
'javelin-util' => '93cc50d6',
684
684
'javelin-vector' => 'cc1bd0b0',
685
685
'javelin-view' => '0f764c35',
686
686
'javelin-view-html' => 'fe287620',
···
738
738
'phabricator-standard-page-view' => '2c96cfb5',
739
739
'phabricator-textareautils' => '5c93c52c',
740
740
'phabricator-title' => '5c1c758c',
741
-
'phabricator-tooltip' => '031d4411',
741
+
'phabricator-tooltip' => '1d298e3a',
742
742
'phabricator-transaction-view-css' => '5d0cae25',
743
743
'phabricator-ui-example-css' => '528b19de',
744
744
'phabricator-uiexample-javelin-view' => 'd4a14807',
···
834
834
'029a133d' => array(
835
835
'aphront-dialog-view-css',
836
836
),
837
-
'031d4411' => array(
838
-
'javelin-install',
839
-
'javelin-util',
840
-
'javelin-dom',
841
-
'javelin-vector',
842
-
),
843
837
'03d6ed07' => array(
844
838
'javelin-behavior',
845
839
'javelin-stratcom',
···
944
938
'javelin-util',
945
939
'phabricator-keyboard-shortcut-manager',
946
940
),
941
+
'1d298e3a' => array(
942
+
'javelin-install',
943
+
'javelin-util',
944
+
'javelin-dom',
945
+
'javelin-vector',
946
+
),
947
947
'1def2711' => array(
948
948
'javelin-install',
949
949
'javelin-dom',
···
955
955
'javelin-json',
956
956
'javelin-workflow',
957
957
'javelin-util',
958
+
),
959
+
'2818f5ce' => array(
960
+
'javelin-install',
961
+
'javelin-util',
962
+
'javelin-dom',
963
+
'javelin-typeahead-normalizer',
958
964
),
959
965
'2926fff2' => array(
960
966
'javelin-behavior',
···
1023
1029
'javelin-json',
1024
1030
'phabricator-prefab',
1025
1031
),
1032
+
'3a1a4060' => array(
1033
+
'javelin-behavior',
1034
+
'javelin-dom',
1035
+
'javelin-stratcom',
1036
+
'javelin-workflow',
1037
+
'javelin-util',
1038
+
'phabricator-keyboard-shortcut',
1039
+
),
1026
1040
'3ab51e2c' => array(
1027
1041
'javelin-behavior',
1028
1042
'javelin-behavior-device',
···
1030
1044
'javelin-vector',
1031
1045
'javelin-dom',
1032
1046
'javelin-magical-init',
1033
-
),
1034
-
'3bc14668' => array(
1035
-
'javelin-behavior',
1036
-
'javelin-dom',
1037
-
'javelin-util',
1038
-
'javelin-stratcom',
1039
-
'javelin-workflow',
1040
-
'phuix-dropdown-menu',
1041
-
'phuix-action-list-view',
1042
-
'phuix-action-view',
1043
-
'phabricator-phtize',
1044
-
'changeset-view-manager',
1045
1047
),
1046
1048
'3d51a746' => array(
1047
1049
'javelin-behavior',
···
1560
1562
'javelin-util',
1561
1563
'phabricator-prefab',
1562
1564
),
1563
-
'ab836011' => array(
1564
-
'javelin-behavior',
1565
-
'javelin-dom',
1566
-
'javelin-stratcom',
1567
-
'javelin-workflow',
1568
-
'javelin-util',
1569
-
'phabricator-keyboard-shortcut',
1570
-
),
1571
1565
'ad7a69ca' => array(
1572
1566
'javelin-install',
1573
1567
'javelin-util',
···
1656
1650
'javelin-util',
1657
1651
'phabricator-shaped-request',
1658
1652
),
1659
-
'c4569c05' => array(
1660
-
'javelin-magical-init',
1661
-
'javelin-install',
1662
-
'javelin-util',
1663
-
'javelin-vector',
1664
-
'javelin-stratcom',
1665
-
),
1666
1653
'c51ae228' => array(
1667
1654
'javelin-behavior',
1668
1655
'javelin-util',
···
1676
1663
'javelin-uri',
1677
1664
'javelin-util',
1678
1665
),
1666
+
'c8fd8db2' => array(
1667
+
'javelin-magical-init',
1668
+
'javelin-install',
1669
+
'javelin-util',
1670
+
'javelin-vector',
1671
+
'javelin-stratcom',
1672
+
),
1679
1673
'c90a04fc' => array(
1680
1674
'javelin-dom',
1681
1675
'javelin-dynval',
···
1794
1788
'javelin-workflow',
1795
1789
'javelin-vector',
1796
1790
),
1791
+
'e33d4bc5' => array(
1792
+
'javelin-behavior',
1793
+
'javelin-dom',
1794
+
'javelin-util',
1795
+
'javelin-stratcom',
1796
+
'javelin-workflow',
1797
+
'phuix-dropdown-menu',
1798
+
'phuix-action-list-view',
1799
+
'phuix-action-view',
1800
+
'phabricator-phtize',
1801
+
'changeset-view-manager',
1802
+
),
1797
1803
'e379b58e' => array(
1798
1804
'javelin-behavior',
1799
1805
'javelin-stratcom',
1800
1806
'javelin-vector',
1801
1807
'javelin-dom',
1802
1808
'javelin-uri',
1803
-
),
1804
-
'e3b841c8' => array(
1805
-
'javelin-install',
1806
-
'javelin-util',
1807
-
'javelin-dom',
1808
-
'javelin-typeahead-normalizer',
1809
1809
),
1810
1810
'e4cc26b3' => array(
1811
1811
'javelin-behavior',
+2
-2
support/aphlict/server/aphlict_server.js
+2
-2
support/aphlict/server/aphlict_server.js
···
22
22
var arg = argv[ii];
23
23
var matches = arg.match(/^--([^=]+)=(.*)$/);
24
24
if (!matches) {
25
-
throw new Error("Unknown argument '" + arg + "'!");
25
+
throw new Error('Unknown argument "' + arg + '"!');
26
26
}
27
27
if (!(matches[1] in config)) {
28
-
throw new Error("Unknown argument '" + matches[1] + "'!");
28
+
throw new Error('Unknown argument "' + matches[1] + '"!');
29
29
}
30
30
config[matches[1]] = matches[2];
31
31
}
+3
-3
webroot/rsrc/externals/javelin/core/init.js
+3
-3
webroot/rsrc/externals/javelin/core/init.js
···
208
208
}, true);
209
209
} else {
210
210
var ready =
211
-
"if (this.readyState == 'complete') {" +
212
-
"JX.__rawEventQueue({type: 'domready'});" +
213
-
"}";
211
+
'if (this.readyState == "complete") {' +
212
+
'JX.__rawEventQueue({type: "domready"});' +
213
+
'}';
214
214
215
215
// NOTE: Don't write a 'src' attribute, because "javascript:void(0)" causes
216
216
// a mixed content warning in IE8 if the page is served over SSL.
+1
-1
webroot/rsrc/externals/javelin/core/util.js
+1
-1
webroot/rsrc/externals/javelin/core/util.js
···
319
319
320
320
if (recent_alerts.length >= 3 &&
321
321
(recent_alerts[recent_alerts.length - 1] - recent_alerts[0]) < 5000) {
322
-
if (window.confirm(msg + "\n\nLots of alert()s recently. Kill them?")) {
322
+
if (window.confirm(msg + '\n\nLots of alert()s recently. Kill them?')) {
323
323
window.alert = JX.bag;
324
324
}
325
325
} else {
+1
-1
webroot/rsrc/externals/javelin/ext/view/__tests__/View.js
+1
-1
webroot/rsrc/externals/javelin/ext/view/__tests__/View.js
+2
-2
webroot/rsrc/externals/javelin/lib/DOM.js
+2
-2
webroot/rsrc/externals/javelin/lib/DOM.js
···
46
46
if (__DEV__) {
47
47
if (node && (node.id != id)) {
48
48
JX.$E(
49
-
'JX.$("'+id+'"): '+
49
+
'JX.$(\''+id+'\'): '+
50
50
'document.getElementById() returned an element without the '+
51
51
'correct ID. This usually means that the element you are trying '+
52
52
'to select is being masked by a form with the same value in its '+
53
53
'"name" attribute.');
54
54
}
55
55
}
56
-
JX.$E("JX.$('" + id + "') call matched no nodes.");
56
+
JX.$E('JX.$(\'' + id + '\') call matched no nodes.');
57
57
}
58
58
59
59
return node;
+2
-2
webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadSource.js
+2
-2
webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadSource.js
···
187
187
for (var k in {name : 1, id : 1, display : 1, uri : 1}) {
188
188
if (!(k in obj)) {
189
189
throw new Error(
190
-
"JX.TypeaheadSource.addResult(): " +
191
-
"result must have properties 'name', 'id', 'uri' and 'display'.");
190
+
'JX.TypeaheadSource.addResult(): result must have ' +
191
+
'properties \'name\', \'id\', \'uri\' and \'display\'.');
192
192
}
193
193
}
194
194
}
+1
-1
webroot/rsrc/js/application/releeph/releeph-request-state-change.js
+1
-1
webroot/rsrc/js/application/releeph/releeph-request-state-change.js
+2
-2
webroot/rsrc/js/core/ToolTip.js
+2
-2
webroot/rsrc/js/core/ToolTip.js