@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Calendar list event items should be entirely clickable
Summary: Ref T8248, Calendar list event items should be entirely clickable
Test Plan: Open month view, verify that adjusting screen correctly adjust widths of event links, and that entire event row links are clickable.
Reviewers: chad, epriestley, #blessed_reviewers
Reviewed By: epriestley, #blessed_reviewers
Subscribers: Korvin, epriestley
Maniphest Tasks: T8248
Differential Revision: https://secure.phabricator.com/D12925
+45
-57
+6
-6
resources/celerity/map.php
+6
-6
resources/celerity/map.php
···
121
121
'rsrc/css/layout/phabricator-side-menu-view.css' => 'c1db9e9c',
122
122
'rsrc/css/layout/phabricator-source-code-view.css' => '2ceee894',
123
123
'rsrc/css/phui/calendar/phui-calendar-day.css' => 'c0cf782a',
124
-
'rsrc/css/phui/calendar/phui-calendar-list.css' => '3e713fc7',
125
-
'rsrc/css/phui/calendar/phui-calendar-month.css' => '017a953b',
126
-
'rsrc/css/phui/calendar/phui-calendar.css' => '8345be98',
124
+
'rsrc/css/phui/calendar/phui-calendar-list.css' => '857a0d83',
125
+
'rsrc/css/phui/calendar/phui-calendar-month.css' => '32e3bee4',
126
+
'rsrc/css/phui/calendar/phui-calendar.css' => 'ccabe893',
127
127
'rsrc/css/phui/phui-action-header-view.css' => '89c497e7',
128
128
'rsrc/css/phui/phui-action-list.css' => '4f4d09f2',
129
129
'rsrc/css/phui/phui-action-panel.css' => '3ee9afd5',
···
760
760
'phui-action-panel-css' => '3ee9afd5',
761
761
'phui-box-css' => '7b3a2eed',
762
762
'phui-button-css' => 'de610129',
763
-
'phui-calendar-css' => '8345be98',
763
+
'phui-calendar-css' => 'ccabe893',
764
764
'phui-calendar-day-css' => 'c0cf782a',
765
-
'phui-calendar-list-css' => '3e713fc7',
766
-
'phui-calendar-month-css' => '017a953b',
765
+
'phui-calendar-list-css' => '857a0d83',
766
+
'phui-calendar-month-css' => '32e3bee4',
767
767
'phui-crumbs-view-css' => '594d719e',
768
768
'phui-document-view-css' => '94d5dcd8',
769
769
'phui-feed-story-css' => 'c9f3a0b5',
+12
-6
src/view/phui/calendar/PHUICalendarListView.php
+12
-6
src/view/phui/calendar/PHUICalendarListView.php
···
72
72
$class = $class.' all-day';
73
73
}
74
74
75
-
$singletons[] = phutil_tag(
76
-
'li',
75
+
$content = phutil_tag(
76
+
'a',
77
77
array(
78
-
'class' => $class,
79
-
),
78
+
'href' => '/E'.$event->getEventID(),
79
+
),
80
80
array(
81
81
$dot,
82
82
$time,
83
83
$title,
84
84
));
85
+
86
+
$singletons[] = phutil_tag(
87
+
'li',
88
+
array(
89
+
'class' => $class,
90
+
),
91
+
$content);
85
92
}
86
93
87
94
if (empty($singletons)) {
···
147
154
$class = 'phui-calendar-item';
148
155
149
156
$anchor = javelin_tag(
150
-
'a',
157
+
'span',
151
158
array(
152
159
'sigil' => 'has-tooltip',
153
160
'class' => $class,
154
-
'href' => '/E'.$event->getEventID(),
155
161
'meta' => array(
156
162
'tip' => $tip,
157
163
'size' => 200,
+9
-5
webroot/rsrc/css/phui/calendar/phui-calendar-list.css
+9
-5
webroot/rsrc/css/phui/calendar/phui-calendar-list.css
···
43
43
}
44
44
45
45
.phui-calendar-list-title {
46
-
width: 200px;
47
-
display: inline-block;
48
-
overflow: hidden;
49
-
text-overflow: ellipsis;
50
-
white-space: nowrap;
46
+
width: 200px;
47
+
display: inline-block;
48
+
overflow: hidden;
49
+
text-overflow: ellipsis;
50
+
white-space: nowrap;
51
+
}
52
+
53
+
.phui-calendar-viewer-invited .phui-calendar-list-title {
54
+
font-weight: bold;
51
55
}
52
56
53
57
.phui-calendar-list-item .phui-calendar-list-time {
+18
-39
webroot/rsrc/css/phui/calendar/phui-calendar-month.css
+18
-39
webroot/rsrc/css/phui/calendar/phui-calendar-month.css
···
151
151
152
152
.phui-calendar-view .phui-calendar-list {
153
153
padding: 1px;
154
+
width: auto;
154
155
}
155
156
156
157
.phui-calendar-list-item.all-day span {
···
160
161
161
162
.phui-calendar-view .phui-calendar-list li.phui-calendar-list-item.all-day {
162
163
height: 20px;
163
-
margin: 0;
164
-
padding: 4px 4px 0px 4px;
165
164
background-color: {$darkgreybackground};
166
165
display: block;
167
166
float: none;
···
173
172
background-color: {$lightgreen};
174
173
}
175
174
176
-
li.phui-calendar-list-item.all-day:first-child {
177
-
margin-top: 0;
175
+
.phui-calendar-view .phui-calendar-list li {
176
+
padding: 0px 4px;
178
177
}
179
178
180
-
.phui-calendar-view .phui-calendar-list li {
181
-
margin: 0 8px;
179
+
.phui-calendar-view .phui-calendar-list li a {
180
+
display: block;
181
+
overflow: hidden;
182
+
position: relative;
182
183
}
183
184
184
-
.phui-calendar-view .phui-calendar-list li:first-child {
185
-
margin-top: 8px;
185
+
.phui-calendar-view li.phui-calendar-list-item {
186
+
white-space: nowrap;
187
+
width: auto;
186
188
}
187
189
188
190
.phui-calendar-view .phui-calendar-list-dot {
189
191
position: relative;
190
-
display: inline-block;
192
+
display: block;
191
193
float: left;
192
194
width: 3px;
193
195
height: 3px;
···
198
200
display: none;
199
201
}
200
202
201
-
.phui-calendar-view li.phui-calendar-list-item {
202
-
padding: 0;
203
-
}
204
-
205
203
.phui-calendar-view li.phui-calendar-list-item .phui-calendar-list-title {
206
-
position: relative;
207
-
/*float: right;*/
208
-
display: inline-block;
209
-
width: 120px;
210
-
padding: 0;
211
-
line-height: 18px;
212
-
vertical-align: center;
213
-
}
214
-
215
-
li.phui-calendar-list-item .phui-calendar-list-title a {
216
-
padding: 0;
217
-
vertical-align: top;
218
-
line-height: 16px;
204
+
width: auto;
205
+
position: absolute;
206
+
right: 0;
207
+
left: 60px;
208
+
text-overflow: ellipsis;
219
209
overflow: hidden;
220
-
text-overflow: ellipsis;
221
210
white-space: nowrap;
222
211
}
223
212
224
-
li.phui-calendar-list-item.all-day .phui-calendar-list-title a{
225
-
color: {$greytext};
226
-
margin: 0;
227
-
padding: 0;
228
-
}
229
-
230
-
li.phui-calendar-viewer-invited.all-day .phui-calendar-list-title a{
231
-
color: {$green};
213
+
li.all-day {
214
+
line-height: 18px;
232
215
}
233
216
234
217
.phui-calendar-view li.phui-calendar-list-item .phui-calendar-list-time {
···
241
224
color: {$lightgreytext};
242
225
text-align: left;
243
226
}
244
-
245
-
li.phui-calendar-list-item.all-day .phui-calendar-list-time{
246
-
margin: 0 0 0 4px;
247
-
}