@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix a couple of home menu issues for logged-out viewers
Summary: Ref T12174. These items could fatal (`$item not defined`) if the viewer was not logged in.
Test Plan: - Viewed home as a logged-out user.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T12174
Differential Revision: https://secure.phabricator.com/D17274
+19
-25
+1
-7
src/applications/home/controller/PhabricatorHomeMenuItemController.php
+1
-7
src/applications/home/controller/PhabricatorHomeMenuItemController.php
···
14
14
public function handleRequest(AphrontRequest $request) {
15
15
$viewer = $this->getViewer();
16
16
17
-
if ($viewer->getPHID()) {
18
-
$custom_phid = $viewer->getPHID();
19
-
} else {
20
-
$custom_phid = null;
21
-
}
22
-
23
17
$application = 'PhabricatorHomeApplication';
24
18
$home_app = id(new PhabricatorApplicationQuery())
25
19
->setViewer($viewer)
···
29
23
30
24
$engine = id(new PhabricatorHomeProfileMenuEngine())
31
25
->setProfileObject($home_app)
32
-
->setCustomPHID($custom_phid)
26
+
->setCustomPHID($viewer->getPHID())
33
27
->setController($this);
34
28
35
29
return $engine->buildResponse();